Alon Bar-Lev has uploaded a new change for review.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent ......................................................................
test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent
The tested module vdsm/configNetwork.py is trying to chown files to vdsm user, if user is not available the test fails.
This change makes configNetworkTests.py::testPersistentBackup be skipped if not root running test, as it won't be able to chown or if vdsm user is absent as pwd.getpwnam will fail.
Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M tests/configNetworkTests.py 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/6492/1 -- To view, visit http://gerrit.ovirt.org/6492 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File tests/configNetworkTests.py Line 112: raise SkipTest("This test must be run as root") actually, I tried hard to monkey patch os.chown, so root is not needed.
Line 114: pwd.getpwnam('vdsm') that's acceptable with the current state of the code, but I actually think that we'd be better off ditching these chown's from vdsm proper. Why do we even need them?
-- To view, visit http://gerrit.ovirt.org/6492 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File tests/configNetworkTests.py Line 114: pwd.getpwnam('vdsm') I don't know why exactly do we need it....
vdsm.configNetwork.ConfigWriter::_persistentBackup vdsm_uid = pwd.getpwnam('vdsm').pw_uid
If it runs under vdsm user, there is no need indeed...
-- To view, visit http://gerrit.ovirt.org/6492 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Bing Bu Cao has posted comments on this change.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I think this patch is a duplication of the patch: http://gerrit.ovirt.org/#/c/6460/
-- To view, visit http://gerrit.ovirt.org/6492 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent ......................................................................
Patch Set 1:
I think this patch is a duplication of the patch: http://gerrit.ovirt.org/#/c/6460/
Does not matter. Please merge either or solve it properly....
-- To view, visit http://gerrit.ovirt.org/6492 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Alon Bar-Lev has abandoned this change.
Change subject: test: skip configNetworkTests.py::testPersistentBackup if not root or vdsm user absent ......................................................................
Patch Set 1: Abandoned
Obsolete by[1]
[1] http://gerrit.ovirt.org/#/c/6610/
-- To view, visit http://gerrit.ovirt.org/6492 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ia5e3a2ce6616f6313363079ad24fd62f86504071 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
vdsm-patches@lists.fedorahosted.org