Change in vdsm[master]: Remove (almost all) class Volume virtual (!) methods.

Eduardo has uploaded a new change for review.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Remove (almost all) class Volume virtual (!) methods.

Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Signed-off-by: Eduardo 
---
M vdsm/storage/sd.py
M vdsm/storage/volume.py
2 files changed, 0 insertions(+), 121 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/3461/1
--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

I hope you checked that all of these exist in both file and block subclasses

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

This conflicts a little bit with my work on the volumes.

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Patch Set 2:

I've never understood your vendetta against pure virtual functions in Python. The functions that you are removing should have raised "UnimplentedError" instead of returning None, but other than that, they have merit for documenting the abstract class.

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Patch Set 2: Verified; Looks good to me, approved

If everybody loves this... ok...

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove (almost all) class Volume virtual (!) methods.
......................................................................

Remove (almost all) class Volume virtual (!) methods.

Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Signed-off-by: Eduardo 
---
M vdsm/storage/sd.py
M vdsm/storage/volume.py
2 files changed, 0 insertions(+), 121 deletions(-)

Approvals:
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3461
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi