Change in vdsm[master]: spec: install libvirt-hook.sh in Makefile.am

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: spec: install libvirt-hook.sh in Makefile.am
......................................................................

spec: install libvirt-hook.sh in Makefile.am

Another step to clean %install in the spec file.

Change-Id: Ib9affdae684a6a2b33a98d82759c2c05fcca880e
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/virt/Makefile.am
M vdsm.spec.in
2 files changed, 2 insertions(+), 5 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/79435/1

diff --git a/lib/vdsm/virt/Makefile.am b/lib/vdsm/virt/Makefile.am
index 7bcad61..84c97fd 100644
--- a/lib/vdsm/virt/Makefile.am
+++ b/lib/vdsm/virt/Makefile.am
@@ -55,6 +55,7 @@
    vm_migrate_hook.py \
    $(NULL)

-EXTRA_DIST = \
+libvirthoookdir = /etc/libvirt/hooks/qemu
+dist_libvirthoook_SCRIPTS = \
    libvirt-hook.sh \
    $(NULL)
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 8ba16d8..9e28859 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -743,10 +743,6 @@
 install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
 %endif

-# Install the libvirt hook for cleaning up the XML
-install -Dm 0755 lib/vdsm/virt/libvirt-hook.sh \
-                 %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
-
 %pre
 # Force standard locale behavior (English)
 export LC_ALL=C

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: install libvirt-hook.sh in Makefile.am
......................................................................

Patch Set 1: Verified+1

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: install libvirt-hook.sh in Makefile.am
......................................................................

Patch Set 2: Verified+1

simple rename vs former version

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: install libvirt-hook.sh in Makefile.am
......................................................................

Patch Set 2: Code-Review-1

we should instead move libvirt-hook.sh to static/etc/libvirt/hook/qemu

Change in vdsm[master]: spec: move libvirt-hook.sh to its static location

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: spec: move libvirt-hook.sh to its static location
......................................................................

Patch Set 3: Verified+1

$ rpmdiff /home/danken/.rpm/RPMS/x86_64/vdsm-4.20.1-200.git4b74487.fc25.x86_64.rpm /home/danken/.rpm/RPMS/x86_64/vdsm-4.20.1-201.git3bdf337.fc25.x86_64.rpm  |grep libvirt.hook
..........T /etc/libvirt/hooks/qemu

showed no change in hook place content or permission.