From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: cmdutils: Introduce the receive() helper ......................................................................
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/74927/11//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2017-04-03 21:56:56 +0300 Line 6: Line 7: cmdutils: Introduce the receive() helper Line 8: Line 9: cmdutils.receive() replaces both both commands.AsyncProc and remove one both Line 10: utils.CommandStream. This function allows reading from sub process Line 11: stdout and stderr in the same time, without using callbacks as in Line 12: utils.CommandStream, and avoiding the performance issues and the Line 13: complexity of utils.AsyncProc. This function is also python 3
Line 10: utils.CommandStream. This function allows reading from sub process Line 11: stdout and stderr in the same time, without using callbacks as in Line 12: utils.CommandStream, and avoiding the performance issues and the Line 13: complexity of utils.AsyncProc. This function is also python 3 Line 14: compatible. all new code is py3 compatible.. no need to mention imo Line 15: Line 16: cmdutils.receive() does not support writing to and reading from a sub Line 17: process in one thread in the same time. This is supported by Line 18: commands.AsyncProc, but I don't know of any real world use case for
vdsm-patches@lists.fedorahosted.org