Adam Litke has uploaded a new change for review.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7 Signed-off-by: Adam Litke alitke@redhat.com --- M tests/storage_sdm_copy_data_test.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/65149/1
diff --git a/tests/storage_sdm_copy_data_test.py b/tests/storage_sdm_copy_data_test.py index 948d170..6b116d5 100644 --- a/tests/storage_sdm_copy_data_test.py +++ b/tests/storage_sdm_copy_data_test.py @@ -275,7 +275,8 @@ job_id = make_uuid() job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest) t = start_thread(job.run) - fake_convert.ready_event.wait() + if not fake_convert.ready_event.wait(1): + raise RuntimeError("Timeout waiting for thread") job.abort() t.join(1) if t.isAlive():
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Adam Litke has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
Patch Set 2: Verified+1
Nir Soffer has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
Patch Set 2: Code-Review+2
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7 Signed-off-by: Adam Litke alitke@redhat.com Reviewed-on: https://gerrit.ovirt.org/65149 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsoffer@redhat.com --- M tests/storage_sdm_copy_data_test.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org