From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce bond properties and refactoring options handling
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/71024/3/lib/vdsm/network/link/bond/sysfs_option...
File lib/vdsm/network/link/bond/sysfs_options.py:
PS3, Line 102: _
no need to change this to lowercase
or a test for this newly-public function
--
To view, visit
https://gerrit.ovirt.org/71024
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Dominik Holler
dholler@redhat.com
Gerrit-Reviewer: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes