Change in vdsm[master]: BZ#674010 - Fix name error in vdsClient - 'commands' not fou...

[Haim Ateya]

Haim Ateya has uploaded a new change for review.

Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................

BZ#674010 - Fix name error in vdsClient - 'commands' not found

Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
---
M vdsm_cli/vdsClient.py
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/906/1
--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Haim Ateya

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_cli/vdsClient.py
Line 1464:         commands = {}
to me it makes more sense to move the original definition of commands to here. ahm, actually - it should be out of the try:except block.

--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................

Patch Set 2: Verified

- basic client sanity
- original error was fixed

--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................

BZ#674010 - Fix name error in vdsClient - 'commands' not found

Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
---
M vdsm_cli/vdsClient.py
1 file changed, 474 insertions(+), 474 deletions(-)

Approvals:
  Haim Ateya: Verified
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eduardo 
Gerrit-Reviewer: Haim Ateya