Change in vdsm[master]: Don't use qemu-img to create sparse file volumes

[Federico Simoncelli]

Federico Simoncelli has uploaded a new change for review.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Don't use qemu-img to create sparse file volumes

It's not required to run volume.createVolume when we are creating a
sparse file volume (see createSparseFile few lines above).

Signed-off-by: Federico Simoncelli 
Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
---
M vdsm/storage/fileVolume.py
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/3626/1
--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky

Mark Wu has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 173
It looks you need remove the comment above together.

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

Mark Wu has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 3: Looks good to me, approved

fair enough

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 4: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Don't use qemu-img to create sparse file volumes
......................................................................

Don't use qemu-img to create sparse file volumes

It's not required to run volume.createVolume when we are creating a
sparse file volume (see createSparseFile few lines above).

Signed-off-by: Federico Simoncelli 
Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
---
M vdsm/storage/fileVolume.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved
  Igor Lvovsky: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11e705319ae4c0c5c5823c52ee54d20e90923c22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Mark Wu