Change in vdsm[master]: BZ#813423: Adding ENGINENAME macro

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

BZ#813423: Adding ENGINENAME macro

To help backward compatibility, let's create ENGINENAME macro which
will contain the engine name.

Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Signed-off-by: Douglas Schilling Landgraf 
---
M configure.ac
M vdsm/vdsmd.8.in
M vdsm_reg/Makefile.am
M vdsm_reg/deployUtil.py.in
R vdsm_reg/engine.py.in
5 files changed, 29 insertions(+), 24 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/3761/1
--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

Hey! it is a weekend! I did not expect such an immediate response!

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

Bruce Bai has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Bruce Bai 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

ShaoHe Feng has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Bruce Bai 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Shu Ming

ShaoHe Feng has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1:

but there are some command help infos and variables using "RHEVM".  I wonder should we clean them ?

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Bruce Bai 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Shu Ming

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1: Looks good to me, approved
> ShaoHe Feng		5:53 PM
> but there are some command help infos and variables using "RHEVM". I wonder should we clean them ?

Yes, probably. But if they affect an existing Vdsm API, it should be done with care.

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Bruce Bai 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Shu Ming

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

BZ#813423: Adding ENGINENAME macro

To help backward compatibility, let's create ENGINENAME macro which
will contain the engine name.

Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Signed-off-by: Douglas Schilling Landgraf 
---
M configure.ac
M vdsm/vdsmd.8.in
M vdsm_reg/Makefile.am
M vdsm_reg/deployUtil.py.in
R vdsm_reg/engine.py.in
5 files changed, 29 insertions(+), 24 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  ShaoHe Feng: Looks good to me, but someone else must approve
  Bruce Bai: Looks good to me, but someone else must approve
  Shu Ming: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Bruce Bai 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: ShaoHe Feng 
Gerrit-Reviewer: Shu Ming

Shu Ming has posted comments on this change.

Change subject: BZ#813423: Adding ENGINENAME macro
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3761
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb9876fba6d1de0b2a2295cd0e301219f0e04bdd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Bruce Bai 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Shu Ming