Change in vdsm[master]: hsm: Return true "truesize" for block volumes

Change in vdsm[master]: virt: Fix...

Change in vdsm[master]: supervdsm:...

Nir Soffer

Friday, 13 February 2015 Fri, 13 Feb '15

3:17 p.m.

Nir Soffer has uploaded a new change for review. Change subject: hsm: Return true "truesize" for block volumes ...................................................................... hsm: Return true "truesize" for block volumes HSM.getVolumeSize() and HSM.getVolumeInfo() used to return bogus value for "truesize" for block volumes. This evil undocumented lie was introduced in commit commit 1cef1409b1 (BZ#551944 - VDSM: getVolumeInfo: Actual size field is not correct for RAW sparse files) on 2010. Now we obtain block volumes "truesize" using qemu-img info. Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/37785/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index caaef6b..ebde78c 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -617,7 +617,9 @@ return int(size) - getVAllocSize = getVSize + def getVAllocSize(self, imgUUID, volUUID): + """ Returns block volume true size in bytes. """ + return self.produceVolume(imgUUID, volUUID).getVolumeTrueSize(bs=1) def validateCreateVolumeParams(self, volFormat, srcVolUUID, preallocate=None): diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index 2bb9a78..99c8840 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -643,7 +643,14 @@ sdobj = sdCache.produce(sdUUID=self.sdUUID) return int(sdobj.getVSize(self.imgUUID, self.volUUID) / bs) - getVolumeTrueSize = getVolumeSize + def getVolumeTrueSize(self, bs=BLOCK_SIZE): + """ + Return the volume true size in blocks + + Raises qemuimg.QImgError if volume size cannot be obtained. + """ + info = qemuimg.info(self.getVolumePath()) + return int(info["virtualsize"] / bs) def _extendSizeRaw(self, newSize): # Since this method relies on lvm.extendLV (lvextend) when the -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>

Show replies by date

automation＠ovirt.org

Friday, 13 February Fri, 13 Feb

3:18 p.m.

automation＠ovirt.org

6:42 p.m.

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes ...................................................................... Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Nir Soffer

6:47 p.m.

Nir Soffer has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes ...................................................................... Patch Set 2: Verified by running LSM during system installation few times on rhel 7. Needs more testing with live merge and other flows. Note that engine does not like this change, using "truesize" for actual size instead of "apparentsize". -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

6:53 p.m.

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes ...................................................................... Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Nir Soffer

6:54 p.m.

Nir Soffer has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes ...................................................................... Patch Set 3: This version remove duplicate word in the commit message -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

derez＠redhat.com

Monday, 16 February Mon, 16 Feb

9:51 a.m.

Daniel Erez has posted comments on this change. Change subject: hsm: Return true "truesize" for block volumes ...................................................................... Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37785/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 618: return int(size) Line 619: Line 620: def getVAllocSize(self, imgUUID, volUUID): Line 621: """ Returns block volume true size in bytes. """ Line 622: return self.produceVolume(imgUUID, volUUID).getVolumeTrueSize(bs=1) The engine treats 'truesize' as actual size (as opposed to 'apparentsize' which represents the virtual size - the size that is visible to the VM). So I think we should simply switch the logic of these functions (getVSize and getVAllocSize) to correlate the behavior of fileSD - just need to be careful with the current usages of 'getVSize'... :) Line 623: Line 624: def validateCreateVolumeParams(self, volFormat, srcVolUUID, Line 625: preallocate=None): Line 626: super(BlockStorageDomain, self).validateCreateVolumeParams( -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: Yes

automation＠ovirt.org

12:01 p.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Nir Soffer

12:15 p.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

Nir Soffer has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 4: This version address Daniel comments. -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

automation＠ovirt.org

12:21 p.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Nir Soffer

1:41 p.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

Nir Soffer has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 5: Quick tests: - Create vm and install os using file-thin disk - Create vm and install os using blokc-thin disk including extend during the installation - Live storage migration on block-thin disk while dd'ing to the disk - completed but the snapshot seems to be extended too much - need to check why. - Create vm from template using block-thin disk - failed not sure how this is related. -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Nir Soffer

5:15 p.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

Nir Soffer has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 5: Verified-1 This is not going to work, there is code like Image.copyCollapse that assume that Volume.getVolumeParams() can be called without preparing an image, so we currently we cannot implement getVolumeSize using qemu-img. We have the volume size in the metadata block of the volume, which should be the virtual size of the volume, maybe we should use it for apparentsize, or as a fallback if the device does not exists. -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

Jenkins CI RO

Tuesday, 17 February Tue, 17 Feb

1:08 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15656/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14855/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/632/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

2:21 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14864/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/641/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

2:37 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14866/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15836/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/643/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

2:50 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14931/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15901/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/708/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

2:50 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14935/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15905/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/712/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

automation＠ovirt.org

Thursday, 19 February Thu, 19 Feb

4:15 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

automation＠ovirt.org

4:19 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

5:41 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15048/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16019/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/825/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Jenkins CI RO

5:57 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15851/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15050/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16021/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/827/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

Nir Soffer

Thursday, 13 August Thu, 13 Aug

11:27 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

Nir Soffer has abandoned this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Abandoned Incorrect direction - apparentsize is *not* the virtual size. -- To view, visit https://gerrit.ovirt.org/37785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

automation＠ovirt.org

11:27 a.m.

New subject: Change in vdsm[master]: hsm: Fix file and block volume sizes mismatch

automation(a)ovirt.org has posted comments on this change. Change subject: hsm: Fix file and block volume sizes mismatch ...................................................................... Patch Set 7: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/37785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e726727ef96f26a5d04ef86c87cb18d1ef658f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

3240

days inactive

3421

days old

vdsm-patches@lists.fedorahosted.org

Manage subscription

22 comments

4 participants

tags (0)

participants (4)

automation＠ovirt.org
derez＠redhat.com
Jenkins CI RO
Nir Soffer

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Change in vdsm[master]: hsm: Return true "truesize" for block volumes