From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter ......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2017-06-26 11:22:07 +0200 Line 4: Commit: Andrej Krejcir akrejcir@redhat.com Line 5: CommitDate: 2017-07-11 15:54:35 +0200 Line 6: Line 7: RPC: Refactor ClientRpcTransportAdapter if you call it "Refactor" - why not also to move this code out of stompreactor and have all client code in one module.common code between server to client can be maybe in this module/. what do you think? Line 8: Line 9: The class now subscribes in the constructor, Line 10: instead of taking an existing subscription Line 11: as a parameter.
vdsm-patches@lists.fedorahosted.org