Francesco Romani has uploaded a new change for review.
Change subject: virt: devices: move device creation in a submodule ......................................................................
virt: devices: move device creation in a submodule
In the Vm class, the vm devices are arranged in a tree-like structure. This patch moves the related code into a new hwtree module into the vmdevices subpackages.
Change-Id: If17cce15f653843848eea42b567a0e4454757cd1 Signed-off-by: Francesco Romani fromani@redhat.com --- M debian/vdsm.install M vdsm.spec.in M vdsm/virt/vm.py M vdsm/virt/vmdevices/Makefile.am A vdsm/virt/vmdevices/hwtree.py 5 files changed, 63 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/38077/1
diff --git a/debian/vdsm.install b/debian/vdsm.install index cd71517..38bc299 100644 --- a/debian/vdsm.install +++ b/debian/vdsm.install @@ -162,6 +162,7 @@ ./usr/share/vdsm/virt/vmdevices/core.py ./usr/share/vdsm/virt/vmdevices/graphics.py ./usr/share/vdsm/virt/vmdevices/hwclass.py +./usr/share/vdsm/virt/vmdevices/hwtree.py ./usr/share/vdsm/virt/vmdevices/network.py ./usr/share/vdsm/virt/vmdevices/storage.py ./var/lib/polkit-1/localauthority/10-vendor.d/10-vdsm-libvirt-access.pkla diff --git a/vdsm.spec.in b/vdsm.spec.in index 0740530..824dd31 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -1073,6 +1073,7 @@ %{_datadir}/%{vdsm_name}/virt/vmdevices/core.py* %{_datadir}/%{vdsm_name}/virt/vmdevices/graphics.py* %{_datadir}/%{vdsm_name}/virt/vmdevices/hwclass.py* +%{_datadir}/%{vdsm_name}/virt/vmdevices/hwtree.py* %{_datadir}/%{vdsm_name}/virt/vmdevices/network.py* %{_datadir}/%{vdsm_name}/virt/vmdevices/storage.py* %{_datadir}/%{vdsm_name}/tool diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index c9ba79b..19be5f2 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -63,6 +63,7 @@ from . import vmexitreason from . import vmstatus from .vmdevices import hwclass +from .vmdevices import hwtree from .vmtune import update_io_tune_dom, collect_inner_elements from .vmtune import io_tune_values_to_dom, io_tune_dom_to_values from . import vmxml @@ -767,23 +768,6 @@ log = logging.getLogger("vm.Vm") # limit threads number until the libvirt lock will be fixed _ongoingCreations = threading.BoundedSemaphore(4) - DeviceMapping = ((hwclass.DISK, vmdevices.storage.Drive), - (hwclass.NIC, vmdevices.network.Interface), - (hwclass.SOUND, vmdevices.core.Sound), - (hwclass.VIDEO, vmdevices.core.Video), - (hwclass.GRAPHICS, vmdevices.graphics.Graphics), - (hwclass.CONTROLLER, vmdevices.core.Controller), - (hwclass.GENERAL, vmdevices.core.Generic), - (hwclass.BALLOON, vmdevices.core.Balloon), - (hwclass.WATCHDOG, vmdevices.core.Watchdog), - (hwclass.CONSOLE, vmdevices.core.Console), - (hwclass.REDIR, vmdevices.core.Redir), - (hwclass.RNG, vmdevices.core.Rng), - (hwclass.SMARTCARD, vmdevices.core.Smartcard), - (hwclass.TPM, vmdevices.core.Tpm)) - - def _makeDeviceDict(self): - return dict((dev, []) for dev, _ in self.DeviceMapping)
def _makeChannelPath(self, deviceName): return constants.P_LIBVIRT_VMCHANNELS + self.id + '.' + deviceName @@ -852,7 +836,7 @@ self.stopDisksStatsCollection() self._vmCreationEvent = threading.Event() self._pathsPreparedEvent = threading.Event() - self._devices = self._makeDeviceDict() + self._devices = hwtree.empty()
self._connection = libvirtconnection.get(cif) if 'vmName' not in self.conf: @@ -968,7 +952,7 @@ Return the "devices" section of this Vm's conf. If missing, create it according to old API. """ - devices = self._makeDeviceDict() + devices = hwtree.empty()
# For BC we need to save previous behaviour for old type parameters. # The new/old type parameter will be distinguished @@ -2189,10 +2173,7 @@ # rebooting it. Evident on, but not limited to, the HE case. self._fixLegacyConf()
- for devType, devClass in self.DeviceMapping: - for dev in devices[devType]: - self._devices[devType].append(devClass(self.conf, self.log, - **dev)) + self._devices = hwtree.build(devices, self.conf, self.log)
# We should set this event as a last part of drives initialization self._pathsPreparedEvent.set() diff --git a/vdsm/virt/vmdevices/Makefile.am b/vdsm/virt/vmdevices/Makefile.am index 71b0573..3678ccd 100644 --- a/vdsm/virt/vmdevices/Makefile.am +++ b/vdsm/virt/vmdevices/Makefile.am @@ -24,6 +24,7 @@ core.py \ graphics.py \ hwclass.py \ + hwtree.py \ network.py \ storage.py \ $(NULL) diff --git a/vdsm/virt/vmdevices/hwtree.py b/vdsm/virt/vmdevices/hwtree.py new file mode 100644 index 0000000..309db22 --- /dev/null +++ b/vdsm/virt/vmdevices/hwtree.py @@ -0,0 +1,56 @@ +# +# Copyright 2014 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +from . import core +from . import hwclass +from . import graphics +from . import network +from . import storage + + +_DEVICE_MAPPING = ( + (hwclass.DISK, storage.Drive), + (hwclass.NIC, network.Interface), + (hwclass.SOUND, core.Sound), + (hwclass.VIDEO, core.Video), + (hwclass.GRAPHICS, graphics.Graphics), + (hwclass.CONTROLLER, core.Controller), + (hwclass.GENERAL, core.Generic), + (hwclass.BALLOON, core.Balloon), + (hwclass.WATCHDOG, core.Watchdog), + (hwclass.CONSOLE, core.Console), + (hwclass.REDIR, core.Redir), + (hwclass.RNG, core.Rng), + (hwclass.SMARTCARD, core.Smartcard), + (hwclass.TPM, core.Tpm)) + + +def empty(): + return dict((dev, []) for dev, _ in _DEVICE_MAPPING) + + +def build(dev_conf, vm_conf, log): + devices = empty() + + for devType, devClass in _DEVICE_MAPPING: + for dev in dev_conf[devType]: + devices[devType].append(devClass(vm_conf, log, **dev)) + + return devices
automation@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/498/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/490... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2536/ : There was an infra issue, please contact infra@ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16009/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1056... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15208/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16179/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/985/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/103... : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Minor questions, great effort.
https://gerrit.ovirt.org/#/c/38077/1/vdsm/virt/vmdevices/hwtree.py File vdsm/virt/vmdevices/hwtree.py:
Line 1: # Line 2: # Copyright 2014 Red Hat, Inc. Something I need to ask for my own patches: don't we want 2015 here? Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 40: (hwclass.RNG, core.Rng), Line 41: (hwclass.SMARTCARD, core.Smartcard), Line 42: (hwclass.TPM, core.Tpm)) Line 43: Line 44: I'm not sure about the name here, wouldn't something like init be nicer? hwtree.init actually tells me, that the tree is ready for use while hwtree.empty isn't something I'd understand. Line 45: def empty(): Line 46: return dict((dev, []) for dev, _ in _DEVICE_MAPPING) Line 47: Line 48:
Line 48: Line 49: def build(dev_conf, vm_conf, log): Line 50: devices = empty() Line 51: Line 52: for devType, devClass in _DEVICE_MAPPING: Since this is new module, I'd go with dev_type and dev_class (possibly future patch). Line 53: for dev in dev_conf[devType]: Line 54: devices[devType].append(devClass(vm_conf, log, **dev)) Line 55:
Francesco Romani has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 1:
(3 comments)
thanks for the comments!
https://gerrit.ovirt.org/#/c/38077/1/vdsm/virt/vmdevices/hwtree.py File vdsm/virt/vmdevices/hwtree.py:
Line 1: # Line 2: # Copyright 2014 Red Hat, Inc.
Something I need to ask for my own patches: don't we want 2015 here?
Yes, the problem is just I keep forgetting to follow my own advice. Will fix. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 40: (hwclass.RNG, core.Rng), Line 41: (hwclass.SMARTCARD, core.Smartcard), Line 42: (hwclass.TPM, core.Tpm)) Line 43: Line 44:
I'm not sure about the name here, wouldn't something like init be nicer? hw
init is nicer and will change to use it. Thanks! Line 45: def empty(): Line 46: return dict((dev, []) for dev, _ in _DEVICE_MAPPING) Line 47: Line 48:
Line 48: Line 49: def build(dev_conf, vm_conf, log): Line 50: devices = empty() Line 51: Line 52: for devType, devClass in _DEVICE_MAPPING:
Since this is new module, I'd go with dev_type and dev_class (possibly futu
right, and no need to wait. Will fix (here and possibly everything else) Line 53: for dev in dev_conf[devType]: Line 54: devices[devType].append(devClass(vm_conf, log, **dev)) Line 55:
automation@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 2:
fixes Martin's comment, take the chance to bootstrap tests.
Martin Polednik has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 2: Code-Review+1
Francesco Romani has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 2:
patch passed basic verification, done by booting a VM. Changes affects the codepath shared by all the creation flows, so this is already a good proof that patch is safe. However I'd like to try out migrations, just in case.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/507/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/499... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2567/ : There was an infra issue, please contact infra@ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16102/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1065... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15302/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16272/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1078/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/104... : FAILURE
Francesco Romani has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 2: Verified+1
patched VDSM handled VM creation, migration and recovery just fine.
automation@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16917/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/638/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1197...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/630...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/117...
Martin Polednik has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3: Code-Review+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17090/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/638/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/630... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16917/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1197... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17090/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/117... : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16928/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/118...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/635...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1202...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17101/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/643/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/635... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16928/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1202... : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17101/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/118... : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17106/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/675/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/121...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1234...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/667...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17280/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/675/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/667... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17106/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1234... : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17280/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/121... : FAILURE
Martin Polednik has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/38077/5//COMMIT_MSG Commit Message:
Line 6: Line 7: virt: devices: move device creation in a submodule Line 8: Line 9: In the Vm class, the vm devices are arranged in a Line 10: tree-like structure. the vmdevice object are kept in lists per device type, held together in a dictionary.
This is a very degenerate kind of tree. Its tree-ness is nothing more than an easy way to access all devices of a specicic type. It has nothing to do with device tree a-la libvirt's nodedev.
I think that we should hide this implementation detail, rather than cast it into a module name. How about defining a vmdevcontainer class, with a function like iter_by_type()? I think this would prove a more future-proof approach. Line 11: This patch moves the related code into a new Line 12: hwtree module into the vmdevices subpackages. Line 13: Line 14: Change-Id: If17cce15f653843848eea42b567a0e4454757cd1
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38077/5//COMMIT_MSG Commit Message:
Line 6: Line 7: virt: devices: move device creation in a submodule Line 8: Line 9: In the Vm class, the vm devices are arranged in a Line 10: tree-like structure.
the vmdevice object are kept in lists per device type, held together in a d
vmdevcontainer is a lousy name. virt.vmdevices.container is ever so slightly better. also, it should be iter_by_hwclass(), not type Line 11: This patch moves the related code into a new Line 12: hwtree module into the vmdevices subpackages. Line 13: Line 14: Change-Id: If17cce15f653843848eea42b567a0e4454757cd1
Francesco Romani has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5: Code-Review-1 Verified-1
(1 comment)
https://gerrit.ovirt.org/#/c/38077/5//COMMIT_MSG Commit Message:
Line 6: Line 7: virt: devices: move device creation in a submodule Line 8: Line 9: In the Vm class, the vm devices are arranged in a Line 10: tree-like structure.
vmdevcontainer is a lousy name.
Understood. Then this patch has no more any value, will restart from scratch. Line 11: This patch moves the related code into a new Line 12: hwtree module into the vmdevices subpackages. Line 13: Line 14: Change-Id: If17cce15f653843848eea42b567a0e4454757cd1
Francesco Romani has abandoned this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Abandoned
wrong direction
automation@ovirt.org has posted comments on this change.
Change subject: virt: devices: move device creation in a submodule ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org