Change in vdsm[master]: net: tests: rename Interface methods.

Ido Barkan has uploaded a new change for review.

Change subject: net: tests: rename Interface methods.
......................................................................

net: tests: rename Interface methods.

Now they correspond better to the iproute2 commands that they call

Change-Id: I8c667c11d709f9f888554bb4800dabb61097828a
Signed-off-by: Ido Barkan 
---
M tests/nettestlib.py
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/44693/1

diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 5540207..2a56927 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -55,10 +55,10 @@
     def __init__(self, prefix='vdsm-'):
         self.devName = random_iface_name(prefix)

-    def _ifUp(self):
+    def _up(self):
         check_call([EXT_IP, "link", "set", self.devName, "up"])

-    def _ifDown(self):
+    def _down(self):
         with monitor.Monitor(groups=('link',), timeout=2) as mon:
             check_call([EXT_IP, "link", "set", self.devName, "down"])
             for event in mon:
@@ -75,10 +75,10 @@
     def addDevice(self):
         check_call([EXT_IP, 'link', 'add', 'dev', self.devName, 'type',
                     'bridge'])
-        self._ifUp()
+        self._up()

def delDevice(self):
-        self._ifDown()
+        self._down()
         check_call([EXT_IP, 'link', 'del', self.devName])

def addIf(self, dev):
@@ -113,10 +113,10 @@
         ifr = struct.pack('16sH', self.devName, self._IFF_TAP |
                           self._IFF_NO_PI)
         fcntl.ioctl(self._cloneDevice, self._TUNSETIFF, ifr)
-        self._ifUp()
+        self._up()

def delDevice(self):
-        self._ifDown()
+        self._down()
         self._cloneDevice.close()

def startListener(self, icmp):

[e-mail] has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Petr Horáček has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 1: Code-Review+1

[e-mail] has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 2: Code-Review+2

Ido Barkan has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 2: Verified+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 2: Continuous-Integration+1

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: tests: rename Interface methods.
......................................................................

net: tests: rename Interface methods.

Now they correspond better to the iproute2 commands that they call

Change-Id: I8c667c11d709f9f888554bb4800dabb61097828a
Signed-off-by: Ido Barkan 
Reviewed-on: https://gerrit.ovirt.org/44693
Reviewed-by: Petr Horáček 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Dan Kenigsberg 
---
M tests/nettestlib.py
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Ido Barkan: Verified
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests

[e-mail] has posted comments on this change.

Change subject: net: tests: rename Interface methods.
......................................................................

Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.