Nir Soffer has posted comments on this change.
Change subject: storage: check if mount specification is a symlink ......................................................................
Patch Set 1:
(1 comment)
Thanks for your patch Enrico!
http://gerrit.ovirt.org/#/c/27321/1/vdsm/storage/mount.py File vdsm/storage/mount.py:
Line 265: realSpec = self.fs_spec Line 266: # if this is a symlink we need the real path Line 267: # to check against /proc/mounts Line 268: if os.path.lexists(realSpec): Line 269: realSpec = os.path.realpath(self.fs_spec) Any reason to use os.path.lexists? Why not always normalize the path?
realSpec = os.path.realpath(self.fs_spec) Line 270: if (record.fs_spec == realSpec and Line 271: record.fs_file == self.fs_file): Line 272: return record Line 273:
vdsm-patches@lists.fedorahosted.org