vdsm-patches October 2011

vdsm-patches@lists.fedorahosted.org

14 participants
403 discussions

Change in vdsm[master]: Move iscsid.conf template outside of the source file
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has posted comments on this change. Change subject: Move iscsid.conf template outside of the source file ...................................................................... Patch Set 8: I would prefer that you didn't submit this please try `make rpm` before resubmitting. -- To view, visit http://gerrit.usersys.redhat.com/1034 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix missing arg in sp.StoragePool() call.
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix missing arg in sp.StoragePool() call. ...................................................................... Fix missing arg in sp.StoragePool() call. Fix reconstruct master flow. Change-Id: I00668572ca1aa4484171049393d4788046707c71 --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1068 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00668572ca1aa4484171049393d4788046707c71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix missing arg in sp.StoragePool() call.
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has posted comments on this change. Change subject: Fix missing arg in sp.StoragePool() call. ...................................................................... Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1068 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00668572ca1aa4484171049393d4788046707c71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix unsecured on forceFreeSpm().
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix unsecured on forceFreeSpm(). ...................................................................... Fix unsecured on forceFreeSpm(). Change-Id: I4d224cd739e3bd13c5bcd9a8ed17818b8211187f --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1067 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d224cd739e3bd13c5bcd9a8ed17818b8211187f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix unsecured on forceFreeSpm().
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has posted comments on this change. Change subject: Fix unsecured on forceFreeSpm(). ...................................................................... Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1067 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d224cd739e3bd13c5bcd9a8ed17818b8211187f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix lock release and reversed SPM logic.
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix lock release and reversed SPM logic. ...................................................................... Fix lock release and reversed SPM logic. Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692 --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 33 insertions(+), 36 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1066 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix lock release and reversed SPM logic.
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has posted comments on this change. Change subject: Fix lock release and reversed SPM logic. ...................................................................... Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1066 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fix lock release and reversed SPM logic.
by Dan Kenigsberg 29 Oct '11

29 Oct '11

Dan Kenigsberg has posted comments on this change. Change subject: Fix lock release and reversed SPM logic. ...................................................................... Patch Set 5: Verified; Looks good to me, approved "in SPM_FREE" is obviously wrong -- To view, visit http://gerrit.usersys.redhat.com/1066 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Generalize _parseDriveSpec dictionaries.
by ewarszaw＠redhat.com 27 Oct '11

27 Oct '11

Eduardo Warszawski has posted comments on this change. Change subject: Generalize _parseDriveSpec dictionaries. ...................................................................... Patch Set 1: (1 inline comment) This patches fixed the case of one item dictionary which is actually broken. In addition t\his patch is a dependency. .................................................... File vdsm_cli/vdsClient.py Line 1341: Line 1342: #TODO: Remove this and the references to domainID (etc) key. Line 1343: def _splitDriveSpecItems(self, item): Line 1344: """ Line 1345: BC is BC. Backward compatibility. Line 1346: """ Line 1347: key, value = item.split(":", 1) Line 1348: if key in ("domain", "pool", "image", "volume"): Line 1349: key = "%sID" % key -- To view, visit http://gerrit.usersys/1063 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24350c099a92923323a221c909c53855a2906ece Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>

1 0

Change in vdsm[master]: Adding shared raw disk feature.
by ewarszaw＠redhat.com 27 Oct '11

27 Oct '11

Eduardo Warszawski has posted comments on this change. Change subject: Adding shared raw disk feature. ...................................................................... Patch Set 1: (5 inline comments) .................................................... Commit Message Line 10: Use Line 11: drive=GUID:<guid>, Line 12: or Line 13: drive=UUID:<uuid>, Line 14: Note the mandatory ',' The actual code takes a string containing ':' as a string. Only inputs containing ',' are processed as dicts. See parseDriveSpec() BC Line 15: Line 16: Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116 Line 17 Line 18 .................................................... File vdsm/clientIF.py Line 556: if res['status']['code']: Line 557: raise vm.VolumeError(drive) Line 558: path = res['path'] Line 559: #Another drive dict type Line 560: elif drive.has_key("GUID") and os.path.exists(os.path.join("/dev/mapper", drive["GUID"])): Yes. Line 561: path = os.path.join("/dev/mapper", drive["GUID"]) Line 562: elif drive.has_key("UUID"): Line 563: rc, out, err = storage.misc.execCmd(["blkid", "-U", drive["UUID"]], sudo=False) Line 564: if not out or rc != 0: Line 558: path = res['path'] Line 559: #Another drive dict type Line 560: elif drive.has_key("GUID") and os.path.exists(os.path.join("/dev/mapper", drive["GUID"])): Line 561: path = os.path.join("/dev/mapper", drive["GUID"]) Line 562: elif drive.has_key("UUID"): More is better. Line 563: rc, out, err = storage.misc.execCmd(["blkid", "-U", drive["UUID"]], sudo=False) Line 564: if not out or rc != 0: Line 565: self.log.info("blkid failed for UUID: %s" % drive) Line 566: raise vm.VolumeError(drive) Line 567: else: Line 568: path = out[0] Line 569: #For BC sake: a path as a string. Line 570: elif not drive: Line 571: path = drive It is possible with the actual code. BC. Line 572: elif os.path.exists(drive): Line 573: path = drive Line 574: self.log.info("prepared volume path: %s" % path) Line 575: return path Line 580: try: Line 581: result = self.irs.teardownVolume(drive['domainID'], drive['poolID'], Line 582: drive['imageID'], drive['volumeID']) Line 583: except KeyError: Line 584: self.log.info("Avoiding tear down drive %s", str(drive)) Shared disk are not really prepared therefore can't be teared down. This is only logging. Line 585: Line 586: return result['status']['code'] Line 587: Line 588: def create(self, vmParams): -- To view, visit http://gerrit.usersys/1064 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2011