October 2011 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: BZ#716573 make vdsm's `ulimit -n` configurable

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: BZ#716573 make vdsm's `ulimit -n` configurable ...................................................................... Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/948 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e8282770650a691e8d388c62e64111df40b6b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#716573 make vdsm's `ulimit -n` configurable

by Yotam Oron

Yotam Oron has posted comments on this change. Change subject: BZ#716573 make vdsm's `ulimit -n` configurable ...................................................................... Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.usersys.redhat.com/948 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e8282770650a691e8d388c62e64111df40b6b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

[MERGED PATCH] BZ#741190 never add a second "vdsm" stanza to logrotate.d/libvirtd (via gerrit-bot)

by Dan Kenigsberg

Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/971

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#741190 never add a second "vdsm" stanza to logrotate.d/li...

by Dan Kenigsberg

Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#741190 never add a second "vdsm" stanza to logrotate.d/libvirtd ...................................................................... BZ#741190 never add a second "vdsm" stanza to logrotate.d/libvirtd Change-Id: I6603ae0562481199854f6986931efdb30d43d9c8 --- M vdsm/vdsmd.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/971 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6603ae0562481199854f6986931efdb30d43d9c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#741190 never add a second "vdsm" stanza to logrotate.d/li...

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: BZ#741190 never add a second "vdsm" stanza to logrotate.d/libvirtd ...................................................................... Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.usersys.redhat.com/971 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6603ae0562481199854f6986931efdb30d43d9c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#509865 make vdsm's `ulimit -n` configurable

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: BZ#509865 make vdsm's `ulimit -n` configurable ...................................................................... Patch Set 1: (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2011-09-17 00:45:14 +0300 Line 4: Commit: Dan Kenigsberg <danken(a)redhat.com> Line 5: CommitDate: 2011-09-17 10:09:33 +0300 Line 6: Line 7: BZ#509865 make vdsm's `ulimit -n` configurable woops, thanks for catching this. bz is 716573 Line 8: Line 9: Change-Id: Ia7e8282770650a691e8d388c62e64111df40b6b2 Line 10 Line 11 .................................................... File vdsm/vdsmd.in Line 428: if [ $is_coredump == true ]; then Line 429: export DAEMON_COREFILE_LIMIT=unlimited Line 430: echo $CORE_DUMP_PATH > $CORE_PATTERN Line 431: fi Line 432: ulimit -n `$GETCONFITEM $CONF_FILE vars max_open_files 4096` by 'this" you mean "ulimit"? if it fails (ie faulty max_open_files) an error is printed and the script continues. Line 433: Line 434: test_already_running && return 0 Line 435: Line 436: if ! (test_space && test_lo && \ -- To view, visit http://gerrit.usersys.redhat.com/948 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e8282770650a691e8d388c62e64111df40b6b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#741190 never add a second "vdsm" staza to logrotate.d/lib...

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: BZ#741190 never add a second "vdsm" staza to logrotate.d/libvirtd ...................................................................... Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/971 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6603ae0562481199854f6986931efdb30d43d9c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#509865 make vdsm's `ulimit -n` configurable

by Yotam Oron

Yotam Oron has posted comments on this change. Change subject: BZ#509865 make vdsm's `ulimit -n` configurable ...................................................................... Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2011-09-17 00:45:14 +0300 Line 4: Commit: Dan Kenigsberg <danken(a)redhat.com> Line 5: CommitDate: 2011-09-17 10:09:33 +0300 Line 6: Line 7: BZ#509865 make vdsm's `ulimit -n` configurable BZ# doesn't seem related to the issue solved Line 8: Line 9: Change-Id: Ia7e8282770650a691e8d388c62e64111df40b6b2 Line 10 Line 11 .................................................... File vdsm/vdsmd.in Line 428: if [ $is_coredump == true ]; then Line 429: export DAEMON_COREFILE_LIMIT=unlimited Line 430: echo $CORE_DUMP_PATH > $CORE_PATTERN Line 431: fi Line 432: ulimit -n `$GETCONFITEM $CONF_FILE vars max_open_files 4096` What happens if this fails ? Line 433: Line 434: test_already_running && return 0 Line 435: Line 436: if ! (test_space && test_lo && \ -- To view, visit http://gerrit.usersys.redhat.com/948 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e8282770650a691e8d388c62e64111df40b6b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#741190 never add a second "vdsm" staza to logrotate.d/lib...

by Yotam Oron

Yotam Oron has posted comments on this change. Change subject: BZ#741190 never add a second "vdsm" staza to logrotate.d/libvirtd ...................................................................... Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.usersys.redhat.com/971 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6603ae0562481199854f6986931efdb30d43d9c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

Change in vdsm[master]: BZ#736114 bootstrap: override iptables if requested

by Yotam Oron

Yotam Oron has posted comments on this change. Change subject: BZ#736114 bootstrap: override iptables if requested ...................................................................... Patch Set 2: I would prefer that you didn't submit this (5 inline comments) .................................................... File vds_bootstrap/vds_bootstrap.py Line 139: pass Line 140: sys.path.append(VDSM_DIR) Line 141: Line 142: __DEFAULT_IPTABLES__ = """ Line 143: # oVirt automatically generated firewall configuration oVirt ... ? Line 144: *filter Line 145: :INPUT ACCEPT [0:0] Line 146: :FORWARD ACCEPT [0:0] Line 147: :OUTPUT ACCEPT [0:0] Line 169: """ Line 170: __SYSCONFIG_IPTABLES__ = '/etc/sysconfig/iptables' Line 171: Line 172: def _safeWrite(fname, s): Line 173: "Write s into fname atomically" Did you mean """Write s into fname atomically""" ? Line 174: Line 175: t = tempfile.NamedTemporaryFile(delete=False) Line 176: t.write(s) Line 177: t.close() Line 187: if oldstat is not None: Line 188: os.chmod(fname, oldstat.st_mode) Line 189: os.chown(fname, oldstat.st_uid, oldstat.st_gid) Line 190: Line 191: selinux.restorecon(fname) if os.ch[mod|own] fails, this will not be called, is that on purpose ? Line 192: except OSError: Line 193: logging.debug('trying to maintain file permissions', exc_info=True) Line 194: Line 195: Line 748: self._xmlOutput('SetSSHAccess', self.status, None, None, self.message) Line 749: return self.rc Line 750: Line 751: def overrideFirewall(self): Line 752: self.message = 'overriden firewall successfully' s/overriden/overridden/ Line 753: self.rc = True Line 754: self.st = 'OK' Line 755: Line 756: try: Line 753: self.rc = True Line 754: self.st = 'OK' Line 755: Line 756: try: Line 757: _safeWrite(__SYSCONFIG_IPTABLES__) _safeWrite takes 2 arguments, only 1 given. Line 758: except Exception, e: Line 759: self.message = str(e) Line 760: self.rc = False Line 761: self.st = 'FAIL' -- To view, visit http://gerrit.usersys.redhat.com/945 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a2e7d0512a2c9fc691135bf42b03fdcb3ee088a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>

12 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2011