Change in vdsm[master]: No need for the lvm info, this is what man pages are for
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: No need for the lvm info, this is what man pages are for
......................................................................
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1033
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6050913f4432d2274182b4259bb95c895be16404
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
[NEW PATCH] Related to 726960 - Restore higher version check. (via gerrit-bot)
by ewarszaw＠redhat.com
New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/927
commit 8918ae22323fe2a829169d41ca67dfc5683cd57d
Author: Eduardo Warszawski <ewarszaw(a)redhat.com>
Date: Mon Sep 12 16:17:06 2011 +0300
Related to 726960 - Restore higher version check.
Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index bec3beb..55c6b45 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -779,6 +779,8 @@ class StoragePool:
#TODO: verify in masterMigrate().
if sdUUID == new_msdUUID:
raise se.InvalidParameterException("new_msdUUID", new_msdUUID)
+ #TODO: is this check irrelevant?
+ self.validatePoolMVerHigher(masterVersion)
self.masterMigrate(sdUUID, new_msdUUID, masterVersion)
elif dom.isBackup():
dom.unmountMaster()
11 years, 7 months
Change in vdsm[master]: use correct path for fencing agent
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: use correct path for fencing agent
......................................................................
use correct path for fencing agent
There's probably a nicer way to do it with autoconf, avoiding
os.path.dirname. Comments appreciated.
Change-Id: I346c8667ba3f822546f28c4f0edbdb6443d293f5
---
M configure.ac
M vdsm/constants.py.in.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Saggi Mizrahi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1059
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I346c8667ba3f822546f28c4f0edbdb6443d293f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
Change in vdsm[master]: use correct path for fencing agent
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: use correct path for fencing agent
......................................................................
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1059
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346c8667ba3f822546f28c4f0edbdb6443d293f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
Change in vdsm[master]: Fix call to getSpmRole()
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix call to getSpmRole()
......................................................................
Fix call to getSpmRole()
Change-Id: I77aaa4aac2924c3df5f6d1c9a974dc94e7b0fcaf
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1061
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77aaa4aac2924c3df5f6d1c9a974dc94e7b0fcaf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
Change in vdsm[master]: Fix call to getSpmRole()
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Fix call to getSpmRole()
......................................................................
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.usersys.redhat.com/1061
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77aaa4aac2924c3df5f6d1c9a974dc94e7b0fcaf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
Change in vdsm[master]: Fix call to getSpmRole()
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Fix call to getSpmRole()
......................................................................
Patch Set 2: Looks good to me, approved
rebased
--
To view, visit http://gerrit.usersys.redhat.com/1061
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77aaa4aac2924c3df5f6d1c9a974dc94e7b0fcaf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
Change in vdsm[master]: Move iscsid.conf template outside of the source file
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Move iscsid.conf template outside of the source file
......................................................................
Patch Set 6: I would prefer that you didn't submit this
--
To view, visit http://gerrit.usersys.redhat.com/1034
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 7 months
Change in vdsm[master]: BZ#748466 bootstrap: report vendor properly
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#748466 bootstrap: report vendor properly
......................................................................
BZ#748466 bootstrap: report vendor properly
Do not compare a string to a function, you are bound to fail.
Change-Id: Id9be847f4a59e2bea4db87cdbfa0fd6abe48be9d
---
M vds_bootstrap/vds_bootstrap.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified
Igor Lvovsky: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1060
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9be847f4a59e2bea4db87cdbfa0fd6abe48be9d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
11 years, 7 months
