Change in vdsm[master]: BZ#746766 BZ#747337: bootstrap: download selinux module befo...
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: BZ#746766 BZ#747337: bootstrap: download selinux module before usage
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1047
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53e964ee4537831fa07576f0bda7cecfc96eae27
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
11 years, 11 months
Change in vdsm[master]: BZ#746766 restorecon whenever file access matters
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#746766 restorecon whenever file access matters
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1046
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86e24f29e784a35a4497b94dc8a3bbba673160c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
11 years, 11 months
Change in vdsm[master]: use correct path for fencing agent
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: use correct path for fencing agent
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1059
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I346c8667ba3f822546f28c4f0edbdb6443d293f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 11 months
Change in vdsm[master]: BZ#744755 Don't wait for tasks on shutdown
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#744755 Don't wait for tasks on shutdown
......................................................................
BZ#744755 Don't wait for tasks on shutdown
During shutdown we can't wait for all tasks to complete because some
of them might be stuck in D state if the storage is unreachable (eg:
createVolume preallocated on NFS).
Change-Id: I832517a7a336751ff6b3096d12d59e643bcbbe02
---
M vdsm/storage/taskManager.py
M vdsm/storage/threadPool.py
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1048
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I832517a7a336751ff6b3096d12d59e643bcbbe02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 11 months
Change in vdsm[master]: BZ#744755 Don't wait for tasks on shutdown
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#744755 Don't wait for tasks on shutdown
......................................................................
Patch Set 1: Verified; Looks good to me, approved
verified by David.
--
To view, visit http://gerrit.usersys.redhat.com/1048
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I832517a7a336751ff6b3096d12d59e643bcbbe02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 11 months
Change in vdsm[master]: Move getLvmLockingType() logic to lvm.py
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: Move getLvmLockingType() logic to lvm.py
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1032
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74df6b798664949009894346bbcb04037e978a4d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 11 months
Change in vdsm[master]: Handle EAGAIN and EINTR in ProcessPool.runExternally
by smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Handle EAGAIN and EINTR in ProcessPool.runExternally
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Dan, is right. Though a bit unrelated a patch that handles all exceptions in poll would have been better.
....................................................
File vdsm/storage/processPool.py
Line 138: end_time = time.time() + self.timeout
Line 139:
Line 140: while time.time() < end_time:
Line 141: try:
Line 142: pollres = helper.pipe.poll(self.timeout)
helper.pipe.poll(end_time - time.time())
Line 143: except (OSError, IOError) as e:
Line 144: if not e.errno in (errno.EINTR, errno.EAGAIN):
Line 145: raise
Line 146:
--
To view, visit http://gerrit.usersys.redhat.com/1051
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1d0f35af9db6e237c87b00438b9ce3ded9faa8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 11 months