Change in vdsm[master]: BZ#748222 netinfo: report operstate, not adminstate
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#748222 netinfo: report operstate, not adminstate
......................................................................
BZ#748222 netinfo: report operstate, not adminstate
Until commit 4153e08acb8ae23ef79 (fixing BZ#726359), when reporting if a
network inteface is up or down, Vdsm was considering the operative status.
That was the correct behavior, since users do not really care that they have
configered the nic to be up while the line is cut off by evil mice (or quality
engineers).
Change-Id: I32b74a57d96ba0feea4816749c6c45ea34695d2a
---
M vdsm/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1057
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32b74a57d96ba0feea4816749c6c45ea34695d2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#748222 netinfo: report operstate, not adminstate
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#748222 netinfo: report operstate, not adminstate
......................................................................
Patch Set 1: Verified; Looks good to me, approved
verified by Kiril
--
To view, visit http://gerrit.usersys.redhat.com/1057
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32b74a57d96ba0feea4816749c6c45ea34695d2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: vds_bootstrap: fix usage string
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: vds_bootstrap: fix usage string
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/982
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8950764778dc61d04caeed4c74e792d52bba3378
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#744755 Don't wait for tasks on shutdown [EXTRA]
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: BZ#744755 Don't wait for tasks on shutdown [EXTRA]
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1315: def startRepoStats(self, sdUUID):
Line 1316: statthread = self.repostats.get(sdUUID)
Line 1317: if not statthread:
Line 1318: statthread = StatsThread(self._repostats, sdUUID)
Line 1319: statthread.daemon = True
Did you set it in _init_ ? Why again?
Line 1320: statthread.start()
Line 1321: self.repostats[sdUUID] = statthread
Line 1322: self.log.debug("%s stat %s", sdUUID, statthread)
Line 1323:
--
To view, visit http://gerrit.usersys.redhat.com/1049
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53cf150f3812cf13b2afbf47dab9fb9bd560fa33
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#744755 daemonize HSM_MailMonitor thread
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: BZ#744755 daemonize HSM_MailMonitor thread
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/sp.py
Line 90: func - function to call
Line 91: dom - argument to pass to func()
Line 92: """
Line 93: threading.Thread.__init__(self)
Line 94: self.setDaemon(True)
This is not related to this patch.
Looks like same to Federico's patch:
http://gerrit.usersys.redhat.com/#change,1049
Line 95: self._statscache = dict(result=
Line 96: dict(code=200, lastCheck=0.0, delay='0', valid=True))
Line 97: self._statsdelay = config.getint('irs', 'sd_health_check_delay')
Line 98: self._statsletrun = True
....................................................
File vdsm/storage/storage_mailbox.py
Line 242: self._initMailbox() # Read initial mailbox state
Line 243: self._msgCounter = 0
Line 244: self._sendMail() # Clear outgoing mailbox
Line 245: threading.Thread.__init__(self)
Line 246: self.setDaemon(True)
What about SPM_mailbox?
Line 247: self.start()
Line 248:
Line 249: def _initMailbox(self):
Line 250: # Sync initial incoming mail state with storage view
--
To view, visit http://gerrit.usersys.redhat.com/1036
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27d7e7e1d1e99f6119fd4cc6ab1a10654236c57d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#744755 Don't wait for tasks on shutdown
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: BZ#744755 Don't wait for tasks on shutdown
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1048
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I832517a7a336751ff6b3096d12d59e643bcbbe02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: No need for the lvm info, this is what man pages are for
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: No need for the lvm info, this is what man pages are for
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1033
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6050913f4432d2274182b4259bb95c895be16404
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#744755 Don't wait for tasks on shutdown
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#744755 Don't wait for tasks on shutdown
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1048
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I832517a7a336751ff6b3096d12d59e643bcbbe02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months