[NEW PATCH] BZ#719857 - Rhevh give user a warning before press the "reject" (via gerrit-bot)
by Yotam Oron
New patch submitted by Yotam Oron (yoron(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/895
commit d1fd07952b13dbfc6901b821a4c9fb8b076dfac4
Author: Yotam Oron <yoron(a)redhat.com>
Date: Mon Sep 5 16:05:16 2011 +0300
BZ#719857 - Rhevh give user a warning before press the "reject"
Instead of rebooting the host, fail the configuration and notify the user
Change-Id: Id4d4b22f306c3ca67d8451def8654ffaaab1a8f7
diff --git a/vdsm_reg/rhevm.py b/vdsm_reg/rhevm.py
index 9335b61..d9cc627 100755
--- a/vdsm_reg/rhevm.py
+++ b/vdsm_reg/rhevm.py
@@ -152,13 +152,11 @@ class Plugin(PluginBase):
path, dontCare = deployUtil.certPaths('')
fp = deployUtil.generateFingerPrint(path)
approval = ButtonChoiceWindow(self.ncs.screen,
- "Certificate Fingerprint (Rejecting the finrgerprint will reboot the host):",
+ "Certificate Fingerprint:",
fp, buttons = ['Approve', 'Reject'])
if 'reject' == approval:
- out, err, rc = deployUtil._logExec(['/sbin/reboot'])
- if rc is not 0:
- log("Failed rebooting after fingerprint" + \
- "mismatch: %s", err)
+ ButtonChoiceWindow(self.ncs.screen, "Fingerprint rejected", "RHEV-M Configuration Failed", buttons = ['Ok'])
+ return False
else:
ovirt_store_config(path)
self.ncs.reset_screen_colors()
12 years, 7 months
[NEW PATCH] BZ#725241 Don't rotate a log file before it reaches a certain size (via gerrit-bot)
by Yotam Oron
New patch submitted by Yotam Oron (yoron(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/743
commit 268c190df397881b59cad1170224c50e4333eddd
Author: Yotam Oron <yoron(a)redhat.com>
Date: Mon Jul 25 15:36:26 2011 +0300
BZ#725241 Don't rotate a log file before it reaches a certain size
No need to rotate log files if they are too small, so set the minimum rotation size.
Change-Id: I57a6f611146e4fc5b00109b52c071478e350db78
diff --git a/vdsm/vdsm-logrotate.conf b/vdsm/vdsm-logrotate.conf
index 12e16ad..4f02521 100644
--- a/vdsm/vdsm-logrotate.conf
+++ b/vdsm/vdsm-logrotate.conf
@@ -3,6 +3,7 @@
missingok
copytruncate
size 15M
+ minsize 15M
compress
compresscmd /usr/bin/xz
uncompresscmd /usr/bin/unxz
12 years, 7 months
[NEW PATCH] BZ#734768 - Handle 'guest' element being missing in libvrit caps (via gerrit-bot)
by smizrahi@redhat.com
New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/886
commit 0589ac6f1edda30ecfcf026aca15e3551dbd87fa
Author: Saggi Mizrahi <smizrahi(a)redhat.com>
Date: Wed Aug 31 18:13:23 2011 +0300
BZ#734768 - Handle 'guest' element being missing in libvrit caps
Change-Id: Ia25d6e4abbf33da991bcb09fcb55b5bdbca512ec
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 0a75510..37ffd3e 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -80,9 +80,14 @@ class CpuInfo(object):
def _getEmulatedMachines():
c = libvirtconnection.get()
caps = minidom.parseString(c.getCapabilities())
- return [ m.firstChild.toxml() for m
- in caps.getElementsByTagName('guest')[0]
- .getElementsByTagName('machine') ]
+ guestTag = caps.getElementsByTagName('guest')
+ # Guest element is missing if kvm modules are not loaded
+ if len(guestTag) == 0:
+ return []
+
+ guestTag = guestTag[0]
+
+ return [ m.firstChild.toxml() for m in guestTag.getElementsByTagName('machine') ]
@utils.memoized
def _getCompatibleCpuModels():
12 years, 7 months
[NEW PATCH] Related to BZ#705058 - Stop all repoStats threads that were started during reconstructMaster (via gerrit-bot)
by Igor Lvovsky
New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/894
commit 8dd633ccdc1f81c0adf5d2185b7dfad17b4ff75c
Author: Igor Lvovsky <ilvovsky(a)redhat.com>
Date: Thu Sep 1 11:20:26 2011 +0300
Related to BZ#705058 - Stop all repoStats threads that were started during reconstructMaster
Change-Id: I8e1539ca7ebe75b1d47ef27ace8325265372fae6
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 440a86a..014da1e 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -482,6 +482,8 @@ class StoragePool:
self.setMetaParam(PMDK_DOMAINS, domains)
self.log.info("Set storage pool domains: %s", domains)
finally:
+ # We need stop all repoStats threads that were started during reconstructMaster
+ self.disconnectDomains()
futureMaster.releaseClusterLock()
finally:
self.id = None
12 years, 7 months
[NEW PATCH] Related to BZ#732416 - Remove volume.Volume.delete() (via gerrit-bot)
by ewarszaw@redhat.com
New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/872
commit 641e9b5db0a053700b932942bab1e85bc97a9435
Author: Eduardo Warszawski <ewarszaw(a)redhat.com>
Date: Wed Aug 24 18:29:02 2011 +0300
Related to BZ#732416 - Remove volume.Volume.delete()
Change-Id: Ide568c0e60bfd5bea399f946306891380f89d970
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index 272c997..a27b913 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -382,12 +382,6 @@ class Volume:
# So, there is no reasons to avoid its deletion
self.log.warn("Volume %s metadata error (%s)", self.volUUID, str(e))
- def delete(self, postZero, force):
- """
- Delete a volume
- """
- pass
-
def extend(self, newsize):
"""
Extend a logical volume
12 years, 7 months
[NEW PATCH] Related to BZ#726400 - ISO domain on block is not supported. (via gerrit-bot)
by ewarszaw@redhat.com
New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/831
commit 0512921f276b788656b48987cf8a7480cefcb158
Author: Eduardo Warszawski <ewarszaw(a)redhat.com>
Date: Wed Aug 17 18:23:45 2011 +0300
Related to BZ#726400 - ISO domain on block is not supported.
Change-Id: I02639f9da4a978f018ee719025483e90447a140b
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 78ec42b..36645c1 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -909,11 +909,6 @@ class BlockStorageDomain(sd.StorageDomain):
src = lvm.lvPath(self.sdUUID, lvName)
os.symlink(src, dst)
- # create special imageUUID for ISO/Floppy volumes
- isoPath = os.path.join(imagesPath, sd.ISO_IMAGE_UUID)
- if self.isISO():
- fileUtils.createdir(isoPath)
-
def extendVolume(self, volumeUUID, size, isShuttingDown=None):
self._extendlock.acquire()
try:
12 years, 7 months