Change in vdsm[master]: BZ#736114 bootstrap: override iptables if requested
by Yotam Oron
Yotam Oron has posted comments on this change.
Change subject: BZ#736114 bootstrap: override iptables if requested
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 159: -A INPUT -p tcp --dport 22 -j ACCEPT
Line 160: # guest consoles
Line 161: -A INPUT -p tcp -m multiport --dports 5634:6166 -j ACCEPT
Line 162: # migration
Line 163: -A INPUT -p tcp -m multiport --dports 49152:49216 -j ACCEPT
Please define constants and use them here (no bare numbers in the strings)
Line 164: # snmp
Line 165: -A INPUT -p udp --dport 161 -j ACCEPT
Line 166: #
Line 167: -A INPUT -j REJECT --reject-with icmp-host-prohibited
Line 724: def overrideFirewall(self):
Line 725: self.message = 'overriden firewall successfully'
Line 726: self.rc = True
Line 727: self.st = 'OK'
Line 728: f = file('/etc/sysconfig/iptables', 'w')
Please use a constant for this file name
Line 729: try:
Line 730: f.write(__DEFAULT_IPTABLES__)
Line 731: finally:
Line 732: f.close()
Line 726: self.rc = True
Line 727: self.st = 'OK'
Line 728: f = file('/etc/sysconfig/iptables', 'w')
Line 729: try:
Line 730: f.write(__DEFAULT_IPTABLES__)
Can this fail for some reason ?
What happens if only partial file is written ?
Line 731: finally:
Line 732: f.close()
Line 733:
Line 734: self._xmlOutput('Firewall', self.st, None, None, self.message)
Line 871: def main():
Line 872: """
Line 873: Usage: vds_compat.py [-r rev_num] [-O organizationName] [-t systemTime]
Line 874: [-n netconsole_host:port] [-u (seProductRepo) true|false ]
Line 875: [-f (firewall) ] <url> <subject> <random_num>
I never saw round brackets in usage message before (Yes, I know someone else used it before in this message, but this is confusing, the user might think she actually needs to add something after the '-f')
Line 876: """
Line 877: try:
Line 878: rev_num = None
Line 879: orgName = 'Red Hat Inc.'
Line 894: if o == "-u":
Line 895: usevdcrepo = (v.upper() == 'TRUE')
Line 896: elif o == '-f':
Line 897: overrideFirewall = True
Line 898: NEEDED_SERVICES.append('iptables')
You actually have 2 actions here: starting the firewall and setting the default configuration for it. Better reflect it in the configuration flags (maybe -f just for starting the firewall and -F for also setting the defaults)
Line 899:
Line 900: url = args[0]
Line 901: subject = args[1]
Line 902: random_num = args[2]
--
To view, visit http://gerrit.usersys.redhat.com/945
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a2e7d0512a2c9fc691135bf42b03fdcb3ee088a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#740158 netinfo: never report negative speed
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#740158 netinfo: never report negative speed
......................................................................
BZ#740158 netinfo: never report negative speed
Even if, for some reason,
/sys/class/net/eth0/speed
had a negative value, we should not report it as such. It justly
confuses users.
Change-Id: If3469b06eb0a6848178e24f7318f7e3c5219d9c7
---
M vdsm/netinfo.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified
Federico Simoncelli: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/962
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3469b06eb0a6848178e24f7318f7e3c5219d9c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Don't use a list to calculate VG size
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Don't use a list to calculate VG size
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 840:
Line 841: vars.task.setDefaultException(se.VolumeGroupCreateError(str(vgname), str(devlist)))
Line 842: misc.validateUUID(vgname, 'vgname')
Line 843: #getSharedLock(connectionsResource...)
Line 844: knowndevs = list(multipath.getMPDevNamesIter())
I think it's more urgent to make a set() out of this list()...
Line 845: size = 0
Line 846: devices = []
Line 847:
Line 848: for dev in devlist:
--
To view, visit http://gerrit.usersys.redhat.com/967
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief2a3e69f94c99b11c9027901fc5a34577c3452f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Don't use a list to calculate VG size
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: Don't use a list to calculate VG size
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/967
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief2a3e69f94c99b11c9027901fc5a34577c3452f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: BZ#735725 - Streamline configuration settin
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#735725 - Streamline configuration settin
......................................................................
Patch Set 2: I would prefer that you didn't submit this
I suppose you've missed my main comment - I think that the approach is wrong for our product stage.
I'd have an quick hack for adding lines now, but solve it properly, using augeas, for upstream.
--
To view, visit http://gerrit.usersys.redhat.com/960
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37083a3acef3d3720d2a55a18c8a73550becf6ff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#735725 - Streamline configuration settin
by Yotam Oron
Yotam Oron has posted comments on this change.
Change subject: BZ#735725 - Streamline configuration settin
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.usersys.redhat.com/960
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37083a3acef3d3720d2a55a18c8a73550becf6ff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#735725 - Streamline configuration settin
by Yotam Oron
Yotam Oron has posted comments on this change.
Change subject: BZ#735725 - Streamline configuration settin
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 656: return False
Line 657: else:
Line 658: config.set(section, option, value)
Line 659:
Line 660: safeConfigWrite(config, fileName, fileStat)
Done
Line 661:
Line 662: #############################################################################################################
Line 663: # Host bridge functions.
Line 664: #############################################################################################################
--
To view, visit http://gerrit.usersys.redhat.com/960
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37083a3acef3d3720d2a55a18c8a73550becf6ff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 7 months
Fwd: [PATCH] deployUtils.py.in: fix typo
by smizrahi＠redhat.com
Patches should go to vdsm-patches not vdsm-devel
-------- Original Message --------
Subject: [PATCH] deployUtils.py.in: fix typo
Date: Tue, 20 Sep 2011 10:57:33 -0400
From: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reply-To: VDSM Project Development <vdsm-devel(a)lists.fedorahosted.org>
To: vdsm-devel(a)lists.fedorahosted.org
- Replace Faild to Failed
Signed-off-by: Douglas Schilling Landgraf<dougsland(a)redhat.com>
---
vdsm_reg/deployUtil.py.in | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in
index b2e04dc..e8163b9 100644
--- a/vdsm_reg/deployUtil.py.in
+++ b/vdsm_reg/deployUtil.py.in
@@ -314,7 +314,7 @@ def getMGTIP(vdsmDir, vdcHostName):
sys.path.append(vdsmDir)
import netinfo # taken from vdsm rpm
except:
- logging.error("getMGTIP: Faild to find vdsm modules!")
+ logging.error("getMGTIP: Failed to find vdsm modules!")
return strReturn
arNICs = None
@@ -762,7 +762,7 @@ def makeBridge(vdcName, vdsmDir):
try:
imp.find_module('netinfo') # taken from vdsm rpm
except ImportError:
- logging.error("makeBridge Faild to find vdsm modules!")
+ logging.error("makeBridge Failed to find vdsm modules!")
return False
fReturn = True
--
1.7.1
_______________________________________________
vdsm-devel mailing list
vdsm-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
12 years, 7 months
