Change in vdsm[master]: Move domain monitor out of sp.py
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
I don't like the paradigm, as it requires changing a property name in two places. but ok.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
12 years, 3 months
Change in vdsm[master]: Move domain monitor out of sp.py
by smizrahi＠redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
Because it will be used mostly for consumption outside the module I think it's a convenient way to know what fields return from domainMonitorStatus. Just trying this coding paradigm out seeing if I like it. It can't hurt and you can remove it at any time.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
12 years, 3 months
Change in vdsm[master]: Move domain monitor out of sp.py
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
I wouldn't have bothered with __slots__ - we do not plan for 1000s SDs for the size to matter.
Or is there a hidden cause for this?
....................................................
File vdsm/storage/hsm.py
Line 2580: # Stop repoStat threads
are you sure this code works?
I'd expect self.pools.values() here.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
12 years, 3 months
Change in vdsm[master]: Fix logging formatting in resourceManager
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix logging formatting in resourceManager
......................................................................
Fix logging formatting in resourceManager
Change-Id: I08b530e8fbf66b9b8326cf1733df6a3e4f23ef1a
---
M vdsm/storage/resourceManager.py
1 file changed, 31 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/531/1
--
To view, visit http://gerrit.ovirt.org/531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08b530e8fbf66b9b8326cf1733df6a3e4f23ef1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: BZ#674010 - Fix name error in vdsClient - 'commands' not fou...
by Haim Ateya
Haim Ateya has uploaded a new change for review.
Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................
BZ#674010 - Fix name error in vdsClient - 'commands' not found
Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
---
M vdsm_cli/vdsClient.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/906/1
--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Add LibvirtDrive
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Add LibvirtDrive
......................................................................
Add LibvirtDrive
Change-Id: I37b40c6260612d60942037363deb9a24e46dad46
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 83 insertions(+), 64 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/789/1
--
To view, visit http://gerrit.ovirt.org/789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37b40c6260612d60942037363deb9a24e46dad46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Normalize network parameter for VM create flow
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Normalize network parameter for VM create flow
......................................................................
Normalize network parameter for VM create flow
Add new LibvirtNetwork class to normalize network parameters
and create proper libvirt XML
Change-Id: I2d064dcdb639a5d98762a153d21de93f43c43254
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 131 insertions(+), 87 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/790/1
--
To view, visit http://gerrit.ovirt.org/790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d064dcdb639a5d98762a153d21de93f43c43254
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Move VmStatsThread to use normalized network parameter
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Move VmStatsThread to use normalized network parameter
......................................................................
Move VmStatsThread to use normalized network parameter
Change-Id: I836539fcf7a21e07a818543228a25f9085c11c75
---
M vdsm/libvirtvm.py
1 file changed, 17 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/791/1
--
To view, visit http://gerrit.ovirt.org/791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I836539fcf7a21e07a818543228a25f9085c11c75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Add general Device class
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Add general Device class
......................................................................
Add general Device class
Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 23 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/792/1
--
To view, visit http://gerrit.ovirt.org/792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 3 months
Change in vdsm[master]: Normalize sound parameter for VM create flow
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Normalize sound parameter for VM create flow
......................................................................
Normalize sound parameter for VM create flow
Change-Id: I6b03430e183e17c113148da56c950ab80b3aed16
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 35 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/793/1
--
To view, visit http://gerrit.ovirt.org/793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b03430e183e17c113148da56c950ab80b3aed16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 3 months
