Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def
......................................................................
netwiring: [1/4] Extend vmInterfaceDevice API def
This patch extends the definitions of vmInterfaceDevice in
order to allow vmHotplugNic and vmCreate to set a vnic link
status as well as set portMirroring for it.
Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/9599/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 843cbc7..2c02804 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1980,6 +1980,11 @@
#
# @specParams: #optional Additional device parameters
#
+# @linkActive: #optional Whether the VM network card has its link active (up)
+# or not (down). If omitted, the link will be active
+# @portMirroring: #optional If present, indicates the traffic of which networks
+# should be mirrored to the interface.
+#
# Since: 4.10.0
##
{'type': 'VmInterfaceDevice',
@@ -1987,7 +1992,8 @@
'nicModel': 'VmInterfaceDeviceModel', 'macAddr': 'str',
'network': 'str', '*bootOrder': 'uint',
'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
- '*specParams': 'VmInterfaceDeviceSpecParams'}}
+ '*specParams': 'VmInterfaceDeviceSpecParams', '*linkActive': 'bool',
+ '*portMirroring': ['str']}}
##
# @VmVideoDeviceType:
--
To view, visit http://gerrit.ovirt.org/9599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout
......................................................................
Sometimes the test host is overloaded and that might cause a false positive with such a low timeout
Change-Id: Ibf80dfc8432b30967cd223460747095dc829878a
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M tests/remoteFileHandlerTests.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/9751/1
diff --git a/tests/remoteFileHandlerTests.py b/tests/remoteFileHandlerTests.py
index 9508536..b114abf 100644
--- a/tests/remoteFileHandlerTests.py
+++ b/tests/remoteFileHandlerTests.py
@@ -38,7 +38,7 @@
And wash it down with a cup of hot steaming rules. Eh?."""
# (C) BBC - The Mighty Boosh
- self.assertEquals(self.pool.callCrabRPCFunction(1, "echo", data), data)
+ self.assertEquals(self.pool.callCrabRPCFunction(5, "echo", data), data)
def testTimeout(self):
sleep = 5
--
To view, visit http://gerrit.ovirt.org/9751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf80dfc8432b30967cd223460747095dc829878a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: dd: use iflag=direct only when supported by the os
......................................................................
dd: use iflag=direct only when supported by the os
Much like as vdsm's use of fileUtils.DirectFile that was fixed in
http://gerrit.ovirt.org/9595, we should not pass the "direct" flag to
/bin/dd when the underlying filesystem does not support it.
Change-Id: I76f3ac6a9c220e34f78d0d922145bca56ee8e10e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/fileUtils.py
M vdsm/storage/misc.py
2 files changed, 24 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/9661/1
diff --git a/vdsm/storage/fileUtils.py b/vdsm/storage/fileUtils.py
index e00a004..2bc2cac 100644
--- a/vdsm/storage/fileUtils.py
+++ b/vdsm/storage/fileUtils.py
@@ -238,6 +238,13 @@
return open(path, mode)
+def pathSupportsDirectFile(path):
+ # Memory-only file systems don't support direct IO because direct IO
+ # means "skip the page cache" and they are 100% page cahce.
+ vfstype = mount.findMountOfPath(path).getRecord().fs_vfstype
+ return vfstype not in ["tmpfs", "ramfs"]
+
+
class DirectFile(object):
def __init__(self, path, mode):
if not "d" in mode:
@@ -247,13 +254,10 @@
raise ValueError("Invalid mode parameter")
self._writable = True
- # Memory only file systems don't support direct IO because direct IO
- # means "skip the page cache" and they are 100% page cahce.
- vfstype = mount.findMountOfPath(path).getRecord().fs_vfstype
- if vfstype in ["tmpfs", "ramfs"]:
- flags = 0
- else:
+ if pathSupportsDirectFile(path):
flags = os.O_DIRECT
+ else:
+ flags = 0
if "r" in mode:
if "+" in mode:
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 6360dcf..d85fb66 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -58,6 +58,7 @@
from vdsm import constants
import storage_exception as se
from vdsm.betterPopen import BetterPopen
+import fileUtils
import logUtils
@@ -272,7 +273,12 @@
"""
Read the content of the file using /bin/dd command
"""
- cmd = [constants.EXT_DD, "iflag=%s" % DIRECTFLAG, "if=%s" % name]
+ cmd = [constants.EXT_DD]
+
+ if fileUtils.pathSupportsDirectFile(name):
+ cmd.append("iflag=%s" % DIRECTFLAG)
+ cmd.append("if=%s" % name)
+
if buffersize:
cmd.extend(["bs=%d" % buffersize, "count=1"])
(rc, out, err) = execCmd(cmd, sudo=False)
@@ -297,8 +303,11 @@
while left > 0:
(iounit, count, iooffset) = _alignData(left, offset)
- cmd = [constants.EXT_DD, "iflag=%s" % DIRECTFLAG, "skip=%d" % iooffset,
- "bs=%d" % iounit, "if=%s" % name, 'count=%s' % count]
+ cmd = [constants.EXT_DD]
+ if fileUtils.pathSupportsDirectFile(name):
+ cmd.append("iflag=%s" % DIRECTFLAG)
+ cmd.extend(["skip=%d" % iooffset, "bs=%d" % iounit, "if=%s" % name,
+ "count=%s" % count])
(rc, out, err) = execCmd(cmd, raw=True)
if rc:
@@ -381,7 +390,8 @@
oflag = None
conv = "notrunc"
if (iounit % 512) == 0:
- oflag = DIRECTFLAG
+ if fileUtils.pathSupportsDirectFile(dst):
+ oflag = DIRECTFLAG
else:
conv += ",%s" % DATASYNCFLAG
--
To view, visit http://gerrit.ovirt.org/9661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76f3ac6a9c220e34f78d0d922145bca56ee8e10e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Specify the ACPI flag when shutting down VMs
......................................................................
Specify the ACPI flag when shutting down VMs
In commit e460308 has been introduced the qemu guest agent support.
When such agent channel is present the default shutdown method uses the
guest agent (which might be missing).
For consistency and to maintain the old behavior we should specify to
use ACPI to shutdown the guest.
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/6996/1
--
To view, visit http://gerrit.ovirt.org/6996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>