vdsm-patches December 2012

vdsm-patches@lists.fedorahosted.org

51 participants
408 discussions

Change in vdsm[master]: Add getOSName() method in deployUtil for OS detection
by Pradipta Kumar Banerjee 23 Dec '12

23 Dec '12

Pradipta Banerjee has uploaded a new change for review. Change subject: Add getOSName() method in deployUtil for OS detection ...................................................................... Add getOSName() method in deployUtil for OS detection This patch improves the current detection of whether the running host is RHEL6 based or Fedora by adding a new method getOSName() Change-Id: Ifff9b08902cd234dfa03292136317d50e5e3d22b Signed-off-by: Pradipta Kr. Banerjee <bpradip(a)in.ibm.com> --- M vds_bootstrap/vds_bootstrap.py M vdsm_reg/deployUtil.py.in 2 files changed, 24 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/8002/1 diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py index 537953d..c6ae08e 100755 --- a/vds_bootstrap/vds_bootstrap.py +++ b/vds_bootstrap/vds_bootstrap.py @@ -66,11 +66,18 @@ (LOGDIR, "phase1", strftime("%Y%m%d%H%M%S")), filemode='w') -rhel6based = deployUtil.versionCompare(deployUtil.getOSVersion(), "6.0") >= 0 +#Detect RHEL6 or Fedora16 as min supported version +rhel6based = False +fedorabased = False +if (deployUtil.getOSName().lower() == "redhat" and + deployUtil.versionCompare(deployUtil.getOSVersion(), "6.0")) >= 0: + rhel6based = True -# TODO this is an infra-hackish heuristic for identifying Fedora -# drop as soon as possible -fedorabased = deployUtil.versionCompare(deployUtil.getOSVersion(), "16") >= 0 +if (deployUtil.getOSName().lower() == "fedora" and + deployUtil.versionCompare(deployUtil.getOSVersion(), "16")) >= 0: + fedorabased = True + +logging.debug("fedorabased=%d rhel6based=%d", fedorabased, rhel6based) if rhel6based: VDSM_NAME = "vdsm" diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in index bbda70e..e410e32 100644 --- a/vdsm_reg/deployUtil.py.in +++ b/vdsm_reg/deployUtil.py.in @@ -451,6 +451,19 @@ logging.debug("OS Release Ver = %s", osVer[1]) return osVer[1] +def getOSName(): + """ + Return the OS Name, Fedora, Redhat etc + + Return "Unknown OS" on any failure. + """ + + # platform.linux_distribution returns a tuple (distname, version, id) or + # default as given in args in case of any failure + osName = platform.linux_distribution(distname='Unknown OS', version='') + logging.debug("OS Name = %s", osName[0]) + return osName[0] + def getKernelVR(): """Return current kernel version and release.""" -- To view, visit http://gerrit.ovirt.org/8002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifff9b08902cd234dfa03292136317d50e5e3d22b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com>

2 3

Change in vdsm[master]: restarting libvirtd didn't work over allinone setup
by ybronhei＠redhat.com 23 Dec '12

23 Dec '12

Hello Ohad Basan, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/10312 to review the following change. Change subject: restarting libvirtd didn't work over allinone setup ...................................................................... restarting libvirtd didn't work over allinone setup Change-Id: I13cbe3cd91cb9eb7f22135f6a0ae6f0391b46ae4 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=888258 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/10237 Tested-by: Ohad Basan <obasan(a)redhat.com> Reviewed-by: Ohad Basan <obasan(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/vdsmd.init.in 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/10312/1 diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index 7a7ae84..c8223d3 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -362,7 +362,11 @@ ovirt_store_config "$lconf" "$qconf" "$ldconf" "$llogr" - /sbin/initctl restart libvirtd 2>/dev/null || : + if libvirt_should_use_upstart; then + /sbin/initctl restart libvirtd 2>/dev/null || : + else + /bin/systemctl restart libvirtd.service + fi # # finished reconfiguration, do not trigger -- To view, visit http://gerrit.ovirt.org/10312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I13cbe3cd91cb9eb7f22135f6a0ae6f0391b46ae4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

2 4

Change in vdsm[ovirt-3.2]: restarting libvirtd didn't work over allinone setup
by ybronhei＠redhat.com 23 Dec '12

23 Dec '12

Hello Ohad Basan, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/10314 to review the following change. Change subject: restarting libvirtd didn't work over allinone setup ...................................................................... restarting libvirtd didn't work over allinone setup Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=888258 Change-Id: I1ab443fbef35f1ffaab59973f278eebe0143dd87 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/10237 Tested-by: Ohad Basan <obasan(a)redhat.com> Reviewed-by: Ohad Basan <obasan(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/vdsmd.init.in 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/10314/1 diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index 7a7ae84..c8223d3 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -362,7 +362,11 @@ ovirt_store_config "$lconf" "$qconf" "$ldconf" "$llogr" - /sbin/initctl restart libvirtd 2>/dev/null || : + if libvirt_should_use_upstart; then + /sbin/initctl restart libvirtd 2>/dev/null || : + else + /bin/systemctl restart libvirtd.service + fi # # finished reconfiguration, do not trigger -- To view, visit http://gerrit.ovirt.org/10314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ab443fbef35f1ffaab59973f278eebe0143dd87 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 1

Change in vdsm[master]: test_getIfaceByIP changes for IBM POWER(ppc64) architecture
by Pradipta Kumar Banerjee 23 Dec '12

23 Dec '12

Pradipta Banerjee has uploaded a new change for review. Change subject: test_getIfaceByIP changes for IBM POWER(ppc64) architecture ...................................................................... test_getIfaceByIP changes for IBM POWER(ppc64) architecture /proc/net/route o/p is dependent on endianness and existing test case only handles x86 arch. This patchset adds support for ppc64 architecture Change-Id: I40178f44b5ab2602769aa4c70a5e54564f9f360e Signed-off-by: Pradipta Kr. Banerjee <bpradip(a)in.ibm.com> --- M tests/Makefile.am M tests/capsTests.py A tests/route_info_ppc64.out M vdsm.spec.in 4 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/10181/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 8ad34e2..afa37a6 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -68,6 +68,7 @@ lvs_3386c6f2-926f-42c4-839c-38287fac8998.out \ netmaskconversions \ route_info.out \ + route_info_ppc64.out \ tc_filter_show.out \ $(NULL) diff --git a/tests/capsTests.py b/tests/capsTests.py index f0d6b54..195661d 100644 --- a/tests/capsTests.py +++ b/tests/capsTests.py @@ -23,6 +23,7 @@ from testrunner import VdsmTestCase as TestCaseBase import caps +import platform class TestCaps(TestCaseBase): @@ -82,5 +83,10 @@ def test_getIfaceByIP(self): expectedRes = ["wlan0", "virbr0"] ip = ["10.201.129.37", "192.168.122.90"] + arch = platform.machine() + if arch == 'x86_64': + route_file = 'route_info.out' + elif arch == 'ppc64': + route_file = 'route_info_ppc64.out' for res, i in zip(expectedRes, ip): - self.assertEqual(res, caps._getIfaceByIP(i, "route_info.out")) + self.assertEqual(res, caps._getIfaceByIP(i, route_file)) diff --git a/tests/route_info_ppc64.out b/tests/route_info_ppc64.out new file mode 100644 index 0000000..59fedb8 --- /dev/null +++ b/tests/route_info_ppc64.out @@ -0,0 +1,4 @@ +Iface Destination Gateway Flags RefCnt Use Metric Mask MTU Window IRTT +wlan0 0AC98100 00000000 0001 0 0 0 FFFFFF00 0 0 0 +virbr0 C0A87A00 00000000 0001 0 0 0 FFFFFF00 0 0 0 +eth0 0A230000 00000000 0001 0 0 0 FFFFFE00 0 0 0 diff --git a/vdsm.spec.in b/vdsm.spec.in index 68126fd..a6ce969 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -805,6 +805,7 @@ %{_datadir}/%{vdsm_name}/tests/netmaskconversions %{_datadir}/%{vdsm_name}/tests/run_tests.sh %{_datadir}/%{vdsm_name}/tests/route_info.out +%{_datadir}/%{vdsm_name}/tests/route_info_ppc64.out %{_datadir}/%{vdsm_name}/tests/tc_filter_show.out %{_datadir}/%{vdsm_name}/tests/glusterVolumeProfileInfo.xml %{_datadir}/%{vdsm_name}/tests/glusterVolumeProfileInfoNfs.xml -- To view, visit http://gerrit.ovirt.org/10181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40178f44b5ab2602769aa4c70a5e54564f9f360e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com>

3 16

Change in vdsm[ovirt-3.2]: api: Report CPU thread info in getVdsCapabilities
by dfediuck＠redhat.com 21 Dec '12

21 Dec '12

Hello Greg Padgett, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/10300 to review the following change. Change subject: api: Report CPU thread info in getVdsCapabilities ...................................................................... api: Report CPU thread info in getVdsCapabilities Report CPU thread info in getVdsCapabilities Change-Id: I11f1e139a3f3d5bd18032713694bdebf9ab8c1d7 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M vdsm/caps.py M vdsm_api/vdsmapi-schema.json 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/10300/1 diff --git a/vdsm/caps.py b/vdsm/caps.py index 0438fb4..6749227 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -261,6 +261,7 @@ else: caps['cpuCores'] = str(cpuTopology.cores()) + caps['cpuThreads'] = str(cpuTopology.threads()) caps['cpuSockets'] = str(cpuTopology.sockets()) caps['cpuSpeed'] = cpuInfo.mhz() if config.getboolean('vars', 'fake_kvm_support'): diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 58dd6e2..c72ec4b 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -848,6 +848,8 @@ # # @kvmEnabled: KVM is enabled on the host # +# @cpuThreads: The number of CPU threads present +# # @cpuCores: The number of CPU cores present # # @cpuSockets: The numbet of CPU sockets @@ -909,7 +911,7 @@ # the current API truncates @software_version to 'x.y'. ## {'type': 'VdsmCapabilities', - 'data': {'kvmEnabled': 'bool', 'cpuCores': 'uint', + 'data': {'kvmEnabled': 'bool', 'cpuThreads': 'uint', 'cpuCores': 'uint', 'cpuSockets': 'uint', 'cpuSpeed': 'float', 'cpuModel': 'str', 'cpuFlags': 'str', 'version_name': 'str', 'software_version': 'str', 'software_revision': 'str', 'supportedENGINEs': ['str'], -- To view, visit http://gerrit.ovirt.org/10300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11f1e139a3f3d5bd18032713694bdebf9ab8c1d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

3 4

Change in vdsm[master]: Fix typo in negative flow log in blockSD.rmDCImgDir().
by ewarszaw＠redhat.com 20 Dec '12

20 Dec '12

Eduardo has uploaded a new change for review. Change subject: Fix typo in negative flow log in blockSD.rmDCImgDir(). ...................................................................... Fix typo in negative flow log in blockSD.rmDCImgDir(). Related to BZ#885489. Change-Id: I951e582acc86e08d709da4249084015660fc4ea0 Signed-off-by: Eduardo <ewarszaw(a)redhat.com> --- M vdsm/storage/blockSD.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/10153/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 61ec996..31cf5e7 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -940,7 +940,7 @@ try: os.rmdir(imgPath) except OSError: - self.log.warning("Can't rmdir %s. %s", imgPath, exc_info=True) + self.log.warning("Can't rmdir %s", imgPath, exc_info=True) else: self.log.debug("removed image dir: %s", imgPath) return imgPath -- To view, visit http://gerrit.ovirt.org/10153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I951e582acc86e08d709da4249084015660fc4ea0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

5 7

Change in vdsm[master]: [WIP] api: Report hyperthreading info in getVdsCapabilities
by gpadgett＠redhat.com 20 Dec '12

20 Dec '12

Greg Padgett has uploaded a new change for review. Change subject: [WIP] api: Report hyperthreading info in getVdsCapabilities ...................................................................... [WIP] api: Report hyperthreading info in getVdsCapabilities Report hyperthreading info in getVdsCapabilities: cpuHtEnabled - Whether hyperthreading is enabled reportHostThreadsAsCores - Whether vdsm is reporting threads as cores, determined by vdsm.conf configuration setting This information is used by ovirt-engine to help determine CPU topology and provide support for cluster-based CPU overcommitment. Change-Id: If6868f3947ade62dda7cb6265b0c9e50c2face94 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M vdsm/caps.py M vdsm_api/vdsmapi-schema.json 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/10144/1 diff --git a/vdsm/caps.py b/vdsm/caps.py index d1297c9..07bfc28 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -253,10 +253,15 @@ cpuInfo = CpuInfo() cpuTopology = CpuTopology() + caps['cpuHtEnabled'] = \ + str(cpuTopology.threads() != cpuTopology.cores()).lower() + if config.getboolean('vars', 'report_host_threads_as_cores'): caps['cpuCores'] = str(cpuTopology.threads()) + caps['reportHostThreadsAsCores'] = 'true' else: caps['cpuCores'] = str(cpuTopology.cores()) + caps['reportHostThreadsAsCores'] = 'false' caps['cpuSockets'] = str(cpuTopology.sockets()) caps['cpuSpeed'] = cpuInfo.mhz() diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 1b1c075..30a8b8a 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -848,6 +848,8 @@ # # @kvmEnabled: KVM is enabled on the host # +# @cpuHtEnabled: CPU hyperthreading is enabled on this host +# # @cpuCores: The number of CPU cores present # # @cpuSockets: The numbet of CPU sockets @@ -857,6 +859,8 @@ # @cpuModel: The CPU model # # @cpuFlags: CPU feature flags (a comma-separated string) +# +# @reportHostThreadsAsCores: Vdsm is reporting threads as cores on this host # # @version_name: The name given to this version of VDSM # @@ -909,7 +913,8 @@ # the current API truncates @software_version to 'x.y'. ## {'type': 'VdsmCapabilities', - 'data': {'kvmEnabled': 'bool', 'cpuCores': 'uint', + 'data': {'kvmEnabled': 'bool', 'cpuHtEnabled': 'bool', 'cpuCores': 'uint', + 'reportHostThreadsAsCores': 'bool', 'cpuSockets': 'uint', 'cpuSpeed': 'float', 'cpuModel': 'str', 'cpuFlags': 'str', 'version_name': 'str', 'software_version': 'str', 'software_revision': 'str', 'supportedENGINEs': ['str'], -- To view, visit http://gerrit.ovirt.org/10144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6868f3947ade62dda7cb6265b0c9e50c2face94 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>

5 27

Change in vdsm[master]: storageMailboxTests: fix for f18
by Dan Kenigsberg 20 Dec '12

20 Dec '12

Dan Kenigsberg has uploaded a new change for review. Change subject: storageMailboxTests: fix for f18 ...................................................................... storageMailboxTests: fix for f18 Use /var/tmp (which is usually storage-based and has O_DIRECT) as tempdir. Change-Id: I2caacba292fc05118542ba3636281ef4970e32d4 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M tests/storageMailboxTests.py 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/10225/1 diff --git a/tests/storageMailboxTests.py b/tests/storageMailboxTests.py index b794dd7..7219ba9 100644 --- a/tests/storageMailboxTests.py +++ b/tests/storageMailboxTests.py @@ -30,6 +30,16 @@ from vdsm.utils import retry import tempfile +_oldtempdir = tempfile.tempdir + + +def setUpModule(): + tempfile.tempdir = '/var/tmp/' + + +def teadDownModule(): + tempfile.tempdir = _oldtempdir + class StoragePoolStub(object): def __init__(self): -- To view, visit http://gerrit.ovirt.org/10225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2caacba292fc05118542ba3636281ef4970e32d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

6 17

Change in vdsm[master]: restarting libvirtd didn't work over allinone setup
by ybronhei＠redhat.com 20 Dec '12

20 Dec '12

Yaniv Bronhaim has uploaded a new change for review. Change subject: restarting libvirtd didn't work over allinone setup ...................................................................... restarting libvirtd didn't work over allinone setup Change-Id: I1ab443fbef35f1ffaab59973f278eebe0143dd87 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=888258 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M vdsm/vdsmd.init.in 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/10237/1 diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in index 7a7ae84..af720cc 100755 --- a/vdsm/vdsmd.init.in +++ b/vdsm/vdsmd.init.in @@ -362,7 +362,11 @@ ovirt_store_config "$lconf" "$qconf" "$ldconf" "$llogr" - /sbin/initctl restart libvirtd 2>/dev/null || : + if libvirt_should_use_upstart; then + /sbin/initctl restart libvirtd 2>/dev/null || : + else + systemctl reload libvirtd.service + fi # # finished reconfiguration, do not trigger -- To view, visit http://gerrit.ovirt.org/10237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ab443fbef35f1ffaab59973f278eebe0143dd87 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>

4 11

Change in vdsm[master]: schema: Add tune element to vmparameter
by lvroyce＠linux.vnet.ibm.com 20 Dec '12

20 Dec '12

Royce Lv has uploaded a new change for review. Change subject: schema: Add tune element to vmparameter ...................................................................... schema: Add tune element to vmparameter This element includes all kinds of tunable parameter(e.g.CPU, mem, blockio) to support cgroup in vm create. Change-Id: I887e434aac8c4c277a5ae6b8b528984c8d53d51c Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M vdsm_api/vdsmapi-schema.json 1 file changed, 42 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/8638/1 diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 9be5e52..b9b60f5 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2254,6 +2254,40 @@ 'VmChannelDevice']} ## +# @CpuTuneParams: +# +# Parameters for @VM.tuneCpu. +# +# @cpu_shares: Relative share of CPU compared with other VMs +# +# @vcpu_period: The enforcement period of vcpu_quota +# +# @vcpu_quota: Max bandwidth vCPU can consume +# +# @emulator_quota: Max bandwidth of the emulator thread +# +# @emulator_period: The enforcement period of emulator_quota +# +# Since: 4.10.0 +## +{'type': 'CpuTuneParams', + 'data': {'cpu_shares': 'uint', 'vcpu_period': 'uint', + 'vcpu_quota': 'int', 'emulator_period': 'uint', + 'emulator_quota': 'int'}} + +## +# @TuneType: +# +# Type that includes all tunable parameters for @VM.create. +# +# @cpu: Limits of CPU and emulator thread. +# +# Since: 4.10.0 +## +{'type': 'TuneType', + 'data': {'cpu': 'CpuTuneParams'}} + +## # @VmShortStatus: # # Abbreviated virtual machine status. @@ -2319,6 +2353,8 @@ # @transparentHugePages: Indicates if the Transparent Huge Pages feature is # enabled for this virtual machine # +# @tune: #optional Tuning values for the VM. +# # @vmId: The VM UUID # # @vmName: The VM name @@ -2338,7 +2374,8 @@ 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint', 'status': 'VmStatus', 'timeOffset': 'uint', 'transparentHugePages': 'bool', - 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}} + '*tune': 'TuneType', 'vmId': 'UUID', + 'vmName': 'str', 'vmType': 'VmType'}} ## # @VmParameters: @@ -2370,6 +2407,8 @@ # @transparentHugePages: Indicates if the Transparent Huge Pages feature is # enabled for this virtual machine # +# @tune: #optional Tuning values for the VM. +# # @vmId: The VM UUID # # @vmName: The VM name @@ -2384,7 +2423,8 @@ 'display': 'VmDisplayType', 'kvmEnable': 'bool', 'memSize': 'uint', 'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint', 'smpThreadsPerCore': 'uint', 'timeOffset': 'uint', - 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', + 'transparentHugePages': 'bool', '*tune':'TuneType', + 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}} ## -- To view, visit http://gerrit.ovirt.org/8638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I887e434aac8c4c277a5ae6b8b528984c8d53d51c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

3 4

← Newer
1
...
27
28
29
30
31
32
33
...
41
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches December 2012