Change in vdsm[master]: Support sanlock killpath for the SPM
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Support sanlock killpath for the SPM
......................................................................
Support sanlock killpath for the SPM
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I68fecd8dd9753087c4840cb098ba28b10d76d8b8
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/constants.py.in
A vdsm/sanlock-stop-spm
M vdsm/storage/safelease.py
5 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/6385/1
--
To view, visit http://gerrit.ovirt.org/6385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68fecd8dd9753087c4840cb098ba28b10d76d8b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
......................................................................
BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
Attempting to stop the SPM (SIGUSR1) and using SIGKILL if that fails is
already enough. In any case giving vdsm only 2 seconds between SIGTERM
and SIGKILL was a too short timeout to hope in a restart.
Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8
---
M vdsm/storage/protect/spmprotect.sh
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/265/1
--
To view, visit http://gerrit.ovirt.org/265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: Modify volume.getChildrenList() to return objects
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Modify volume.getChildrenList() to return objects
......................................................................
Modify volume.getChildrenList() to return objects
Change-Id: I5d2686c097a7ec8ab1e77ff33122ae543a4f537c
---
M vdsm/storage/volume.py
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/2671/1
--
To view, visit http://gerrit.ovirt.org/2671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d2686c097a7ec8ab1e77ff33122ae543a4f537c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: [WIP] Add the validateImage command to vdsClient
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Add the validateImage command to vdsClient
......................................................................
[WIP] Add the validateImage command to vdsClient
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I896dc7c754a5679805ae212844c5551ab25249b6
---
M vdsm_cli/vdsClient.py
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/3492/1
--
To view, visit http://gerrit.ovirt.org/3492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I896dc7c754a5679805ae212844c5551ab25249b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: disconnectStoragePool must fail if resources are in use
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: disconnectStoragePool must fail if resources are in use
......................................................................
disconnectStoragePool must fail if resources are in use
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: Ic2f4ba01dfd8ba4de0a29a3ca8d0ca26aef83a80
---
M vdsm/storage/safelease.py
M vdsm/storage/sd.py
M vdsm/storage/sp.py
3 files changed, 20 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/4845/1
--
To view, visit http://gerrit.ovirt.org/4845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2f4ba01dfd8ba4de0a29a3ca8d0ca26aef83a80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: Reuse the stored pool host id on reconstructMaster
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Reuse the stored pool host id on reconstructMaster
......................................................................
Reuse the stored pool host id on reconstructMaster
When the SPM is unable to reach the master domain the VDSM process
might be fenced (killed) by safelease or sanlock.
The engine will try to reconstruct the master and VDSM would use
a temporary id (eg: 250) to execute the operation. This patch uses
the information stored by connectStoragePool to acquire the same
host id that was in use before VDSM restarted.
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/4965/1
--
To view, visit http://gerrit.ovirt.org/4965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44ff6d04220032ac1f6bd0a7819132103050b516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: (Schema) Define an error type
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Define an error type
......................................................................
(Schema) Define an error type
Change-Id: I89ddcc6f18d982cb1ea5e91a13bcf9f939ae6cb1
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 21 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/7146/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index f040667..7d54e09 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -217,6 +217,23 @@
'returns': {'*power': 'FenceNodePowerStatus'}}
##
+# @Error:
+#
+# Represents an error in VDSM.
+#
+# @code: Error identifier.
+#
+# @message: Extra information about the error, should be used for debugging
+# and logging. This only contains auxillery information and
+# shouldn't be used in any logic. The exact phrasing may change at
+# any time.
+#
+# Since: 4.10.0
+#XXX: Create an error list.
+##
+{'type': 'Error', 'data': {'code': 'int', 'message': 'str'}}
+
+##
# @TaskInfo:
#
# Extra information about a task.
@@ -795,14 +812,14 @@
#
# Information about a single block device path.
#
-# @physdev: The physical device name
+# @physdev: The physical device name
#
# @active: Whether the path is active. This will be false if the path has
# failed.
#
-# @lun: The SCSI Logical Unit Number associated with this path
+# @lun: The SCSI Logical Unit Number associated with this path
#
-# @type: The type of path (@BlockDeviceType)
+# @type: The type of path (@BlockDeviceType)
#
# Since: 4.10.0
##
@@ -2410,19 +2427,6 @@
'data': {'type': 'ConnectionRefType', 'params': 'ConnectionRefParameters'}}
##
-# @ConnectionError:
-#
-# A tuple containing @ConnectionRef error information.
-#
-# @code: The error code
-#
-# @message: The error message
-#
-# Since: 4.10.0
-##
-{'type': 'ConnectionError', 'data': {'code': 'int', 'message': 'str'}}
-
-##
# @ConnectionRef:
#
# Contains the details of a registered storage connection.
@@ -2436,7 +2440,7 @@
# Since: 4.10.0
##
{'type': 'ConnectionRef',
- 'data': {'connected': 'bool', 'lastError': 'ConnectionError',
+ 'data': {'connected': 'bool', 'lastError': 'Error',
'connectionInfo': 'ConnectionRefParameters'}}
##
--
To view, visit http://gerrit.ovirt.org/7146
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89ddcc6f18d982cb1ea5e91a13bcf9f939ae6cb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: (Schema) Remove deprecated storage connection APIs
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove deprecated storage connection APIs
......................................................................
(Schema) Remove deprecated storage connection APIs
Change-Id: I3618fd260dfb51a6b0252e39ade2abaab905b41a
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 0 insertions(+), 52 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/7147/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 7d54e09..e782613 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -3161,39 +3161,6 @@
'masterVersion': 'int'}}
##
-# @ConnectStorageServerStatus:
-#
-# Status of a single storage server connection attempt.
-#
-# @id: Connection UUID
-#
-# @status: Status code
-#
-# Since: 4.10.0
-##
-{'type': 'ConnectStorageServerStatus',
- 'data': {'id': 'UUID', 'status': 'int'}}
-
-##
-# @StoragePool.connectStorageServer:
-#
-# Establish a connection to backing storage.
-#
-# @domainType: The type of storage to connect
-#
-# @connectionParams: An array of connection information
-#
-# Returns:
-# @statuslist: The status of each connection attempt
-#
-# Since: 4.10.0
-##
-{'command': {'class': 'StoragePool', 'name': 'connectStorageServer'},
- 'data': {'domainType': 'StorageDomainType',
- 'connectionParams': ['ConnectionRefParameters']},
- 'returns': {'statuslist': ['ConnectStorageServerStatus']}}
-
-##
# @StoragePool.create:
#
# Create a new Storage Pool.
@@ -3259,25 +3226,6 @@
##
{'command': {'class': 'StoragePool', 'name': 'disconnect'},
'data': {'hostID': 'int', 'scsiKey': 'str', 'remove': 'bool'}}
-
-##
-# @StoragePool.disconnectStorageServer:
-#
-# Remove backing storage connections.
-#
-# @domainType: The type of backing storage
-#
-# @connectionParams: An array of connection information
-#
-# Returns:
-# @statuslist: The status of each connection attempt
-#
-# Since: 4.10.0
-##
-{'command': {'class': 'StoragePool', 'name': 'disconnectStorageServer'},
- 'data': {'domainType': 'StorageDomainType',
- 'connectionParams': ['ConnectionRefParameters']},
- 'returns': {'statuslist': ['ConnectStorageServerStatus']}}
##
# @SpmRole:
--
To view, visit http://gerrit.ovirt.org/7147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3618fd260dfb51a6b0252e39ade2abaab905b41a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: (Schema) Have discoverSendTargets return parsed objects
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Have discoverSendTargets return parsed objects
......................................................................
(Schema) Have discoverSendTargets return parsed objects
Change-Id: Ib5b0bba668e3c2532805bef3aefa7cc9302285b0
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 30 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/7149/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index b103b28..581c5ff 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2517,22 +2517,45 @@
'data': {'address': 'NetworkAddress', '*user': 'str', '*password': 'str'}}
##
+# @IscsiQualifiedName:
+#
+# An iSCSI Qualified Name in RFC 3720 format.
+# eg. "iqn.1992-01.com.example:storage:diskarrays-sn-a8675309"
+#
+# Since: 4.10.0
+##
+{'alias': 'IscsiQualifiedName', 'data': 'str'}}
+
+#
+# @IscsiTarget:
+#
+# Describes an Iscsi Target.
+#
+# @portal: The portal which contains the target.
+#
+# @tpgt: The target portal group tag.
+#
+# @iqn: The iqn of the target.
+#
+# Since: 4.10.0
+##
+{'type': 'IscsiTarget',
+ 'data': {'portal': 'IscsiPortal',
+ 'tpgt': 'uint',
+ 'iqn': 'IscsiQualifiedName'}}
+
+#
# @ISCSIConnection.discoverSendTargets:
#
# Discover available targets for this @ISCSIConnection.
#
# Returns:
-# @targets: A list of discovered target iqns
-#
-# @fullTargets: A list of discovered targets in the form:
-# '<host>:<port>,<tpgt> <iqn>'
+# @targets: A list of discovered targets.
#
# Since: 4.10.0
-# XXX: The fullTargets strings should be broken out into their respective parts
-# XXX: The return values are in the same dictionary as the command status!
##
{'command': {'class': 'ISCSIConnection', 'name': 'discoverSendTargets'},
- 'returns': {'targets': ['str'], 'fullTargets': ['str']}}
+ 'returns': {'targets': ['IscsiTarget']}}
## Category: @Image ############################################################
##
--
To view, visit http://gerrit.ovirt.org/7149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5b0bba668e3c2532805bef3aefa7cc9302285b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
9 years, 11 months
Change in vdsm[master]: (Schema) Consolidate changeCD and changeFloppy to a single c...
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Consolidate changeCD and changeFloppy to a single call
......................................................................
(Schema) Consolidate changeCD and changeFloppy to a single call
Change-Id: I10332653af4cebd42bccffe178f84feac4ba5357
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/7150/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 581c5ff..9ee296b 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -3944,18 +3944,18 @@
'DriveSpecPayload', 'DriveSpecPath']}
##
-# @VM.changeCD:
+# @VM.changeMedia:
#
-# Change the CD in the VM's CD-ROM device.
+# Change the media in a drive.
#
-# @driveSpec: The specification of the new CD
+# @driveSpec: The specification of the new media
#
# Returns:
# @vmList: The VM definition, as updated
#
# Since: 4.10.0
##
-{'command': {'class': 'VM', 'name': 'changeCD'},
+{'command': {'class': 'VM', 'name': 'changeMedia'},
'data': {'driveSpec': 'DriveSpec'},
'returns': {'vmList': 'VmDefinition'}}
--
To view, visit http://gerrit.ovirt.org/7150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10332653af4cebd42bccffe178f84feac4ba5357
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
9 years, 11 months