Eduardo has uploaded a new change for review.
Change subject: [WIP] Towards a more (block) secure HSM.
......................................................................
[WIP] Towards a more (block) secure HSM.
Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
---
M vdsm/storage/hsm.py
M vdsm/storage/lvm.py
M vdsm/storage/sp.py
3 files changed, 25 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/2218/1
--
To view, visit http://gerrit.ovirt.org/2218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Add a chown implementation that looks up uid and gid
......................................................................
Add a chown implementation that looks up uid and gid
We already have a case in vdsm (configNetwork) where we need to use
a chown function that is capable to convert the owner and group names
to uid and gid. Going forward this can be reused for the deployment
utilities and to prepare the paths needed by vdsm (eg: /rhev and
/var/run/vdsm).
Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555
---
M vdsm/configNetwork.py
M vdsm/utils.py
2 files changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/387/1
--
To view, visit http://gerrit.ovirt.org/387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Add the base commands to vdsm-tool
......................................................................
[WIP] Add the base commands to vdsm-tool
Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e
---
M vdsm-tool/Makefile.am
A vdsm-tool/base.py
M vdsm.spec.in
3 files changed, 52 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/388/1
--
To view, visit http://gerrit.ovirt.org/388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
......................................................................
BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
Attempting to stop the SPM (SIGUSR1) and using SIGKILL if that fails is
already enough. In any case giving vdsm only 2 seconds between SIGTERM
and SIGKILL was a too short timeout to hope in a restart.
Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8
---
M vdsm/storage/protect/spmprotect.sh
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/265/1
--
To view, visit http://gerrit.ovirt.org/265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gal Hammer has uploaded a new change for review.
Change subject: Added a support for a guest hibernate command.
......................................................................
Added a support for a guest hibernate command.
Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
---
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm_cli/vdsClient.py
3 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/1121/1
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Don't rotate core dump logs on Fedora
......................................................................
Don't rotate core dump logs on Fedora
Core dumps are a system-level configuration and VDSM shouldn't try to
override what the sysadmin decides.
Change-Id: I0a2e86614475fd13de3888b956b5512a24016281
---
M configure.ac
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/cdumps-logrotate.conf
A vdsm/vdsm-logrotate.conf
D vdsm/vdsm-logrotate.conf.in
6 files changed, 27 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/991/1
--
To view, visit http://gerrit.ovirt.org/991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Support the quiesce flag during a live snapshot
......................................................................
Support the quiesce flag during a live snapshot
Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d
---
M vdsm.spec.in
M vdsm/libvirtvm.py
2 files changed, 38 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/2223/1
--
To view, visit http://gerrit.ovirt.org/2223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Mark Wu has uploaded a new change for review.
Change subject: [WIP] MOM Integration
......................................................................
[WIP] MOM Integration
This patch tries to integrate MOM with vdsm. For the descprition of
how this patch works, please see Adam's mail:
https://fedorahosted.org/pipermail/vdsm-devel/2012-February/000628.html
Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
---
M vdsm.spec.in
M vdsm/API.py
M vdsm/Makefile.am
M vdsm/clientIF.py
M vdsm/config.py.in
M vdsm/ksm.py
M vdsm/libvirtvm.py
A vdsm/mom.conf
A vdsm/mom.policy
M vdsm/supervdsmServer.py
A vdsm/vdsMOM.py
M vdsm/vm.py
12 files changed, 271 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/2367/1
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Shahar Havivi has uploaded a new change for review.
Change subject: enable attaching non-vlan network to vlanable network.
......................................................................
enable attaching non-vlan network to vlanable network.
this patch have a security breach:
when adding a network without a vlan to already attach vlan network this
network can monitor all the traffic of the other vlans.
we may be able to restrict it using ebtables.
Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
---
M vdsm/configNetwork.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/2161/1
--
To view, visit http://gerrit.ovirt.org/2161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert "BZ#708779 - Avoid pools with mixed domain versions"
......................................................................
Revert "BZ#708779 - Avoid pools with mixed domain versions"
This reverts commit 017db3b2740a8c7d22c5366c70600eb47643e8ab.
We would like to allow upgrading a storage pool to new 3.0 format, and
to allow upgrading 2.2 domains automatically when they are attached to a
3.0-formatted pool.
Conflicts:
vdsm/storage/hsm.py
vdsm/storage/sp.py
Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
3 files changed, 12 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/753/1
--
To view, visit http://gerrit.ovirt.org/753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/692
commit 3a09f874889cb372ee84b04a234f7b653458e26f
Author: Igor Lvovsky <ilvovsky(a)redhat.com>
Date: Tue Jul 12 15:18:45 2011 +0300
Change getChain() to return dictionary with chain itself and its template.
This change will avoid unneeded produceVolume and improve
behaviour of different flows.
Change-Id: Ife46d592171aedea087e0d6462b735cd7e0d75e0
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 1c70a34..102ea6c 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -104,7 +104,7 @@ class Image:
# 1. Remove template's image: Create 'fake' template instead of deleted one
# 2. Remove regular image: Remove parent-'fake' template if nobody need it already
try:
- pvol = self.getTemplate(sdUUID=sdUUID, imgUUID=imgUUID)
+ pvol = self.getChain(sdUUID, imgUUID)['template']
# 1. If we required to delete template's image that have VMs
# based on it, we should create similar 'fake' template instead
if pvol:
@@ -269,17 +269,16 @@ class Image:
return newImgUUID
- def __chainSizeCalc(self, sdUUID, imgUUID, volUUID, size):
+ def __chainSizeCalc(self, sdUUID, imgUUID, size):
"""
Compute an estimate of the whole chain size
using the sum of the actual size of the chain's volumes
"""
- chain = self.getChain(sdUUID, imgUUID, volUUID)
+ chainDict = self.getChain(sdUUID, imgUUID)
newsize = 0
- template = chain[0].getParentVolume()
- if template:
- newsize = template.getVolumeSize()
- for vol in chain:
+ if chainDict['template']:
+ newsize = chainDict['template'].getVolumeSize()
+ for vol in chainDict['chain']:
newsize += vol.getVolumeSize()
if newsize > size:
newsize = size
@@ -301,12 +300,14 @@ class Image:
newsize = int(newsize * 1.1) # allocate %10 more for cow metadata
return newsize
- def getChain(self, sdUUID, imgUUID, volUUID=None):
+ def getChain(self, sdUUID, imgUUID):
"""
- Return the chain of volumes of image as a sorted list
- (not including a shared base (template) if any)
+ Return the dictionary with chain of volumes of image as a sorted list
+ (not including a shared base (template)) and the template if any
"""
- chain = []
+ # 'chain' - chain of volumes of image as a sorted list
+ # 'template' - shared base (template) if any
+ chainDict = {'chain':[], 'template':None}
# Find all volumes of image
volclass = SDF.produce(sdUUID).getVolumeClass()
uuidlist = volclass.getImageVolumes(self.repoPath, sdUUID, imgUUID)
@@ -316,14 +317,13 @@ class Image:
srcVol = volclass(self.repoPath, sdUUID, imgUUID, uuidlist[0])
# For template image include only one volume (template itself)
if len(uuidlist) == 1 and srcVol.isShared():
- return [srcVol]
+ return {'chain':[srcVol], 'template':srcVol}
# find the leaf
for vol in uuidlist:
srcVol = volclass(self.repoPath, sdUUID, imgUUID, vol)
if srcVol.isLeaf():
- if not volUUID or volUUID == srcVol.volUUID:
- break
+ break
srcVol = None
if not srcVol:
@@ -332,38 +332,25 @@ class Image:
# Build up the sorted (parent->child) chain
while not srcVol.isShared():
- chain.insert(0, srcVol)
+ chainDict['chain'].insert(0, srcVol)
if srcVol.getParent() == volume.BLANK_UUID:
break
srcVol = srcVol.getParentVolume()
- self.log.info("sdUUID=%s imgUUID=%s chain=%s ", sdUUID, imgUUID, str(chain))
- return chain
+ if srcVol.isShared():
+ chainDict['template'] = srcVol
- def getTemplate(self, sdUUID, imgUUID):
- """
- Return template of the image
- """
- tmpl = None
- # Find all volumes of image (excluding template)
- chain = self.getChain(sdUUID, imgUUID)
- # check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
- if pvol:
- tmpl = pvol
- elif chain[0].isShared():
- tmpl = chain[0]
-
- return tmpl
+ self.log.info("sdUUID=%s imgUUID=%s chainDict=%s ", sdUUID, imgUUID, str(chainDict))
+ return chainDict
def validate(self, srcSdUUID, dstSdUUID, imgUUID, op=MOVE_OP):
"""
Validate template on destination domain
"""
- # Find all volumes of source image
- chain = self.getChain(srcSdUUID, imgUUID)
- leafVol = chain[-1]
srcDom = SDF.produce(srcSdUUID)
+ # Find all volumes of source image
+ chainDict = self.getChain(srcSdUUID, imgUUID)
+ leafVol = chainDict['chain'][-1]
# Avoid move template's image if there is a VM based on it (except 'Backup' domain)
if op == MOVE_OP and leafVol.isShared() and not srcDom.isBackup():
chList = leafVol.getAllChildrenList(self.repoPath, srcSdUUID, imgUUID, leafVol.volUUID)
@@ -371,18 +358,16 @@ class Image:
raise se.MoveTemplateImageError(imgUUID)
# check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
+ pvol = chainDict['template']
if pvol: # this is a shared template based chain
- if not pvol.isShared():
- raise se.ImageIsNotLegalChain("Base image parent vol %s is not shared" % pvol.volUUID)
pimg = pvol.getImage() # pimg == template image
try:
volclass = SDF.produce(dstSdUUID).getVolumeClass()
# Validate that the destination template exists and accessible
volclass(self.repoPath, dstSdUUID, pimg, pvol.volUUID)
- except se.StorageException, e:
- self.log.error("Unexpected error", exc_info=True)
- raise se.CouldNotValideTemplateOnTargetDomain("Template %s Destination domain %s: %s" % (pimg, dstSdUUID, str(e)))
+ except se.StorageException:
+ self.log.error("Cannot validate template %s on target domain %s", pimg, dstSdUUID, exc_info=True)
+ raise se.CouldNotValideTemplateOnTargetDomain()
def __templateRelink(self, destDom, imgUUID, volUUID):
"""
@@ -473,20 +458,15 @@ class Image:
def _createTargetImage(self, destDom, srcSdUUID, imgUUID):
# Before actual data copying we need perform several operation
# such as: create all volumes, create fake template if needed, ...
- try:
- # Find all volumes of source image
- srcChain = self.getChain(srcSdUUID, imgUUID)
- except se.StorageException:
- self.log.error("Unexpected error", exc_info=True)
- raise
- except Exception, e:
- self.log.error("Unexpected error", exc_info=True)
- raise se.SourceImageActionError(imgUUID, srcSdUUID, str(e))
+
+ # Find all volumes of source image
+ srcChainDict = self.getChain(srcSdUUID, imgUUID)
+ srcChain = srcChainDict['chain']
fakeTemplate = False
pimg = volume.BLANK_UUID # standalone chain
# check if the chain is build above a template, or it is a standalone
- pvol = srcChain[0].getParentVolume()
+ pvol = srcChainDict['template']
if pvol:
# find out parent volume parameters
volParams = pvol.getVolumeParams()
@@ -686,11 +666,9 @@ class Image:
"""
if not self.isLegal(sdUUID, imgUUID):
raise se.ImageIsNotLegalChain(imgUUID)
- chain = self.getChain(sdUUID, imgUUID)
- # check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
- if pvol:
- if not pvol.isLegal() or pvol.isFake():
+ chainDict = self.getChain(sdUUID, imgUUID)
+ if chainDict['template']:
+ if not chainDict['template'].isLegal() or chainDict['template'].isFake():
raise se.ImageIsNotLegalChain(imgUUID)
def copy(self, sdUUID, vmUUID, srcImgUUID, srcVolUUID, dstImgUUID, dstVolUUID,
@@ -735,8 +713,7 @@ class Image:
# using the sum of the actual size of the chain's volumes
if volParams['volFormat'] != volume.COW_FORMAT or volParams['prealloc'] != volume.SPARSE_VOL:
raise se.IncorrectFormat(self)
- volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID,
- srcVolUUID, volParams['size'])
+ volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID, volParams['size'])
# Find out dest volume parameters
if preallocate in [volume.PREALLOCATED_VOL, volume.SPARSE_VOL]:
diff --git a/vdsm/storage/resourceFactories.py b/vdsm/storage/resourceFactories.py
index ce3ec70..07df0f0 100644
--- a/vdsm/storage/resourceFactories.py
+++ b/vdsm/storage/resourceFactories.py
@@ -106,20 +106,18 @@ class ImageResourceFactory(rm.SimpleResourceFactory):
# Get the list of the volumes
repoPath = os.path.join(self.storage_repository, dom.getPools()[0])
try:
- chain = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName)
+ chainDict = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName)
+ chain = chainDict['chain']
except se.ImageDoesNotExistInSD:
log.debug("Image %s does not exist in domain %s", resourceName, self.sdUUID)
return []
- # check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
- if pvol:
- template = pvol.volUUID
- elif chain[0].isShared():
- # Image of template itself,
- # with no other volumes in chain
- template = chain[0].volUUID
- del chain[:]
+ # Image of template itself,
+ # with no other volumes in chain
+ if chainDict['template']:
+ template = chainDict['template'].volUUID
+ if chainDict['template'] in chain:
+ del chain[:]
volUUIDChain = [vol.volUUID for vol in chain]
volUUIDChain.sort()
Doron Fediuck has uploaded a new change for review.
Change subject: bootstrapping: avoid usage of tmp folder
......................................................................
bootstrapping: avoid usage of tmp folder
This patch changes hard-coded tmp path elements, so the scripts
may be used from a different location. Once invoked by the engine-core
from an ad-hoc folder, the bootstrapping scripts should support
working on that folder. This is mainly referring to imports,
certificate files and log files.
Change-Id: I1b5df6dd0b5ff0bdf648cd74d160384b86e5bbf7
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_bootstrap_complete.py
M vdsm_reg/deployUtil.py.in
3 files changed, 35 insertions(+), 32 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/2277/1
--
To view, visit http://gerrit.ovirt.org/2277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b5df6dd0b5ff0bdf648cd74d160384b86e5bbf7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Add the REST API bindings
......................................................................
Add the REST API bindings
Conflicts:
vdsm/clientIF.py
Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
---
M configure.ac
M vdsm.spec.in
M vdsm/BindingXMLRPC.py
M vdsm/Makefile.am
M vdsm/clientIF.py
M vdsm/config.py.in
A vdsm/rest/BindingREST.py
A vdsm/rest/Controller.py
A vdsm/rest/Dispatcher.py
A vdsm/rest/Makefile.am
A vdsm/rest/Store/LocalDB.py
A vdsm/rest/Store/Makefile.am
A vdsm/rest/Store/StorageDriver.py
A vdsm/rest/Store/__init__.py
A vdsm/rest/__init__.py
A vdsm/rest/templates/Makefile.am
A vdsm/rest/templates/image.json.x
A vdsm/rest/templates/images.json.x
A vdsm/rest/templates/root.json.x
A vdsm/rest/templates/storageconnection.json.x
A vdsm/rest/templates/storageconnections.json.x
A vdsm/rest/templates/storagedomain.json.x
A vdsm/rest/templates/storagedomains.json.x
A vdsm/rest/templates/storagepool.json.x
A vdsm/rest/templates/storagepools.json.x
A vdsm/rest/templates/task.json.x
A vdsm/rest/templates/tasks.json.x
A vdsm/rest/templates/vm.json.x
A vdsm/rest/templates/vmdrive.json.x
A vdsm/rest/templates/vmdrives.json.x
A vdsm/rest/templates/vms.json.x
A vdsm/rest/templates/volume.json.x
A vdsm/rest/templates/volumes.json.x
33 files changed, 1,740 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/2021/1
--
To view, visit http://gerrit.ovirt.org/2021
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#752470 Related: Out of process getReadDelay
......................................................................
BZ#752470 Related: Out of process getReadDelay
To avoid being blocked by a thread in a D state we should determine the
read delay using oop also for block devices.
Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e
---
M vdsm/storage/blockSD.py
M vdsm/storage/misc.py
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/264/1
--
To view, visit http://gerrit.ovirt.org/264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: vm payload: add file injection to vm
......................................................................
vm payload: add file injection to vm
this patch adds new parameter to create verb vmPayload,
user can send file content and have them in the vm in floppy of iso
format.
Change-Id: I256475342c79690a95ad999335522f99714cdc8b
---
M configure.ac
M vdsm/constants.py.in
M vdsm/libvirtvm.py
M vdsm/supervdsmServer.py
M vdsm/vm.py
5 files changed, 99 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/2321/1
--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#773210 - Avoid infinity loop when delete volume failed during the merge
......................................................................
BZ#773210 - Avoid infinity loop when delete volume failed during the merge
Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
---
M vdsm/storage/image.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/987/1
--
To view, visit http://gerrit.ovirt.org/987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Integrate SANLock with VM's life cycle
......................................................................
Integrate SANLock with VM's life cycle
Change-Id: I55596a7a5b25fded341f6157f190ae741af41fce
---
M vdsm/libvirtvm.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/sd.py
5 files changed, 78 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/1253/1
--
To view, visit http://gerrit.ovirt.org/1253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55596a7a5b25fded341f6157f190ae741af41fce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Define some constants in API.py
......................................................................
Define some constants in API.py
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
---
M vdsm/API.py
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/2262/1
--
To view, visit http://gerrit.ovirt.org/2262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Support unicode in domain and pool description
......................................................................
[WIP] Support unicode in domain and pool description
Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e
---
M vdsm/storage/dispatcher.py
M vdsm/storage/persistentDict.py
M vdsm/storage/sd.py
M vdsm/storage/sp.py
4 files changed, 17 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/637/1
--
To view, visit http://gerrit.ovirt.org/637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: added support for mirror promisc mode
......................................................................
added support for mirror promisc mode
let ability to VM to monitor (mirror) all other VMs in the same host by
specific network (bridge)
Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
---
M configure.ac
M vdsm/libvirtvm.py
2 files changed, 123 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/956/1
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Workaround a known localstorage bug
......................................................................
Workaround a known localstorage bug
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
Change-Id: I783b83f75afba2854c7b87f5e2abd52a76bc2458
---
M vdsm/storage/storage_connection.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/2261/1
--
To view, visit http://gerrit.ovirt.org/2261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I783b83f75afba2854c7b87f5e2abd52a76bc2458
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Try to destroy VM gracefully
......................................................................
Try to destroy VM gracefully
Change-Id: If58f1b0e7208242aef0b81d9ea59d05bd3d5d99e
---
M vdsm/libvirtvm.py
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/2138/1
--
To view, visit http://gerrit.ovirt.org/2138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If58f1b0e7208242aef0b81d9ea59d05bd3d5d99e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: do not croak on mountpoint with space and digit
......................................................................
do not croak on mountpoint with space and digit
A mountpoint with ' 09' just gave me
Change-Id: I33997893320041648187c56e8500348a6850fdfe
return _RE_ESCAPE.sub(lambda s: chr(int(s.group()[1:], 8)), path)
ValueError: invalid literal for int() with base 8: '04009'
---
M vdsm/storage/mount.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/2068/1
--
To view, visit http://gerrit.ovirt.org/2068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33997893320041648187c56e8500348a6850fdfe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
......................................................................
BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
When http://gerrit.ovirt.org/1848 and http://gerrit.ovirt.org/1689 are taken
into Engine, -u and -n options to vds_bootrap would never be passed.
Remove this dead code.
Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
---
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
2 files changed, 9 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/1931/1
--
To view, visit http://gerrit.ovirt.org/1931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Hello Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/2185
to review the following change.
Change subject: Added blkid tool into constants.
......................................................................
Added blkid tool into constants.
blkid tool is used to get block device attributes
Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M configure.ac
M vdsm/constants.py.in
M vdsm/sudoers.vdsm.in
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/2185/1
--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: dumpStorageTable: search deeper for vms list
......................................................................
dumpStorageTable: search deeper for vms list
Change-Id: I264ece45f42e0707070efb26a651cb492840c552
---
M vdsm/dumpStorageTable.py.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/2427/1
--
To view, visit http://gerrit.ovirt.org/2427
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I264ece45f42e0707070efb26a651cb492840c552
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Add the device type in the snapshot dictionary
......................................................................
Add the device type in the snapshot dictionary
Since commit 3c1dad8 (Fix vdsm disks ops for the new API) it is required
to pass the device type to prepareVolumePath.
Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/2437/1
--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Roi Dayan has uploaded a new change for review.
Change subject: fixed iscsi discovery and added iSER transport support
......................................................................
fixed iscsi discovery and added iSER transport support
Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
---
M vdsm/config.py.in
M vdsm/storage/iscsi.py
2 files changed, 41 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1350/1
--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com>
Gal Hammer has uploaded a new change for review.
Change subject: A new method to read from VMs' channels.
......................................................................
A new method to read from VMs' channels.
Replaced having a thread-per-VM that monitor and read from the
VM's virtual channel with a 1-thread listener that handle all
VMs' channels.
Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm/libvirtvm.py
A vdsm/vmChannels.py
6 files changed, 164 insertions(+), 69 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/869/1
--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] The begining of the new API
......................................................................
[WIP] The begining of the new API
Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663
---
M vdsm/storage/hsm.py
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/1695/1
--
To view, visit http://gerrit.ovirt.org/1695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Refactor storage connection subsystem
......................................................................
Refactor storage connection subsystem
The current one is an abysmal mess. This is a tramsitional patch
retrofitting the old API to some of the concept we intend to implement.
This introduces ConnectionMonitor. It currently doesn't do any
monitoring just connects and disconnects from storage. It uses URIs for
specifying storage targets which is more generic and simple to parse.
Notice:
Permissions are no longer checked on storage connect only on domain
initialization. This is good as the storage connection is far from an
apropriate place for that check.
I've removed stale root folder handling for NFS. I will add it back I
can't do everything at once.
There are also no proper engine acceptable exceptions yet
Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
A vdsm/storage/connectionMonitor.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
M vdsm/storage/localFsSD.py
M vdsm/storage/misc.py
M vdsm/storage/mount.py
M vdsm/storage/multipath.py
M vdsm/storage/nfsSD.py
A vdsm/storage/storageMailbox.py
D vdsm/storage/storage_connection.py
A vdsm/storage/sync.py
14 files changed, 884 insertions(+), 486 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/1038/1
--
To view, visit http://gerrit.ovirt.org/1038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: ISCSI Subsystem refactoring
......................................................................
ISCSI Subsystem refactoring
Currently the iscsi subsystem is a mess of list concatenation.
This refactoring ties to:
- Make variable and object naming consistent and in line with iscsi
terminology.
Note that:
* portal now refres to an ISCSI Portal and not a tpgt
* tpgt now refres to tpgt
* ISCSI interfaces are modeled so that initiator name is actually
property of the interface and not it's identity
- Make a coherent object hierarchy of the ISCSI objects. Functions now
expect to get ISCSI objects (like portal, target) instead of
scattered arguments that have to be validated and parsed every
time.
- Make the ISCSI interface a 1st class member. Up until now support
for multiple interfaces was amateurish at best.
- Support for different credentials for discovery and target. Ground
work to support authentication methods other then CHAP.
- Thin wrap around iscsiadm to separate cmdline parsing from actual
VDSM iscsi logic
Stuff known to be broken:
- iser support. It was weirdly hacked in the old code. I will put a
code path to preserve backward compatibility.
- implicit interface creation. As this was never officially
supported by VDSM I will not bring this back.
- tpgt is ignores. This is in line with old VDSM behaviour.
Note that the confusing naming is still used by the old API calls for
backward compatibility. New API calls should try and use correct naming
and format!
Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
---
M vdsm.spec.in
M vdsm/constants.py.in
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
A vdsm/storage/iscsiadm.py
M vdsm/storage/multipath.py
M vdsm/storage/storageProviderConnectionMonitor.py
M vdsm/supervdsmServer.py
9 files changed, 609 insertions(+), 424 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/1607/1
--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Move the VDSM common code to the python site lib
......................................................................
[WIP] Move the VDSM common code to the python site lib
Some VDSM code is shared between different components (eg: vdsm and
vdsm-cli share vdscli.py) and some modules have a really common name
(eg: utils, config) risking to collide with other packages.
For these two reasons and for cleanliness some modules are moved to
a new location (the standard python site lib) and they can be shipped
in a different package.
Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
---
M configure.ac
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/caps.py
M vdsm/clientIF.py
M vdsm/config.py
M vdsm/configNetwork.py
M vdsm/get-conf-item
M vdsm/guestIF.py
M vdsm/hooks.py
M vdsm/kaxmlrpclib.py
M vdsm/ksm.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/netinfo.py
M vdsm/set-conf-item
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/devicemapper.py
M vdsm/storage/dispatcher.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileUtils.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
M vdsm/storage/outOfProcess.py
M vdsm/storage/processPool.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/safelease.py
M vdsm/storage/sd.py
M vdsm/storage/sdc.py
M vdsm/storage/sp.py
M vdsm/storage/storage_connection.py
M vdsm/storage/storage_mailbox.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/volume.py
M vdsm/substitute_constants.py
M vdsm/supervdsm.py
M vdsm/supervdsmServer.py
M vdsm/ut/ivdsm.py
M vdsm/ut/testGuestChannel.py
M vdsm/utils.py
M vdsm/vdsm
M vdsm/vm.py
M vdsm_cli/Makefile.am
M vdsm_cli/dumpStorageTable.py
M vdsm_cli/vdsClient.py
M vdsm_cli/vdscli.py.in
M vdsm_hooks/faqemu/before_vm_start.py
M vdsm_hooks/vhostmd/after_vm_destroy.py
M vdsm_reg/rhevm.py
M vdsm_reg/vdsm-reg-setup
57 files changed, 144 insertions(+), 129 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/286/1
--
To view, visit http://gerrit.ovirt.org/286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#797354 drop enic from modprobe.d/vdsm.conf
......................................................................
BZ#797354 drop enic from modprobe.d/vdsm.conf
Change-Id: Ia3bf4b25a8493585301d515b1e76e5f75755c86b
---
M vdsm/vdsm-modprobe.conf
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/2337/1
--
To view, visit http://gerrit.ovirt.org/2337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3bf4b25a8493585301d515b1e76e5f75755c86b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Initial live merge implementation
......................................................................
[WIP] Initial live merge implementation
Change-Id: I27c3f8378defcce0c7123894fbe09636910fb275
---
M vdsm.spec.in
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/define.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/storage/hsm.py
7 files changed, 87 insertions(+), 37 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/1806/1
--
To view, visit http://gerrit.ovirt.org/1806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27c3f8378defcce0c7123894fbe09636910fb275
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Ewoud Kohl van Wijngaarden has uploaded a new change for review.
Change subject: Replace most traceback.format_exc() calls by exc_info
......................................................................
Replace most traceback.format_exc() calls by exc_info
Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_qualifier.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm/ksm.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/storage/misc.py
M vdsm/storage/storage_mailbox.py
M vdsm/utils.py
M vdsm/vdsm
M vdsm/vm.py
M vdsm_reg/vdsm-gen-cert
M vdsm_reg/vdsm-reg-setup.in
16 files changed, 56 insertions(+), 65 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/2259/1
--
To view, visit http://gerrit.ovirt.org/2259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Mark Wu has uploaded a new change for review.
Change subject: [WIP] MOM Integration This patch tries to integrate MOM with vdsm. For the descprition of how this patch works, please see Adam's mail: https://fedorahosted.org/pipermail/vdsm-devel/2012-February/000628.html
......................................................................
[WIP] MOM Integration
This patch tries to integrate MOM with vdsm. For the descprition of
how this patch works, please see Adam's mail:
https://fedorahosted.org/pipermail/vdsm-devel/2012-February/000628.html
Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2e
---
M vdsm.spec.in
M vdsm/API.py
M vdsm/Makefile.am
M vdsm/clientIF.py
M vdsm/config.py.in
M vdsm/ksm.py
M vdsm/libvirtvm.py
A vdsm/mom.conf
A vdsm/mom.policy
M vdsm/supervdsmServer.py
A vdsm/vdsMOM.py
M vdsm/vm.py
12 files changed, 271 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/2366/1
--
To view, visit http://gerrit.ovirt.org/2366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Maintain detachSD semantics
......................................................................
Maintain detachSD semantics
Before d5ae1d360fa0648f5609a07db2439b0fcc429a44 we did not allow to
detach a master domain if we end up leaving a pool for attached data
domains. This patch suggests to keep this semantics
Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
---
M vdsm/storage/sp.py
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/2057/1
--
To view, visit http://gerrit.ovirt.org/2057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39f4d731d7087be63366fa351ac9cf0fa4b1d7db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Doron Fediuck has uploaded a new change for review.
Change subject: boostrap completion: Restart vdsmd service.
......................................................................
boostrap completion: Restart vdsmd service.
Recently we've fixed the functionality which avoids
reboot once bootstrap is completed. However, the vdsmd
service requiers restart in order to pick up the new
configuration and the new certificates issues during
the bootstrap.
This patch uses the same logic as the ovirt-node reboot
function, which reboots the machine or restarts the
vdsmd servide when reboot is avoided.
Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
---
M vds_bootstrap/vds_bootstrap_complete.py
1 file changed, 12 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/2194/1
--
To view, visit http://gerrit.ovirt.org/2194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib95b7cd9aeeff89c0b56e10c6b34f5b853d1f848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Release the host ID only when dom is defined
......................................................................
Release the host ID only when dom is defined
Change-Id: I8842d263463dc11dec17f96aa228d22037e75afd
---
M vdsm/storage/sp.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/2160/1
--
To view, visit http://gerrit.ovirt.org/2160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8842d263463dc11dec17f96aa228d22037e75afd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Eduardo has uploaded a new change for review.
Change subject: Fix vdsm disks ops for the new API.
......................................................................
Fix vdsm disks ops for the new API.
Change-Id: I9e6eddd8de3cb545e950817d12fd6fd8ff3c2379
---
M vdsm/clientIF.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 14 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/2131/1
--
To view, visit http://gerrit.ovirt.org/2131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e6eddd8de3cb545e950817d12fd6fd8ff3c2379
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Doron Fediuck has uploaded a new change for review.
Change subject: boostrap completion: fix no reboot report.
......................................................................
boostrap completion: fix no reboot report.
This patch fixes the vds_bootsrap_complete XML report;
when the script is being asked not to reboot the machine,
so the operation is still considered to be a success.
Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb
---
M vds_bootstrap/vds_bootstrap_complete.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/2121/1
--
To view, visit http://gerrit.ovirt.org/2121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirtvm.Drive: compute blockDev locally
......................................................................
libvirtvm.Drive: compute blockDev locally
There is no need to expose the blockDev boolean in Vdsm API; but it
should exist in any Drive.
Change-Id: I380f26326f374aa210970f2b9dd4167aa90a57fb
---
M vdsm/clientIF.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/2063/1
--
To view, visit http://gerrit.ovirt.org/2063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I380f26326f374aa210970f2b9dd4167aa90a57fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#567077 task.py: avoid overtly silly casting to str()
......................................................................
BZ#567077 task.py: avoid overtly silly casting to str()
For a reason unknown (to me), task.py does not use pickle to persist its
data to file. We cannot fix that without breaking
backward-compatibility. However, we can avoid pointless casts to str,
and can encode data to utf8 before storing to disk.
Change-Id: I97db724db436e99b95c3524e70fab540f7191334
---
M vdsm/storage/task.py
1 file changed, 48 insertions(+), 50 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/1622/1
--
To view, visit http://gerrit.ovirt.org/1622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97db724db436e99b95c3524e70fab540f7191334
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: This us a useful method for converting namedtuples to dictionaries
......................................................................
This us a useful method for converting namedtuples to dictionaries
Change-Id: Iad65e43b53cf32dcf2f8730d5c1bed2c7b655176
---
M vdsm/storage/misc.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/1692/1
--
To view, visit http://gerrit.ovirt.org/1692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad65e43b53cf32dcf2f8730d5c1bed2c7b655176
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Make validateStorageServerConnection API call a noop
......................................................................
Make validateStorageServerConnection API call a noop
This call is useless and slow. It check different things in different
levels for different storage types and does not guarantee a future
connect will succeed. Until someone actually defines what is actually
being validated (params? hostname? permissions? authentication tokens?)
I suggest to just disable this verb so it doesn't make any NFS
connection take twice as long and be exponentially more complex.
Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
---
M vdsm/storage/hsm.py
1 file changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/1097/1
--
To view, visit http://gerrit.ovirt.org/1097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ790014 Fix multiple issues in detachSD
......................................................................
BZ790014 Fix multiple issues in detachSD
In this patch:
* Remove __unmountLastMaster, the manager cannot deactivate the master
storage domain (where the SPM resource is hold)
* Move all the checks related to the master migration inside masterMigrate
* detachSD cannot be used to migrate a master and it can be used only on
domains that are inactive
Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
---
M vdsm/storage/sp.py
1 file changed, 34 insertions(+), 58 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/1876/1
--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Ayal Baron has posted comments on this change.
Change subject: Refactor upgrade process to facilitate repository format conversions
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(11 inline comments)
....................................................
File vdsm/storage/repositoryConverter.py
Line 3: CFEAT_LIVE_UPGRADE = "live upgrade"
cfeat?
Line 5: def convert_LegacyVersionUpgrade(domain, targetFormat):
why underscore?
Line 9: return (currentFormat, tagetFormat) in CONVERTERS
%s/taget/target/g
Line 16: _getConverter(currentFormat, targetFormat)
why both this and conversionAvailable?
....................................................
File vdsm/storage/sdc.py
Line 39: """ Used so we can change domain objects (convert format) on the fly
s/.*/Keeps domain references valid even when underlying domain object changes (due to format conversion for example)./
Line 46: #FIXME : this objects holding callbacks will not be updated
s/this//
Line 47: # this is currently not needed but fix in case it does
s/does/is/
....................................................
File vdsm/storage/sd.py
Line 143: if version not in (0, 2):
why not SUPPORTED_DOMAIN_FORMATS?
Line 621: def getFormat(self):
why keep 'getVersion'? int/str semantics?
....................................................
File vdsm/storage/sp.py
Line 195: self._convertMemberDomain(domain, targetPoolVersion)
I'm assuming that if "currDomVersion > targetPoolVersion" then there will be no converter available?
Line 415: if not repositoryConverter.canConvert(domainFormat, targetDomainFormat):
why aren't these validations inside repositoryConverter.convert?
--
To view, visit http://gerrit.ovirt.org/193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b036d244f3cf5b0adda129b44be5cff473dc9b7
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Ayal Baron has posted comments on this change.
Change subject: Extracted image related functinality to another class
......................................................................
Patch Set 19: Looks good to me, approved
Approving assuming:
1. You made no changes in the code you transferred from sp.py to the new module
2. You will fix the unsecured issue
--
To view, visit http://gerrit.ovirt.org/191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: Clean libvirt networks if bridge not exists
......................................................................
Clean libvirt networks if bridge not exists
Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5
---
M vdsm/clientIF.py
M vdsm/configNetwork.py
M vdsm/netinfo.py
3 files changed, 55 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/1990/1
--
To view, visit http://gerrit.ovirt.org/1990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Ewoud Kohl van Wijngaarden has uploaded a new change for review.
Change subject: Flip execCmd default to sudo=False
......................................................................
Flip execCmd default to sudo=False
Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
---
M vdsm/guestIF.py
M vdsm/libvirtvm.py
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
M vdsm/storage/safelease.py
M vdsm/supervdsm.py
10 files changed, 50 insertions(+), 41 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/1926/1
--
To view, visit http://gerrit.ovirt.org/1926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Adam Litke has uploaded a new change for review.
Change subject: storagePool: Reject unknown method in uploadVolume
......................................................................
storagePool: Reject unknown method in uploadVolume
Address a previously identified TODO in the code and report an error if a method
other than 'wget' or 'rsync' is specified.
Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/671/1
--
To view, visit http://gerrit.ovirt.org/671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Ewoud Kohl van Wijngaarden has uploaded a new change for review.
Change subject: Add myself to the authors list
......................................................................
Add myself to the authors list
Change-Id: I24f20324698af0323c166464a8fa2588b6227f4b
---
M AUTHORS
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/1937/1
--
To view, visit http://gerrit.ovirt.org/1937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24f20324698af0323c166464a8fa2588b6227f4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Igor Lvovsky has uploaded a new change for review.
Change subject: Allow drive devices without indices
......................................................................
Allow drive devices without indices
Change-Id: I28fdec0d1d924cfb97619d0dd40c76b59988948f
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 32 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/1934/1
--
To view, visit http://gerrit.ovirt.org/1934
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28fdec0d1d924cfb97619d0dd40c76b59988948f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: configNet: drop local reimpl of utils.tobool
......................................................................
configNet: drop local reimpl of utils.tobool
Change-Id: I3f461b92a6597b668d418c006285b40517fe6af9
---
M vdsm/configNetwork.py
1 file changed, 3 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/1864/1
--
To view, visit http://gerrit.ovirt.org/1864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f461b92a6597b668d418c006285b40517fe6af9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Move dumpStorageTable from vdsm_cli to vdsm
......................................................................
Move dumpStorageTable from vdsm_cli to vdsm
The dumpStorageTable.py script is used by the sos plugin shipped with
vdsm.
Change-Id: Ic9dfdc283fc13af7841ee31566b1453aa9c2efd2
---
M .gitignore
M vdsm.spec.in
M vdsm/Makefile.am
R vdsm/dumpStorageTable.py.in
M vdsm_cli/Makefile.am
5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/1889/1
--
To view, visit http://gerrit.ovirt.org/1889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9dfdc283fc13af7841ee31566b1453aa9c2efd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: VDSMBRIDGE doesn't need a special expansion
......................................................................
VDSMBRIDGE doesn't need a special expansion
Change-Id: I4cf3d31357a61beabbcdea141cb815a108fa3f2a
---
M build-aux/Makefile.subs
M configure.ac
M vdsm_reg/deployUtil.py.in
3 files changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/1888/1
--
To view, visit http://gerrit.ovirt.org/1888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cf3d31357a61beabbcdea141cb815a108fa3f2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Eduardo has uploaded a new change for review.
Change subject: FIX spmStop security issue.
......................................................................
FIX spmStop security issue.
SPM_ID pool key is wrote after we are not SPM anymore.
(By design.)
Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/1866/1
--
To view, visit http://gerrit.ovirt.org/1866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I641c2f249e21d02ca790b5bbda16943967e3a557
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Log exceptions when calling irs functions from XMLRPC
......................................................................
Log exceptions when calling irs functions from XMLRPC
An earlier change I made introduced a bug in API.py that triggered an exception
when calling the 'getDeviceList' XMLRPC call. Unfortunately the server-side
exception was not logged anywhere (which made debugging more difficult). This
patch adds exception logging for irs methods (note: wrapApiMethod already does
this for the other calls).
Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/1575/1
--
To view, visit http://gerrit.ovirt.org/1575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd560d3b110c91f5019c5a6af477926a1fbf1996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Eduardo has uploaded a new change for review.
Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................
Revert "Fix getMasterDomain masterVersion handling"
This reverts commit ce280b09c776b33203847dc7e7ad77ee90a34bc0.
masterVersion is an exclusive property of RHEV-m.
There are no RHEV-M flows that not send the expected version.
All VDSM flows should have an expected version.
Towards a masterVersion (>0) meaning a master domain and
removing redundant metadata fields as isMaster, etc.
Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/955/1
--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: added mtu support for network interface
......................................................................
added mtu support for network interface
Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
---
M vdsm/configNetwork.py
1 file changed, 107 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/754/1
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gal Hammer has uploaded a new change for review.
Change subject: Added an option to create a balloon device on VM creation.
......................................................................
Added an option to create a balloon device on VM creation.
The "balloonEnabled" parameter allow to create a guest with
a virtual memory balloon device attached.
Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5
---
M vdsm/libvirtvm.py
M vdsm_cli/vdsClient.py
2 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/1573/1
--
To view, visit http://gerrit.ovirt.org/1573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie25eec67f852a4e0eedf96cf6da4094dab3386c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: [WIP] Adding flowID
......................................................................
[WIP] Adding flowID
This patch will implement the flowID schema. The idea is provide a
mechanism to identify the transactions between ovirt engine and vdsm.
Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
---
M vdsm/clientIF.py
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/1221/1
--
To view, visit http://gerrit.ovirt.org/1221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: addNetwork in BindingXMLRPC is not forwarding options
......................................................................
addNetwork in BindingXMLRPC is not forwarding options
Change-Id: I70e54f07acb9607920623909d0128be0903a88ea
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/1832/1
--
To view, visit http://gerrit.ovirt.org/1832
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70e54f07acb9607920623909d0128be0903a88ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................
NIC model should be converted from 'pv' to 'virtio'
Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/1732/1
--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#785717 caps: cpuCores should report only physical cores
......................................................................
BZ#785717 caps: cpuCores should report only physical cores
CPU Hyper-Thread shows up as a processor in /proc/cpuinfo, but does not amount
to a physical core.
Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528
---
M vdsm/caps.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/1737/1
--
To view, visit http://gerrit.ovirt.org/1737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b28d0f7864a351778c56048cb1233ed58807528
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: BindingXMLRPC: Initialize s.lastClient as IP
......................................................................
BindingXMLRPC: Initialize s.lastClient as IP
Fix the error: illegal IP address string passed to inet_aton
Change-Id: Ie370ecec0a2ff35a908bcfb5d915ad374b6187d7
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/1726/1
--
To view, visit http://gerrit.ovirt.org/1726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie370ecec0a2ff35a908bcfb5d915ad374b6187d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Adam Litke is an AUTHOR
......................................................................
Adam Litke is an AUTHOR
Change-Id: Iff795abc4626844f75b1a822adcf3563a3c05fd0
---
M AUTHORS
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/1609/1
--
To view, visit http://gerrit.ovirt.org/1609
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff795abc4626844f75b1a822adcf3563a3c05fd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: BZ#787722 - Make the spm internal lock an RLock
......................................................................
BZ#787722 - Make the spm internal lock an RLock
This will prevent the object from deadlocking itself when moving between
protected areas in related methdos.
Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/1683/1
--
To view, visit http://gerrit.ovirt.org/1683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I988553b849b40ca9fe5f3168a3cf75950af4fe14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Mark Wu has uploaded a new change for review.
Change subject: Fix another mac address comparison issue caused by letter case.
......................................................................
Fix another mac address comparison issue caused by letter case.
Change-Id: I5f45e2698d929e59f5d5d78b6ca12cb6b8eba445
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/1696/1
--
To view, visit http://gerrit.ovirt.org/1696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f45e2698d929e59f5d5d78b6ca12cb6b8eba445
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: have an empty lastClient on xmlrpc startup
......................................................................
have an empty lastClient on xmlrpc startup
Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba
---
M vdsm/BindingXMLRPC.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/1637/1
--
To view, visit http://gerrit.ovirt.org/1637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Escape underscore as well
......................................................................
Escape underscore as well
This prevent collision between 'hello/world' and 'hello_world'
Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
---
M vdsm/storage/storageProviderConnectionMonitor.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/1245/1
--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Implement an API call to retrieve storage connection state
......................................................................
[WIP] Implement an API call to retrieve storage connection state
Change-Id: Ife9b5a6db4a1c0c73b6d6dc079876d195a15c9fa
---
M vdsm/storage/hsm.py
M vdsm/storage/storageProviderConnectionMonitor.py
2 files changed, 241 insertions(+), 46 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1250/1
--
To view, visit http://gerrit.ovirt.org/1250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife9b5a6db4a1c0c73b6d6dc079876d195a15c9fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Add __hash__() to all connection classes
......................................................................
Add __hash__() to all connection classes
Without it connections can't be keys of dicts
Change-Id: I56e5e2e53a60d50d88efc1a5540bf2136a6a81b6
---
M vdsm/storage/mount.py
M vdsm/storage/storageProviderConnectionMonitor.py
2 files changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/1246/1
--
To view, visit http://gerrit.ovirt.org/1246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56e5e2e53a60d50d88efc1a5540bf2136a6a81b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Have wait return the value of the event
......................................................................
Have wait return the value of the event
Change-Id: I6ef5fb239be47714e0cebf4ce5c0ebf790384b79
---
M vdsm/storage/sync.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/1247/1
--
To view, visit http://gerrit.ovirt.org/1247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ef5fb239be47714e0cebf4ce5c0ebf790384b79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Split getSessionInfo() out of getdeviScsiInfo()
......................................................................
Split getSessionInfo() out of getdeviScsiInfo()
The original call is doing both things and a function should only do 1.
This patch also makes the result a namedtuple instead of a regular tuple
that is easier to handle programatically and converts all values to the
appropriate types.
Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451
---
M vdsm/storage/iscsi.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
3 files changed, 63 insertions(+), 29 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/1096/1
--
To view, visit http://gerrit.ovirt.org/1096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Don't resolve hostnames for iscsi connection.
......................................................................
Don't resolve hostnames for iscsi connection.
The new storage provider connection subsystem can handle using hostnames
even though iscsid will resolve the hostname and report it as IP.
We should let the underlying layers handle it. Even though it will make
multiplathing act weird we shouldn't resolve the hostname ourselves as
it might interfere with some HA\Load balancing solution.
Change-Id: Ia13666d8f5dff01c2114df8195fcfb2369cc6eb2
---
M vdsm/storage/iscsi.py
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/1099/1
--
To view, visit http://gerrit.ovirt.org/1099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia13666d8f5dff01c2114df8195fcfb2369cc6eb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Serialize iscsiadm calls
......................................................................
Serialize iscsiadm calls
iscsiadm doesn't really support multiple call espescially to the same
resource. This will serialize all the calls to iscsiadm and prevent
issuse from multiple iscsi connections being issued at once.
Change-Id: I751abfd0c2ba20310d63dd569132e723ed06f687
---
M vdsm/storage/iscsi.py
1 file changed, 24 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/1249/1
--
To view, visit http://gerrit.ovirt.org/1249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I751abfd0c2ba20310d63dd569132e723ed06f687
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Persist active storage provider connections
......................................................................
Persist active storage provider connections
In order for VDSM to gracefully handle restarts it should make sure all
connections it was asked to manage before the crash are continued to be
managed when it goes up.
Note that there is no reconnection logic yet.
Change-Id: I91f29671e87e76765bc86907fb2d03318861d045
---
M vdsm/storage/hsm.py
M vdsm/storage/storageProviderConnectionMonitor.py
2 files changed, 59 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/1116/1
--
To view, visit http://gerrit.ovirt.org/1116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91f29671e87e76765bc86907fb2d03318861d045
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Fix typo in xmlrpc bindings registration
......................................................................
Fix typo in xmlrpc bindings registration
Fix a typo in the xmlrpc binding that was causing the mergeSnapshots command to
be misnamed.
Change-Id: I3ce9ded80ade2807851a178bd0157d18df60cf7d
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/1687/1
--
To view, visit http://gerrit.ovirt.org/1687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ce9ded80ade2807851a178bd0157d18df60cf7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Haim Ateya has uploaded a new change for review.
Change subject: BZ#787594 - set securityOverride=True for unsecured function trying to write to metadata in forceFreeSpm flow
......................................................................
BZ#787594 - set securityOverride=True for unsecured function trying to
write to metadata in forceFreeSpm flow
Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/1642/1
--
To view, visit http://gerrit.ovirt.org/1642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c438f0ef4029373f1b118e0b39440478814abfd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: contrib: Adding contrib/nfs-check.py
......................................................................
contrib: Adding contrib/nfs-check.py
nfs-check is a python script to validate nfs targets.
Currently, nfs-check mount the nfs target, create a file and read it from
the mountpoint. If somethings goes wrong it will throw the error message.
Usage: nfs-check.py [OPTIONS]
--server NFS server (REQUIRED)
--target NFS target (REQUIRED)
--local Local mountpoint (REQUIRED)
--opts NFS options (OPTIONAL)
--version List version release
--help This help menu
Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Example:
1) nfs-check.py --server 192.168.1.103 --target /nfs/storage --local /mnt
2) nfs-check.py --server 192.168.1.103 --target /nfs/storage --local /mnt --opts soft
---
A contrib/nfs-check.py
1 file changed, 157 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/916/1
--
To view, visit http://gerrit.ovirt.org/916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#773371 call `vdsmd reconfigure` after bootstrap
......................................................................
BZ#773371 call `vdsmd reconfigure` after bootstrap
If installation change ssl from False to True and added valid
certificates, we need to reconfigure vdsm to use it.
This was done by the "reconfigure" verb for our SysV daemon, but
unsupported by systemd.
This patch is an ugly hack for an oVirt release, until we have a proper
vdsm-tool for these purposes.
Change-Id: Ide0b9c1fb86c8d7bcea54d1ba8c8d9a7598af733
---
M vdsm_reg/deployUtil.py.in
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/1360/1
--
To view, visit http://gerrit.ovirt.org/1360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide0b9c1fb86c8d7bcea54d1ba8c8d9a7598af733
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED
......................................................................
BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED
Network devices created by Vdsm should ask to be controlled by
NetworkManager. Particularly when NM does not support controlling them
(bridge device).
Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
---
M vdsm_reg/deployUtil.py.in
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/1370/1
--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: promisc hook: release monitor traffic on before_vm_destory
......................................................................
promisc hook: release monitor traffic on before_vm_destory
after_vm_destroy is too late to release tc monitor traffic,
moving the event to before_vm_destroy event.
Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7
---
M vdsm.spec.in
M vdsm_hooks/promisc/Makefile.am
R vdsm_hooks/promisc/before_vm_destroy.py
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/1581/1
--
To view, visit http://gerrit.ovirt.org/1581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80c4d688668e299c1eee4a4a9fbfb00ced9ccbd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add hotPlug/hotUnplug NIC feature
......................................................................
Add hotPlug/hotUnplug NIC feature
Change-Id: Iecd56650308f5836913f513fffc179f39fc8f6cc
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/define.py
M vdsm/libvirtvm.py
4 files changed, 118 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/1388/1
--
To view, visit http://gerrit.ovirt.org/1388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd56650308f5836913f513fffc179f39fc8f6cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Fix two regressions introduced by the API.py refactoring
......................................................................
Fix two regressions introduced by the API.py refactoring
The recovery code is left a serious need of refactoring. At least it is
working now.
Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6
---
M vdsm/BindingXMLRPC.py
M vdsm/clientIF.py
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/1610/1
--
To view, visit http://gerrit.ovirt.org/1610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I466c544809262b5dfea4b982aacc400b7e100ac6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: BindingXMLRPC: wrapper - fix __name__
......................................................................
BindingXMLRPC: wrapper - fix __name__
- list now is getVMList
- getVdsStats now is getStats
- desktopLogin now is vmDesktopLogin
Change-Id: If8c50d1128ba404319ba1c0d1b09264d4fd2f234
---
M vdsm/BindingXMLRPC.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/1579/1
--
To view, visit http://gerrit.ovirt.org/1579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8c50d1128ba404319ba1c0d1b09264d4fd2f234
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Excluding some VM commands on migration
......................................................................
Excluding some VM commands on migration
Some operations are not permitted during a live migration:
* take a live snapshot
* hotplug/hotunplug a disk device
Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
---
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/1389/1
--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Minor code refactoring during domXml parsing
......................................................................
Minor code refactoring during domXml parsing
Change-Id: Ia3fbf8beed2cce3317ff711b39c24ddf6bffaab9
---
M vdsm/libvirtvm.py
1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/1365/1
--
To view, visit http://gerrit.ovirt.org/1365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3fbf8beed2cce3317ff711b39c24ddf6bffaab9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Log exceptions when calling irs functions from the XMLRPC Bindings
......................................................................
Log exceptions when calling irs functions from the XMLRPC Bindings
An earlier change I made introduced a bug in API.py that triggered an exception
when calling the 'getDeviceList' XMLRPC call. Unfortunately the server-side
exception was not logged anywhere (which made debugging more difficult). This
patch adds exception logging for irs methods (note: wrapApiMethod already do
this for the other calls).
Change-Id: I4cd630d112ede4aaf2299154209e0abf2a42691f
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/1574/1
--
To view, visit http://gerrit.ovirt.org/1574
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cd630d112ede4aaf2299154209e0abf2a42691f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Replace SPM domain locks with SANLock
......................................................................
Replace SPM domain locks with SANLock
Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
---
M configure.ac
M vdsm.spec.in
M vdsm/constants.py.in.in
M vdsm/storage/blockSD.py
M vdsm/storage/safelease.py
M vdsm/storage/sd.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
M vdsm/vdsmd.init.in
9 files changed, 167 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/726/1
--
To view, visit http://gerrit.ovirt.org/726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>