February 2012 - vdsm-patches - Fedora mailing-lists

Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.
by ewarszaw＠redhat.com 21 Jul '14

21 Jul '14

Eduardo has uploaded a new change for review. Change subject: [WIP] Towards a more (block) secure HSM. ...................................................................... [WIP] Towards a more (block) secure HSM. Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d --- M vdsm/storage/hsm.py M vdsm/storage/lvm.py M vdsm/storage/sp.py 3 files changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/2218/1 -- To view, visit http://gerrit.ovirt.org/2218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

6 28

Change in vdsm[master]: [WIP] Small objects repository file implementation
by Federico Simoncelli 19 May '14

19 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Small objects repository file implementation ...................................................................... [WIP] Small objects repository file implementation Change-Id: I3003f8652a58c68a966bc37e591c1d1d2308c164 --- M vdsm/storage/fileSD.py M vdsm/storage/hsm.py M vdsm/storage/outOfProcess.py M vdsm/storage/sd.py M vdsm/storage/sp.py M vdsm_cli/vdsClient.py 6 files changed, 83 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/242/1 -- To view, visit http://gerrit.ovirt.org/242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3003f8652a58c68a966bc37e591c1d1d2308c164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: Add a chown implementation that looks up uid and gid
by Federico Simoncelli 19 May '14

19 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: Add a chown implementation that looks up uid and gid ...................................................................... Add a chown implementation that looks up uid and gid We already have a case in vdsm (configNetwork) where we need to use a chown function that is capable to convert the owner and group names to uid and gid. Going forward this can be reused for the deployment utilities and to prepare the paths needed by vdsm (eg: /rhev and /var/run/vdsm). Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555 --- M vdsm/configNetwork.py M vdsm/utils.py 2 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/387/1 -- To view, visit http://gerrit.ovirt.org/387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 6

Change in vdsm[master]: More safe startSpm().
by ewarszaw＠redhat.com 19 May '14

19 May '14

Eduardo has uploaded a new change for review. Change subject: More safe startSpm(). ...................................................................... More safe startSpm(). Change-Id: I1e6b32bdf1dd8dc36f6633306d4edef89d542e31 --- M vdsm/storage/sp.py 1 file changed, 16 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/451/1 -- To view, visit http://gerrit.ovirt.org/451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e6b32bdf1dd8dc36f6633306d4edef89d542e31 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

3 4

Change in vdsm[master]: [WIP] Add the base commands to vdsm-tool
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the base commands to vdsm-tool ...................................................................... [WIP] Add the base commands to vdsm-tool Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e --- M vdsm-tool/Makefile.am A vdsm-tool/base.py M vdsm.spec.in 3 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/388/1 -- To view, visit http://gerrit.ovirt.org/388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: [WIP] Add the daemon commands to vdsm-tool
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the daemon commands to vdsm-tool ...................................................................... [WIP] Add the daemon commands to vdsm-tool Change-Id: Ieafb9886f3ffb2433478203186dd94005b2a51e8 --- M vdsm-tool/Makefile.am A vdsm-tool/daemon.py M vdsm.spec.in 3 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/389/1 -- To view, visit http://gerrit.ovirt.org/389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieafb9886f3ffb2433478203186dd94005b2a51e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ...................................................................... BZ#752470 Related: Don't use SIGTERM in spmprotect.sh Attempting to stop the SPM (SIGUSR1) and using SIGKILL if that fails is already enough. In any case giving vdsm only 2 seconds between SIGTERM and SIGKILL was a too short timeout to hope in a restart. Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 --- M vdsm/storage/protect/spmprotect.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/265/1 -- To view, visit http://gerrit.ovirt.org/265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 4

Change in vdsm[master]: Added a support for a guest hibernate command.
by ghammer＠redhat.com 28 Apr '14

28 Apr '14

Gal Hammer has uploaded a new change for review. Change subject: Added a support for a guest hibernate command. ...................................................................... Added a support for a guest hibernate command. Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737 --- M vdsm/clientIF.py M vdsm/guestIF.py M vdsm_cli/vdsClient.py 3 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/1121/1 -- To view, visit http://gerrit.ovirt.org/1121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>

14 64

Change in vdsm[master]: Remove unnecesary preparePaths.
by ewarszaw＠redhat.com 28 Apr '14

28 Apr '14

Eduardo has uploaded a new change for review. Change subject: Remove unnecesary preparePaths. ...................................................................... Remove unnecesary preparePaths. Recovering running VM's therefore paths are already prepared. Prepare paths is not locking the volumes anymore (Federico). Change-Id: I35890d36227633ca147387d670c152b9be357e50 --- M vdsm/clientIF.py 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/786/1 -- To view, visit http://gerrit.ovirt.org/786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35890d36227633ca147387d670c152b9be357e50 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

7 8

Change in vdsm[master]: Avoid template deactivation and lock.
by ewarszaw＠redhat.com 28 Apr '14

28 Apr '14

Eduardo has uploaded a new change for review. Change subject: Avoid template deactivation and lock. ...................................................................... Avoid template deactivation and lock. Change-Id: Ieedf863ac967f34405f038201bac324c52fbbe89 --- M vdsm/storage/blockVolume.py M vdsm/storage/volume.py 2 files changed, 39 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/863/1 -- To view, visit http://gerrit.ovirt.org/863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieedf863ac967f34405f038201bac324c52fbbe89 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

6 9

Change in vdsm[master]: Don't rotate core dump logs on Fedora
by Federico Simoncelli 01 Mar '13

01 Mar '13

Federico Simoncelli has uploaded a new change for review. Change subject: Don't rotate core dump logs on Fedora ...................................................................... Don't rotate core dump logs on Fedora Core dumps are a system-level configuration and VDSM shouldn't try to override what the sysadmin decides. Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 --- M configure.ac M vdsm.spec.in M vdsm/Makefile.am A vdsm/cdumps-logrotate.conf A vdsm/vdsm-logrotate.conf D vdsm/vdsm-logrotate.conf.in 6 files changed, 27 insertions(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/991/1 -- To view, visit http://gerrit.ovirt.org/991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 3

Change in vdsm[master]: [WIP] Use sanlock offset when present
by Federico Simoncelli 24 Aug '12

24 Aug '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Use sanlock offset when present ...................................................................... [WIP] Use sanlock offset when present Change-Id: I27195f29efa691aadda0cac5afef55b04cc01658 --- M vdsm/storage/blockSD.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/2129/1 -- To view, visit http://gerrit.ovirt.org/2129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27195f29efa691aadda0cac5afef55b04cc01658 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 4

Change in vdsm[master]: Support the quiesce flag during a live snapshot
by Federico Simoncelli 13 Aug '12

13 Aug '12

Federico Simoncelli has uploaded a new change for review. Change subject: Support the quiesce flag during a live snapshot ...................................................................... Support the quiesce flag during a live snapshot Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d --- M vdsm.spec.in M vdsm/libvirtvm.py 2 files changed, 38 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/2223/1 -- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

5 12

Change in vdsm[master]: [WIP] MOM Integration
by wudxw＠linux.vnet.ibm.com 06 Aug '12

06 Aug '12

Mark Wu has uploaded a new change for review. Change subject: [WIP] MOM Integration ...................................................................... [WIP] MOM Integration This patch tries to integrate MOM with vdsm. For the descprition of how this patch works, please see Adam's mail: https://fedorahosted.org/pipermail/vdsm-devel/2012-February/000628.html Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f --- M vdsm.spec.in M vdsm/API.py M vdsm/Makefile.am M vdsm/clientIF.py M vdsm/config.py.in M vdsm/ksm.py M vdsm/libvirtvm.py A vdsm/mom.conf A vdsm/mom.policy M vdsm/supervdsmServer.py A vdsm/vdsMOM.py M vdsm/vm.py 12 files changed, 271 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/2367/1 -- To view, visit http://gerrit.ovirt.org/2367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>

6 36

Change in vdsm[master]: enable attaching non-vlan network to vlanable network.
by shavivi＠redhat.com 08 Jul '12

08 Jul '12

Shahar Havivi has uploaded a new change for review. Change subject: enable attaching non-vlan network to vlanable network. ...................................................................... enable attaching non-vlan network to vlanable network. this patch have a security breach: when adding a network without a vlan to already attach vlan network this network can monitor all the traffic of the other vlans. we may be able to restrict it using ebtables. Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6 --- M vdsm/configNetwork.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/2161/1 -- To view, visit http://gerrit.ovirt.org/2161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb96ead734cb1394ff00a99bf7f62b77ad15f1d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>

2 5

Change in vdsm[master]: Revert "BZ#708779 - Avoid pools with mixed domain versions"
by Dan Kenigsberg 23 Jun '12

23 Jun '12

Dan Kenigsberg has uploaded a new change for review. Change subject: Revert "BZ#708779 - Avoid pools with mixed domain versions" ...................................................................... Revert "BZ#708779 - Avoid pools with mixed domain versions" This reverts commit 017db3b2740a8c7d22c5366c70600eb47643e8ab. We would like to allow upgrading a storage pool to new 3.0 format, and to allow upgrading 2.2 domains automatically when they are attached to a 3.0-formatted pool. Conflicts: vdsm/storage/hsm.py vdsm/storage/sp.py Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018 --- M vdsm/storage/hsm.py M vdsm/storage/sp.py M vdsm/storage/storage_exception.py 3 files changed, 12 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/753/1 -- To view, visit http://gerrit.ovirt.org/753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

2 2

[NEW PATCH] Change getChain() to return dictionary with chain itself and its template. (via gerrit-bot)
by Igor Lvovsky 24 May '12

24 May '12

New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/692 commit 3a09f874889cb372ee84b04a234f7b653458e26f Author: Igor Lvovsky <ilvovsky(a)redhat.com> Date: Tue Jul 12 15:18:45 2011 +0300 Change getChain() to return dictionary with chain itself and its template. This change will avoid unneeded produceVolume and improve behaviour of different flows. Change-Id: Ife46d592171aedea087e0d6462b735cd7e0d75e0 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 1c70a34..102ea6c 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -104,7 +104,7 @@ class Image: # 1. Remove template's image: Create 'fake' template instead of deleted one # 2. Remove regular image: Remove parent-'fake' template if nobody need it already try: - pvol = self.getTemplate(sdUUID=sdUUID, imgUUID=imgUUID) + pvol = self.getChain(sdUUID, imgUUID)['template'] # 1. If we required to delete template's image that have VMs # based on it, we should create similar 'fake' template instead if pvol: @@ -269,17 +269,16 @@ class Image: return newImgUUID - def __chainSizeCalc(self, sdUUID, imgUUID, volUUID, size): + def __chainSizeCalc(self, sdUUID, imgUUID, size): """ Compute an estimate of the whole chain size using the sum of the actual size of the chain's volumes """ - chain = self.getChain(sdUUID, imgUUID, volUUID) + chainDict = self.getChain(sdUUID, imgUUID) newsize = 0 - template = chain[0].getParentVolume() - if template: - newsize = template.getVolumeSize() - for vol in chain: + if chainDict['template']: + newsize = chainDict['template'].getVolumeSize() + for vol in chainDict['chain']: newsize += vol.getVolumeSize() if newsize > size: newsize = size @@ -301,12 +300,14 @@ class Image: newsize = int(newsize * 1.1) # allocate %10 more for cow metadata return newsize - def getChain(self, sdUUID, imgUUID, volUUID=None): + def getChain(self, sdUUID, imgUUID): """ - Return the chain of volumes of image as a sorted list - (not including a shared base (template) if any) + Return the dictionary with chain of volumes of image as a sorted list + (not including a shared base (template)) and the template if any """ - chain = [] + # 'chain' - chain of volumes of image as a sorted list + # 'template' - shared base (template) if any + chainDict = {'chain':[], 'template':None} # Find all volumes of image volclass = SDF.produce(sdUUID).getVolumeClass() uuidlist = volclass.getImageVolumes(self.repoPath, sdUUID, imgUUID) @@ -316,14 +317,13 @@ class Image: srcVol = volclass(self.repoPath, sdUUID, imgUUID, uuidlist[0]) # For template image include only one volume (template itself) if len(uuidlist) == 1 and srcVol.isShared(): - return [srcVol] + return {'chain':[srcVol], 'template':srcVol} # find the leaf for vol in uuidlist: srcVol = volclass(self.repoPath, sdUUID, imgUUID, vol) if srcVol.isLeaf(): - if not volUUID or volUUID == srcVol.volUUID: - break + break srcVol = None if not srcVol: @@ -332,38 +332,25 @@ class Image: # Build up the sorted (parent->child) chain while not srcVol.isShared(): - chain.insert(0, srcVol) + chainDict['chain'].insert(0, srcVol) if srcVol.getParent() == volume.BLANK_UUID: break srcVol = srcVol.getParentVolume() - self.log.info("sdUUID=%s imgUUID=%s chain=%s ", sdUUID, imgUUID, str(chain)) - return chain + if srcVol.isShared(): + chainDict['template'] = srcVol - def getTemplate(self, sdUUID, imgUUID): - """ - Return template of the image - """ - tmpl = None - # Find all volumes of image (excluding template) - chain = self.getChain(sdUUID, imgUUID) - # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() - if pvol: - tmpl = pvol - elif chain[0].isShared(): - tmpl = chain[0] - - return tmpl + self.log.info("sdUUID=%s imgUUID=%s chainDict=%s ", sdUUID, imgUUID, str(chainDict)) + return chainDict def validate(self, srcSdUUID, dstSdUUID, imgUUID, op=MOVE_OP): """ Validate template on destination domain """ - # Find all volumes of source image - chain = self.getChain(srcSdUUID, imgUUID) - leafVol = chain[-1] srcDom = SDF.produce(srcSdUUID) + # Find all volumes of source image + chainDict = self.getChain(srcSdUUID, imgUUID) + leafVol = chainDict['chain'][-1] # Avoid move template's image if there is a VM based on it (except 'Backup' domain) if op == MOVE_OP and leafVol.isShared() and not srcDom.isBackup(): chList = leafVol.getAllChildrenList(self.repoPath, srcSdUUID, imgUUID, leafVol.volUUID) @@ -371,18 +358,16 @@ class Image: raise se.MoveTemplateImageError(imgUUID) # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() + pvol = chainDict['template'] if pvol: # this is a shared template based chain - if not pvol.isShared(): - raise se.ImageIsNotLegalChain("Base image parent vol %s is not shared" % pvol.volUUID) pimg = pvol.getImage() # pimg == template image try: volclass = SDF.produce(dstSdUUID).getVolumeClass() # Validate that the destination template exists and accessible volclass(self.repoPath, dstSdUUID, pimg, pvol.volUUID) - except se.StorageException, e: - self.log.error("Unexpected error", exc_info=True) - raise se.CouldNotValideTemplateOnTargetDomain("Template %s Destination domain %s: %s" % (pimg, dstSdUUID, str(e))) + except se.StorageException: + self.log.error("Cannot validate template %s on target domain %s", pimg, dstSdUUID, exc_info=True) + raise se.CouldNotValideTemplateOnTargetDomain() def __templateRelink(self, destDom, imgUUID, volUUID): """ @@ -473,20 +458,15 @@ class Image: def _createTargetImage(self, destDom, srcSdUUID, imgUUID): # Before actual data copying we need perform several operation # such as: create all volumes, create fake template if needed, ... - try: - # Find all volumes of source image - srcChain = self.getChain(srcSdUUID, imgUUID) - except se.StorageException: - self.log.error("Unexpected error", exc_info=True) - raise - except Exception, e: - self.log.error("Unexpected error", exc_info=True) - raise se.SourceImageActionError(imgUUID, srcSdUUID, str(e)) + + # Find all volumes of source image + srcChainDict = self.getChain(srcSdUUID, imgUUID) + srcChain = srcChainDict['chain'] fakeTemplate = False pimg = volume.BLANK_UUID # standalone chain # check if the chain is build above a template, or it is a standalone - pvol = srcChain[0].getParentVolume() + pvol = srcChainDict['template'] if pvol: # find out parent volume parameters volParams = pvol.getVolumeParams() @@ -686,11 +666,9 @@ class Image: """ if not self.isLegal(sdUUID, imgUUID): raise se.ImageIsNotLegalChain(imgUUID) - chain = self.getChain(sdUUID, imgUUID) - # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() - if pvol: - if not pvol.isLegal() or pvol.isFake(): + chainDict = self.getChain(sdUUID, imgUUID) + if chainDict['template']: + if not chainDict['template'].isLegal() or chainDict['template'].isFake(): raise se.ImageIsNotLegalChain(imgUUID) def copy(self, sdUUID, vmUUID, srcImgUUID, srcVolUUID, dstImgUUID, dstVolUUID, @@ -735,8 +713,7 @@ class Image: # using the sum of the actual size of the chain's volumes if volParams['volFormat'] != volume.COW_FORMAT or volParams['prealloc'] != volume.SPARSE_VOL: raise se.IncorrectFormat(self) - volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID, - srcVolUUID, volParams['size']) + volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID, volParams['size']) # Find out dest volume parameters if preallocate in [volume.PREALLOCATED_VOL, volume.SPARSE_VOL]: diff --git a/vdsm/storage/resourceFactories.py b/vdsm/storage/resourceFactories.py index ce3ec70..07df0f0 100644 --- a/vdsm/storage/resourceFactories.py +++ b/vdsm/storage/resourceFactories.py @@ -106,20 +106,18 @@ class ImageResourceFactory(rm.SimpleResourceFactory): # Get the list of the volumes repoPath = os.path.join(self.storage_repository, dom.getPools()[0]) try: - chain = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName) + chainDict = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName) + chain = chainDict['chain'] except se.ImageDoesNotExistInSD: log.debug("Image %s does not exist in domain %s", resourceName, self.sdUUID) return [] - # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() - if pvol: - template = pvol.volUUID - elif chain[0].isShared(): - # Image of template itself, - # with no other volumes in chain - template = chain[0].volUUID - del chain[:] + # Image of template itself, + # with no other volumes in chain + if chainDict['template']: + template = chainDict['template'].volUUID + if chainDict['template'] in chain: + del chain[:] volUUIDChain = [vol.volUUID for vol in chain] volUUIDChain.sort()

4 5

Change in vdsm[master]: bootstrapping: avoid usage of tmp folder
by dfediuck＠redhat.com 22 May '12

22 May '12

Doron Fediuck has uploaded a new change for review. Change subject: bootstrapping: avoid usage of tmp folder ...................................................................... bootstrapping: avoid usage of tmp folder This patch changes hard-coded tmp path elements, so the scripts may be used from a different location. Once invoked by the engine-core from an ad-hoc folder, the bootstrapping scripts should support working on that folder. This is mainly referring to imports, certificate files and log files. Change-Id: I1b5df6dd0b5ff0bdf648cd74d160384b86e5bbf7 --- M vds_bootstrap/vds_bootstrap.py M vds_bootstrap/vds_bootstrap_complete.py M vdsm_reg/deployUtil.py.in 3 files changed, 35 insertions(+), 32 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/2277/1 -- To view, visit http://gerrit.ovirt.org/2277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b5df6dd0b5ff0bdf648cd74d160384b86e5bbf7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck <dfediuck(a)redhat.com>

5 10

Change in vdsm[master]: Add the REST API bindings
by agl＠us.ibm.com 14 May '12

14 May '12

Adam Litke has uploaded a new change for review. Change subject: Add the REST API bindings ...................................................................... Add the REST API bindings Conflicts: vdsm/clientIF.py Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56 --- M configure.ac M vdsm.spec.in M vdsm/BindingXMLRPC.py M vdsm/Makefile.am M vdsm/clientIF.py M vdsm/config.py.in A vdsm/rest/BindingREST.py A vdsm/rest/Controller.py A vdsm/rest/Dispatcher.py A vdsm/rest/Makefile.am A vdsm/rest/Store/LocalDB.py A vdsm/rest/Store/Makefile.am A vdsm/rest/Store/StorageDriver.py A vdsm/rest/Store/__init__.py A vdsm/rest/__init__.py A vdsm/rest/templates/Makefile.am A vdsm/rest/templates/image.json.x A vdsm/rest/templates/images.json.x A vdsm/rest/templates/root.json.x A vdsm/rest/templates/storageconnection.json.x A vdsm/rest/templates/storageconnections.json.x A vdsm/rest/templates/storagedomain.json.x A vdsm/rest/templates/storagedomains.json.x A vdsm/rest/templates/storagepool.json.x A vdsm/rest/templates/storagepools.json.x A vdsm/rest/templates/task.json.x A vdsm/rest/templates/tasks.json.x A vdsm/rest/templates/vm.json.x A vdsm/rest/templates/vmdrive.json.x A vdsm/rest/templates/vmdrives.json.x A vdsm/rest/templates/vms.json.x A vdsm/rest/templates/volume.json.x A vdsm/rest/templates/volumes.json.x 33 files changed, 1,740 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/2021/1 -- To view, visit http://gerrit.ovirt.org/2021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>

7 28

Change in vdsm[master]: BZ#752470 Related: Out of process getReadDelay
by Federico Simoncelli 07 May '12

07 May '12

Federico Simoncelli has uploaded a new change for review. Change subject: BZ#752470 Related: Out of process getReadDelay ...................................................................... BZ#752470 Related: Out of process getReadDelay To avoid being blocked by a thread in a D state we should determine the read delay using oop also for block devices. Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e --- M vdsm/storage/blockSD.py M vdsm/storage/misc.py 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/264/1 -- To view, visit http://gerrit.ovirt.org/264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 5

Change in vdsm[master]: vm payload: add file injection to vm
by shavivi＠redhat.com 07 May '12

07 May '12

Shahar Havivi has uploaded a new change for review. Change subject: vm payload: add file injection to vm ...................................................................... vm payload: add file injection to vm this patch adds new parameter to create verb vmPayload, user can send file content and have them in the vm in floppy of iso format. Change-Id: I256475342c79690a95ad999335522f99714cdc8b --- M configure.ac M vdsm/constants.py.in M vdsm/libvirtvm.py M vdsm/supervdsmServer.py M vdsm/vm.py 5 files changed, 99 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/2321/1 -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>

6 77

Change in vdsm[master]: Don't invalidate the lv on lvchange(). Activity is tested us...
by smizrahi＠redhat.com 16 Apr '12

16 Apr '12

Saggi Mizrahi has uploaded a new change for review. Change subject: Don't invalidate the lv on lvchange(). Activity is tested using device mapper anyway ...................................................................... Don't invalidate the lv on lvchange(). Activity is tested using device mapper anyway Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 --- M vdsm/storage/lvm.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/675/1 -- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

3 7

Change in vdsm[master]: BZ#773210 - Avoid infinity loop when delete volume failed du...
by Igor Lvovsky 08 Apr '12

08 Apr '12

Igor Lvovsky has uploaded a new change for review. Change subject: BZ#773210 - Avoid infinity loop when delete volume failed during the merge ...................................................................... BZ#773210 - Avoid infinity loop when delete volume failed during the merge Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5 --- M vdsm/storage/image.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/987/1 -- To view, visit http://gerrit.ovirt.org/987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

4 11

Change in vdsm[master]: Integrate SANLock with VM's life cycle
by Federico Simoncelli 05 Apr '12

05 Apr '12

Federico Simoncelli has uploaded a new change for review. Change subject: Integrate SANLock with VM's life cycle ...................................................................... Integrate SANLock with VM's life cycle Change-Id: I55596a7a5b25fded341f6157f190ae741af41fce --- M vdsm/libvirtvm.py M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py M vdsm/storage/hsm.py M vdsm/storage/sd.py 5 files changed, 78 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/1253/1 -- To view, visit http://gerrit.ovirt.org/1253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I55596a7a5b25fded341f6157f190ae741af41fce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 10

Change in vdsm[master]: Define some constants in API.py
by agl＠us.ibm.com 05 Apr '12

05 Apr '12

Adam Litke has uploaded a new change for review. Change subject: Define some constants in API.py ...................................................................... Define some constants in API.py Signed-off-by: Adam Litke <agl(a)us.ibm.com> Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be --- M vdsm/API.py 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/2262/1 -- To view, visit http://gerrit.ovirt.org/2262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>

4 12

Change in vdsm[master]: [WIP] Support unicode in domain and pool description
by smizrahi＠redhat.com 01 Apr '12

01 Apr '12

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] Support unicode in domain and pool description ...................................................................... [WIP] Support unicode in domain and pool description Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e --- M vdsm/storage/dispatcher.py M vdsm/storage/persistentDict.py M vdsm/storage/sd.py M vdsm/storage/sp.py 4 files changed, 17 insertions(+), 31 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/637/1 -- To view, visit http://gerrit.ovirt.org/637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

3 10

Change in vdsm[master]: dispatcher: drop Unicode-less validation
by Dan Kenigsberg 01 Apr '12

01 Apr '12

Dan Kenigsberg has uploaded a new change for review. Change subject: dispatcher: drop Unicode-less validation ...................................................................... dispatcher: drop Unicode-less validation Change-Id: Ic4a2e87cd9bde71326e10893843efd04ef33aec8 --- M vdsm/storage/dispatcher.py 1 file changed, 2 insertions(+), 25 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/1703/1 -- To view, visit http://gerrit.ovirt.org/1703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4a2e87cd9bde71326e10893843efd04ef33aec8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

2 3

Change in vdsm[master]: added support for mirror promisc mode
by shavivi＠redhat.com 28 Mar '12

28 Mar '12

Shahar Havivi has uploaded a new change for review. Change subject: added support for mirror promisc mode ...................................................................... added support for mirror promisc mode let ability to VM to monitor (mirror) all other VMs in the same host by specific network (bridge) Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec --- M configure.ac M vdsm/libvirtvm.py 2 files changed, 123 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/956/1 -- To view, visit http://gerrit.ovirt.org/956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>

5 28

Change in vdsm[master]: Workaround a known localstorage bug
by agl＠us.ibm.com 28 Mar '12

28 Mar '12

Adam Litke has uploaded a new change for review. Change subject: Workaround a known localstorage bug ...................................................................... Workaround a known localstorage bug Signed-off-by: Adam Litke <agl(a)us.ibm.com> Change-Id: I783b83f75afba2854c7b87f5e2abd52a76bc2458 --- M vdsm/storage/storage_connection.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/2261/1 -- To view, visit http://gerrit.ovirt.org/2261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I783b83f75afba2854c7b87f5e2abd52a76bc2458 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>

2 2

Change in vdsm[master]: Try to destroy VM gracefully
by Igor Lvovsky 25 Mar '12

25 Mar '12

Igor Lvovsky has uploaded a new change for review. Change subject: Try to destroy VM gracefully ...................................................................... Try to destroy VM gracefully Change-Id: If58f1b0e7208242aef0b81d9ea59d05bd3d5d99e --- M vdsm/libvirtvm.py 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/2138/1 -- To view, visit http://gerrit.ovirt.org/2138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If58f1b0e7208242aef0b81d9ea59d05bd3d5d99e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

4 6

Change in vdsm[master]: BZ#787728 configNet: restore backup on connectivity failure
by Dan Kenigsberg 18 Mar '12

18 Mar '12

Dan Kenigsberg has uploaded a new change for review. Change subject: BZ#787728 configNet: restore backup on connectivity failure ...................................................................... BZ#787728 configNet: restore backup on connectivity failure Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb --- M vdsm/configNetwork.py 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/1686/1 -- To view, visit http://gerrit.ovirt.org/1686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9ced506a35cae90946813b97b83332d7ecb6aeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

3 5

Change in vdsm[master]: do not croak on mountpoint with space and digit
by Dan Kenigsberg 16 Mar '12

16 Mar '12

Dan Kenigsberg has uploaded a new change for review. Change subject: do not croak on mountpoint with space and digit ...................................................................... do not croak on mountpoint with space and digit A mountpoint with ' 09' just gave me Change-Id: I33997893320041648187c56e8500348a6850fdfe return _RE_ESCAPE.sub(lambda s: chr(int(s.group()[1:], 8)), path) ValueError: invalid literal for int() with base 8: '04009' --- M vdsm/storage/mount.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/2068/1 -- To view, visit http://gerrit.ovirt.org/2068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33997893320041648187c56e8500348a6850fdfe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

2 4

Change in vdsm[master]: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code
by Dan Kenigsberg 15 Mar '12

15 Mar '12

Dan Kenigsberg has uploaded a new change for review. Change subject: BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code ...................................................................... BZ#729251 vds_bootstrap: drop dead netconsole/vdcrepo code When http://gerrit.ovirt.org/1848 and http://gerrit.ovirt.org/1689 are taken into Engine, -u and -n options to vds_bootrap would never be passed. Remove this dead code. Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a --- M vds_bootstrap/vds_bootstrap.py M vdsm.spec.in 2 files changed, 9 insertions(+), 38 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/1931/1 -- To view, visit http://gerrit.ovirt.org/1931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I528103d344b2a9d0bee87e3c68e32b2d67ab439a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

4 6

Change in vdsm[master]: Added blkid tool into constants.
by barumuga＠redhat.com 15 Mar '12

15 Mar '12

Hello Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/2185 to review the following change. Change subject: Added blkid tool into constants. ...................................................................... Added blkid tool into constants. blkid tool is used to get block device attributes Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60 Signed-off-by: Bala.FA <barumuga(a)redhat.com> --- M configure.ac M vdsm/constants.py.in M vdsm/sudoers.vdsm.in 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/2185/1 -- To view, visit http://gerrit.ovirt.org/2185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

4 31

Change in vdsm[master]: dumpStorageTable: search deeper for vms list
by Dan Kenigsberg 15 Mar '12

15 Mar '12

Dan Kenigsberg has uploaded a new change for review. Change subject: dumpStorageTable: search deeper for vms list ...................................................................... dumpStorageTable: search deeper for vms list Change-Id: I264ece45f42e0707070efb26a651cb492840c552 --- M vdsm/dumpStorageTable.py.in 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/2427/1 -- To view, visit http://gerrit.ovirt.org/2427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I264ece45f42e0707070efb26a651cb492840c552 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

2 3

Change in vdsm[master]: Add the device type in the snapshot dictionary
by Federico Simoncelli 12 Mar '12

12 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: Add the device type in the snapshot dictionary ...................................................................... Add the device type in the snapshot dictionary Since commit 3c1dad8 (Fix vdsm disks ops for the new API) it is required to pass the device type to prepareVolumePath. Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3 --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/2437/1 -- To view, visit http://gerrit.ovirt.org/2437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 6

Change in vdsm[master]: fixed iscsi discovery and added iSER transport support
by Roi Dayan 08 Mar '12

08 Mar '12

Roi Dayan has uploaded a new change for review. Change subject: fixed iscsi discovery and added iSER transport support ...................................................................... fixed iscsi discovery and added iSER transport support Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47 --- M vdsm/config.py.in M vdsm/storage/iscsi.py 2 files changed, 41 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1350/1 -- To view, visit http://gerrit.ovirt.org/1350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com>

3 3

Change in vdsm[master]: A new method to read from VMs' channels.
by ghammer＠redhat.com 08 Mar '12

08 Mar '12

Gal Hammer has uploaded a new change for review. Change subject: A new method to read from VMs' channels. ...................................................................... A new method to read from VMs' channels. Replaced having a thread-per-VM that monitor and read from the VM's virtual channel with a 1-thread listener that handle all VMs' channels. Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc --- M vdsm.spec.in M vdsm/Makefile.am M vdsm/clientIF.py M vdsm/guestIF.py M vdsm/libvirtvm.py A vdsm/vmChannels.py 6 files changed, 164 insertions(+), 69 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/869/1 -- To view, visit http://gerrit.ovirt.org/869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>

4 16

Change in vdsm[master]: [WIP] The begining of the new API
by smizrahi＠redhat.com 06 Mar '12

06 Mar '12

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] The begining of the new API ...................................................................... [WIP] The begining of the new API Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 --- M vdsm/storage/hsm.py 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/1695/1 -- To view, visit http://gerrit.ovirt.org/1695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2c15799a83e7b3f39d12c2aa7c91f321156e663 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

3 3

Change in vdsm[master]: [WIP] Implement storage server connection monitoring
by smizrahi＠redhat.com 06 Mar '12

06 Mar '12

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] Implement storage server connection monitoring ...................................................................... [WIP] Implement storage server connection monitoring Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380 --- M vdsm.spec.in M vdsm/storage/Makefile.am M vdsm/storage/hsm.py M vdsm/storage/storageServer.py A vdsm/storage/sync.py 5 files changed, 304 insertions(+), 15 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/1694/1 -- To view, visit http://gerrit.ovirt.org/1694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

4 5

Change in vdsm[master]: [WIP] Implement storage server connection aliasing
by smizrahi＠redhat.com 06 Mar '12

06 Mar '12

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] Implement storage server connection aliasing ...................................................................... [WIP] Implement storage server connection aliasing Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a --- M vdsm/storage/hsm.py M vdsm/storage/storageServer.py 2 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/1693/1 -- To view, visit http://gerrit.ovirt.org/1693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

6 7

Change in vdsm[master]: Refactor storage connection subsystem
by smizrahi＠redhat.com 06 Mar '12

06 Mar '12

Saggi Mizrahi has uploaded a new change for review. Change subject: Refactor storage connection subsystem ...................................................................... Refactor storage connection subsystem The current one is an abysmal mess. This is a tramsitional patch retrofitting the old API to some of the concept we intend to implement. This introduces ConnectionMonitor. It currently doesn't do any monitoring just connects and disconnects from storage. It uses URIs for specifying storage targets which is more generic and simple to parse. Notice: Permissions are no longer checked on storage connect only on domain initialization. This is good as the storage connection is far from an apropriate place for that check. I've removed stale root folder handling for NFS. I will add it back I can't do everything at once. There are also no proper engine acceptable exceptions yet Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d --- M vdsm.spec.in M vdsm/storage/Makefile.am A vdsm/storage/connectionMonitor.py M vdsm/storage/fileSD.py M vdsm/storage/hsm.py M vdsm/storage/iscsi.py M vdsm/storage/localFsSD.py M vdsm/storage/misc.py M vdsm/storage/mount.py M vdsm/storage/multipath.py M vdsm/storage/nfsSD.py A vdsm/storage/storageMailbox.py D vdsm/storage/storage_connection.py A vdsm/storage/sync.py 14 files changed, 884 insertions(+), 486 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/1038/1 -- To view, visit http://gerrit.ovirt.org/1038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

6 18

Change in vdsm[master]: ISCSI Subsystem refactoring
by smizrahi＠redhat.com 06 Mar '12

06 Mar '12

Saggi Mizrahi has uploaded a new change for review. Change subject: ISCSI Subsystem refactoring ...................................................................... ISCSI Subsystem refactoring Currently the iscsi subsystem is a mess of list concatenation. This refactoring ties to: - Make variable and object naming consistent and in line with iscsi terminology. Note that: * portal now refres to an ISCSI Portal and not a tpgt * tpgt now refres to tpgt * ISCSI interfaces are modeled so that initiator name is actually property of the interface and not it's identity - Make a coherent object hierarchy of the ISCSI objects. Functions now expect to get ISCSI objects (like portal, target) instead of scattered arguments that have to be validated and parsed every time. - Make the ISCSI interface a 1st class member. Up until now support for multiple interfaces was amateurish at best. - Support for different credentials for discovery and target. Ground work to support authentication methods other then CHAP. - Thin wrap around iscsiadm to separate cmdline parsing from actual VDSM iscsi logic Stuff known to be broken: - iser support. It was weirdly hacked in the old code. I will put a code path to preserve backward compatibility. - implicit interface creation. As this was never officially supported by VDSM I will not bring this back. - tpgt is ignores. This is in line with old VDSM behaviour. Note that the confusing naming is still used by the old API calls for backward compatibility. New API calls should try and use correct naming and format! Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a --- M vdsm.spec.in M vdsm/constants.py.in M vdsm/storage/Makefile.am M vdsm/storage/hsm.py M vdsm/storage/iscsi.py A vdsm/storage/iscsiadm.py M vdsm/storage/multipath.py M vdsm/storage/storageProviderConnectionMonitor.py M vdsm/supervdsmServer.py 9 files changed, 609 insertions(+), 424 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/1607/1 -- To view, visit http://gerrit.ovirt.org/1607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

5 15

Change in vdsm[master]: [WIP] Add the vdsm-tool command
by Federico Simoncelli 06 Mar '12

06 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the vdsm-tool command ...................................................................... [WIP] Add the vdsm-tool command Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 --- M Makefile.am M configure.ac A vdsm-tool/Makefile.am A vdsm-tool/__init__.py A vdsm-tool/vdsm-tool M vdsm.spec.in 6 files changed, 115 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/295/1 -- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 5

Change in vdsm[master]: [WIP] Move the VDSM common code to the python site lib
by Federico Simoncelli 06 Mar '12

06 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Move the VDSM common code to the python site lib ...................................................................... [WIP] Move the VDSM common code to the python site lib Some VDSM code is shared between different components (eg: vdsm and vdsm-cli share vdscli.py) and some modules have a really common name (eg: utils, config) risking to collide with other packages. For these two reasons and for cleanliness some modules are moved to a new location (the standard python site lib) and they can be shipped in a different package. Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6 --- M configure.ac M vds_bootstrap/vds_bootstrap.py M vdsm.spec.in M vdsm/Makefile.am M vdsm/caps.py M vdsm/clientIF.py M vdsm/config.py M vdsm/configNetwork.py M vdsm/get-conf-item M vdsm/guestIF.py M vdsm/hooks.py M vdsm/kaxmlrpclib.py M vdsm/ksm.py M vdsm/libvirtconnection.py M vdsm/libvirtvm.py M vdsm/netinfo.py M vdsm/set-conf-item M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py M vdsm/storage/devicemapper.py M vdsm/storage/dispatcher.py M vdsm/storage/fileSD.py M vdsm/storage/fileUtils.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/iscsi.py M vdsm/storage/lvm.py M vdsm/storage/misc.py M vdsm/storage/multipath.py M vdsm/storage/outOfProcess.py M vdsm/storage/processPool.py M vdsm/storage/resourceFactories.py M vdsm/storage/safelease.py M vdsm/storage/sd.py M vdsm/storage/sdc.py M vdsm/storage/sp.py M vdsm/storage/storage_connection.py M vdsm/storage/storage_mailbox.py M vdsm/storage/task.py M vdsm/storage/taskManager.py M vdsm/storage/volume.py M vdsm/substitute_constants.py M vdsm/supervdsm.py M vdsm/supervdsmServer.py M vdsm/ut/ivdsm.py M vdsm/ut/testGuestChannel.py M vdsm/utils.py M vdsm/vdsm M vdsm/vm.py M vdsm_cli/Makefile.am M vdsm_cli/dumpStorageTable.py M vdsm_cli/vdsClient.py M vdsm_cli/vdscli.py.in M vdsm_hooks/faqemu/before_vm_start.py M vdsm_hooks/vhostmd/after_vm_destroy.py M vdsm_reg/rhevm.py M vdsm_reg/vdsm-reg-setup 57 files changed, 144 insertions(+), 129 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/286/1 -- To view, visit http://gerrit.ovirt.org/286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 8

Change in vdsm[master]: BZ#798211 - Normalize hibernation images
by Igor Lvovsky 06 Mar '12

06 Mar '12

Igor Lvovsky has uploaded a new change for review. Change subject: BZ#798211 - Normalize hibernation images ...................................................................... BZ#798211 - Normalize hibernation images Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842 --- M vdsm/API.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/2431/1 -- To view, visit http://gerrit.ovirt.org/2431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

5 6

Change in vdsm[master]: Remove validateAttachedDomain in detachSD
by Federico Simoncelli 05 Mar '12

05 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: Remove validateAttachedDomain in detachSD ...................................................................... Remove validateAttachedDomain in detachSD Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 --- M vdsm/storage/sp.py 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/2074/1 -- To view, visit http://gerrit.ovirt.org/2074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9bbf19973cafd869f0e0ce3dfdf38b3619caa110 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 3

Change in vdsm[master]: BZ#797354 drop enic from modprobe.d/vdsm.conf
by Dan Kenigsberg 01 Mar '12

01 Mar '12

Dan Kenigsberg has uploaded a new change for review. Change subject: BZ#797354 drop enic from modprobe.d/vdsm.conf ...................................................................... BZ#797354 drop enic from modprobe.d/vdsm.conf Change-Id: Ia3bf4b25a8493585301d515b1e76e5f75755c86b --- M vdsm/vdsm-modprobe.conf 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/2337/1 -- To view, visit http://gerrit.ovirt.org/2337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3bf4b25a8493585301d515b1e76e5f75755c86b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

2 3

Change in vdsm[master]: [WIP] Initial live merge implementation
by Federico Simoncelli 01 Mar '12

01 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Initial live merge implementation ...................................................................... [WIP] Initial live merge implementation Change-Id: I27c3f8378defcce0c7123894fbe09636910fb275 --- M vdsm.spec.in M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/define.py M vdsm/libvirtconnection.py M vdsm/libvirtvm.py M vdsm/storage/hsm.py 7 files changed, 87 insertions(+), 37 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/1806/1 -- To view, visit http://gerrit.ovirt.org/1806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I27c3f8378defcce0c7123894fbe09636910fb275 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 6

Change in vdsm[master]: Replace most traceback.format_exc() calls by exc_info
by ewoud＠kohlvanwijngaarden.nl 01 Mar '12

01 Mar '12

Ewoud Kohl van Wijngaarden has uploaded a new change for review. Change subject: Replace most traceback.format_exc() calls by exc_info ...................................................................... Replace most traceback.format_exc() calls by exc_info Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15 --- M vds_bootstrap/vds_bootstrap.py M vds_bootstrap/vds_qualifier.py M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/clientIF.py M vdsm/guestIF.py M vdsm/ksm.py M vdsm/libvirtconnection.py M vdsm/libvirtvm.py M vdsm/storage/misc.py M vdsm/storage/storage_mailbox.py M vdsm/utils.py M vdsm/vdsm M vdsm/vm.py M vdsm_reg/vdsm-gen-cert M vdsm_reg/vdsm-reg-setup.in 16 files changed, 56 insertions(+), 65 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/2259/1 -- To view, visit http://gerrit.ovirt.org/2259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I795199bdb2d85a08b04dfcbbb9e727c5893aee15 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>

3 8

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2012