Change in vdsm[master]: BZ#802347 try and not access iscsid concurrently
by smizrahi@redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: BZ#802347 try and not access iscsid concurrently
......................................................................
BZ#802347 try and not access iscsid concurrently
Change-Id: Ifa04477794c51602c8a630f5ce53e3183627c1b3
---
M vdsm/storage/iscsi.py
1 file changed, 21 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/2750/1
--
To view, visit http://gerrit.ovirt.org/2750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa04477794c51602c8a630f5ce53e3183627c1b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 6 months
Change in vdsm[master]: Add the device type in the snapshot dictionary
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Add the device type in the snapshot dictionary
......................................................................
Add the device type in the snapshot dictionary
Since commit 3c1dad8 (Fix vdsm disks ops for the new API) it is required
to pass the device type to prepareVolumePath.
Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/2437/1
--
To view, visit http://gerrit.ovirt.org/2437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33b8cdafb2bc092dcb7554446fd6d55a2ce41cb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years, 6 months
Change in vdsm[master]: void check pool masterver not zero when connecting
by lvroyce@linux.vnet.ibm.com
Royce Lv has uploaded a new change for review.
Change subject: void check pool masterver not zero when connecting
......................................................................
void check pool masterver not zero when connecting
when first connect a pool with masterVersion 0(not "0") ,pool.getPoolParams will be called to read connection info from saved file which is created later when pool.connect,trigger getPoolParam reports error
Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/2645/1
--
To view, visit http://gerrit.ovirt.org/2645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eb0f4618e78735d6ae5e25e81b9ea544540691c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
11 years, 6 months
Change in vdsm[master]: Add function getNetworkList to API bridge
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Add function getNetworkList to API bridge
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Again, I'd prefer to see how this new function is going to be used. Splitting networking out of getVdsCaps has its own sense, but your commit message is misleading - the REST binding could use the current function.
....................................................
File vdsm/API.py
Line 1209: print "Networks:", networkList
print?
--
To view, visit http://gerrit.ovirt.org/2664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
11 years, 6 months
Change in vdsm[master]: Re-organized internal network APIs in API bridge
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Re-organized internal network APIs in API bridge
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/API.py
Line 910: def __init__(self, cif):
what does a "Network" object represent? How many such objects do you perceive?
Note that setupNetworks (intentionally) works on several networks.
However you have let setSafeNetConfig in General.
So the motivation for this patch is not completely clear to me. Maybe if you send a following patch using this refactoring.
--
To view, visit http://gerrit.ovirt.org/2663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64771991c3db09247f7689e6b5ddffa8adbf6745
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
11 years, 6 months
Change in vdsm[master]: VDSM-Reg should not import vdsm.config
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: VDSM-Reg should not import vdsm.config
......................................................................
VDSM-Reg should not import vdsm.config
Change-Id: I0886470541ba606d2bf46112265942576d70f19c
---
M vdsm_reg/vdsm-reg-setup.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/2681/1
--
To view, visit http://gerrit.ovirt.org/2681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0886470541ba606d2bf46112265942576d70f19c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years, 6 months
Change in vdsm[master]: read iscsi session info properly
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: read iscsi session info properly
......................................................................
read iscsi session info properly
read from /sys/class/iscsi_session and /sys/class/iscsi_connection directories
if could not be found under /sys/devices/platform/host*/ which is how the
function with right now.
Change-Id: Ib86ef9b71c27abade359095f8d1985a76d4b8efa
---
M vdsm/storage/iscsi.py
1 file changed, 5 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/2628/1
--
To view, visit http://gerrit.ovirt.org/2628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib86ef9b71c27abade359095f8d1985a76d4b8efa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Roi Dayan <roi.dayan(a)gmail.com>
11 years, 6 months
Change in vdsm[master]: Add function getNetworkList to API bridge
by lilei@linux.vnet.ibm.com
Lei Li has posted comments on this change.
Change subject: Add function getNetworkList to API bridge
......................................................................
Patch Set 1:
Yes, getVdsCapabilities can return this information, to support network REST APIs we need such an API in API bridge but seems there is not an wrapped API in vdsm. I just add it to xmlrpc passingly. If you don't think this API is needed as a xmlrpc verb, I will send patch Set2 with it removed.
--
To view, visit http://gerrit.ovirt.org/2664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
11 years, 6 months
Change in vdsm[master]: Updated threading.Lock acquire to a more Python-like mean.
by ghammer@redhat.com
Gal Hammer has uploaded a new change for review.
Change subject: Updated threading.Lock acquire to a more Python-like mean.
......................................................................
Updated threading.Lock acquire to a more Python-like mean.
Change-Id: Id1c6f17ee98a63b9dfbb665e258a28d2e90f39e3
---
M vdsm/vmChannels.py
1 file changed, 4 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/2646/1
--
To view, visit http://gerrit.ovirt.org/2646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1c6f17ee98a63b9dfbb665e258a28d2e90f39e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
11 years, 6 months
Change in vdsm[master]: Add function getNetworkList to API bridge
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Add function getNetworkList to API bridge
......................................................................
Patch Set 1: I would prefer that you didn't submit this
Currently this information is returned with getVdsCapabilities. Please explain why do we need a new xmlrpc verb.
--
To view, visit http://gerrit.ovirt.org/2664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
11 years, 6 months