Change in vdsm[master]: vds_bootstrap: changing the default to install virt to true
by Oved Ourfali
Oved Ourfali has uploaded a new change for review.
Change subject: vds_bootstrap: changing the default to install virt to true
......................................................................
vds_bootstrap: changing the default to install virt to true
Preivous patch added an option "-v" to enable virt installation.
This made issues in backward compatability, as old engine couldn't
install new client. Passing now -V to disable virt installation.
Change-Id: Ie4b1f63309db0ac624944c5432e52d0ce3781770
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M vds_bootstrap/vds_bootstrap.py
M vds_bootstrap/vds_bootstrap_complete.py
2 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/3858/1
--
To view, visit http://gerrit.ovirt.org/3858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4b1f63309db0ac624944c5432e52d0ce3781770
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
12 years, 1 month
Change in vdsm[master]: vds_bootstrap: allowing the options n and u as paratemers
by Oved Ourfali
Oved Ourfali has uploaded a new change for review.
Change subject: vds_bootstrap: allowing the options n and u as paratemers
......................................................................
vds_bootstrap: allowing the options n and u as paratemers
Previous patch removed dead code, thus removing the options "n" and "u"
from the vds_bootstrap, and it broke backward compatibility (old engine
couldn't install new clients).
Change-Id: Ia39774898052957a3e3c83536cb90e4a2d8a957d
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M vds_bootstrap/vds_bootstrap.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/3857/1
--
To view, visit http://gerrit.ovirt.org/3857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia39774898052957a3e3c83536cb90e4a2d8a957d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
12 years, 1 month
Change in vdsm[master]: vdsm/storage/misc.py: Convert uuid input to string before va...
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: vdsm/storage/misc.py: Convert uuid input to string before validating
......................................................................
vdsm/storage/misc.py: Convert uuid input to string before validating
When abusing the createVolume() method by passing numeric values
as UUIDs, the validation regex needs a string to process and
throws an exception when it isn't:
Traceback (most recent call last):
File "/usr/share/vdsm/storage/task.py", line 861, in _run
return fn(*args, **kargs)
File "/usr/share/vdsm/logUtils.py", line 38, in wrapper
res = f(*args, **kwargs)
File "/usr/share/vdsm/storage/hsm.py", line 1206, in createVolume
misc.validateUUID(imgUUID, 'imgUUID')
File "/usr/share/vdsm/storage/misc.py", line 525, in validateUUID
m = UUID_REGEX.match(uuid)
TypeError: expected string or buffer
And on the client side, I get a less than useful error:
Traceback (most recent call last):
File "create_a_vm.py", line 98, in <module>
BLANK_UUID, BLANK_UUID))
File "create_a_vm.py", line 19, in vdsOK
raise Exception(str(d))
Exception: {'status': {'message': "Error creating a new volume: ('sdUUID=99d43d50-5946-4451-8e12-9d85cb426e19, spUUID=150e55ab-e68c-411c-af30-587071905216, imgUUID=4194304, size=4, volFormat=2, preallocate=rootfs, diskType=7bdf7b4b-4909-41ce-a9c0-9bc06ba045fe, volUUID=00000000-0000-0000-0000-000000000000, desc=00000000-0000-0000-0000-000000000000, srcImgUUID=00000000-0000-0000-0000-000000000000, srcVolUUID=00000000-0000-0000-0000-000000000000',)", 'code': 205}}
However, if we convert the input to a string first then we can
fail the REGEX and raise the more useful invalid parameter exception:
Now, I get:
Traceback (most recent call last):
File "create_a_vm.py", line 98, in <module>
BLANK_UUID, BLANK_UUID))
File "create_a_vm.py", line 19, in vdsOK
raise Exception(str(d))
Exception: {'status': {'message': "Invalid parameter: 'imgUUID=4194304'", 'code': 1000}}
Which explains to me my error quite well.
Change-Id: If16466e88a50d3af03ae7830d4d8148ebf69d0d9
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/storage/misc.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/3687/1
--
To view, visit http://gerrit.ovirt.org/3687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If16466e88a50d3af03ae7830d4d8148ebf69d0d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years, 1 month
Change in vdsm[master]: Added getMdUuidMap function in supervdsm.
by barumuga＠redhat.com
Hello Timothy Asir, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/3469
to review the following change.
Change subject: Added getMdUuidMap function in supervdsm.
......................................................................
Added getMdUuidMap function in supervdsm.
getMdUuidMap function returns all md/uuid map. Sample return value
is,
{'/dev/md0': 'e35641fc:621a9fa8:123456e4:a1bc6b5f',
'/dev/md1': '95451662:3945780b:123456a7:f3ad55c5'}
Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/md_utils.py
M vdsm/supervdsmServer.py
4 files changed, 42 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/3469/1
--
To view, visit http://gerrit.ovirt.org/3469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1970fa0ad9125c29b4a96fa614c580682ac5064c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
12 years, 1 month
Change in vdsm[master]: tests/misc: add utf-8 string test to validateUUID
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: tests/misc: add utf-8 string test to validateUUID
......................................................................
tests/misc: add utf-8 string test to validateUUID
As requested, add a test case with a Chinese UTF-8 string.
Change-Id: I7e07af6ce9df8b0bd3e4554a8baa8131486a00df
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M tests/miscTests.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/3849/1
--
To view, visit http://gerrit.ovirt.org/3849
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e07af6ce9df8b0bd3e4554a8baa8131486a00df
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years, 1 month
Change in vdsm[master]: tests:miscTests add integer input test for validateUUID
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: tests:miscTests add integer input test for validateUUID
......................................................................
tests:miscTests add integer input test for validateUUID
Change-Id: I5c22aa6853c55f74c3128e4dd46136ea0ade29c5
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M tests/miscTests.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/3848/1
--
To view, visit http://gerrit.ovirt.org/3848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c22aa6853c55f74c3128e4dd46136ea0ade29c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years, 1 month
Change in vdsm[master]: API.py: fix pep8 noise
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: API.py: fix pep8 noise
......................................................................
API.py: fix pep8 noise
commit a35c862341a4fa05e6 did not manage to completely make API.py
conform to pep8, at least not with python-pep8-0.6.0-3.fc15.noarch
Change-Id: Ibd3fd81ce563c748b299a5adf316a4623f17b565
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M Makefile.am
M vdsm/API.py
2 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/3852/1
--
To view, visit http://gerrit.ovirt.org/3852
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd3fd81ce563c748b299a5adf316a4623f17b565
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
12 years, 1 month
Change in vdsm[master]: Added getDevicePartedInfo function in supervdsm.
by barumuga＠redhat.com
Hello Timothy Asir, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/3386
to review the following change.
Change subject: Added getDevicePartedInfo function in supervdsm.
......................................................................
Added getDevicePartedInfo function in supervdsm.
This function accepts device path and returns its information as
dictionary. Sample return value is,
{'model': 'Virtio Block Device',
'sectorSize': 512L,
'type': 'gpt',
'freeSpaceRegions': [(34L, 2047L, 2014L, 1031168L),
(16775168L, 16777182L, 2015L, 1031680L)],
'partitions': [('/dev/vda1', ['bios_grub'], 2048L, 4095L),
('/dev/vda2', ['boot'], 4096L, 16285695L),
('/dev/vda3', [], 16285696L, 16775167L)]}
Change-Id: I6388d6c112abf106471223101be495f20f157c66
Signed-off-by: Bala.FA <barumuga(a)redhat.com>
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/parted_super.py
M vdsm/supervdsmServer.py
4 files changed, 62 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/3386/1
--
To view, visit http://gerrit.ovirt.org/3386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6388d6c112abf106471223101be495f20f157c66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
12 years, 1 month
Change in vdsm[master]: Make API.py conform to pep8
by lilei＠linux.vnet.ibm.com
Lei Li has uploaded a new change for review.
Change subject: Make API.py conform to pep8
......................................................................
Make API.py conform to pep8
Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Signed-off-by: Lei Li <lilei(a)linux.vnet.ibm.com>
---
M vdsm/API.py
1 file changed, 89 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/3561/1
--
To view, visit http://gerrit.ovirt.org/3561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9549186e537ba23994891e27b58be3d6d3770f40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
12 years, 1 month
Change in vdsm[master]: Related to BZ#773210 - Avoid infinite loop when delete volum...
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Related to BZ#773210 - Avoid infinite loop when delete volume failed during the merge.
......................................................................
Related to BZ#773210 - Avoid infinite loop when delete volume failed during the merge.
This loop occurs at the end of the merge operation and if we failed
to remove remnants at this point it's still OK.
Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com>
---
M vdsm/storage/image.py
1 file changed, 5 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/3774/1
--
To view, visit http://gerrit.ovirt.org/3774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I447c71ef9d4e9e672de2470bd571c1ae60d4715f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 1 month
