Change in vdsm[master]: Compare Drive according to its name during lvextend
by Igor Lvovsky
Igor Lvovsky has uploaded a new change for review.
Change subject: Compare Drive according to its name during lvextend
......................................................................
Compare Drive according to its name during lvextend
Change-Id: Ib6ea950f8f9071f903ffaba85d7f84d9d12e8d5d
---
M vdsm/vm.py
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/3391/1
--
To view, visit http://gerrit.ovirt.org/3391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6ea950f8f9071f903ffaba85d7f84d9d12e8d5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years
Change in vdsm[master]: pylint: vdsm/utils.py
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: pylint: vdsm/utils.py
......................................................................
pylint: vdsm/utils.py
************* Module utils
E:681,42:getHostUUID: Instance of 'list' has no 'splitlines' member (but some
types could not be inferred)
- applied str() to command output
Change-Id: I0bb6bb0a8a1992bf89f52aa947d342f3c3777e75
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/3442/1
--
To view, visit http://gerrit.ovirt.org/3442
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb6bb0a8a1992bf89f52aa947d342f3c3777e75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years
Change in vdsm[master]: pylint: vdsm/netinfo.py
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: pylint: vdsm/netinfo.py
......................................................................
pylint: vdsm/netinfo.py
************* Module netinfo
E: 45,23:nics: Instance of '_Chainmap' has no 'split' member (but some types could not be inferred)
E:137,22:ifconfig: Instance of 'list' has no 'split' member (but some types could not be inferred)
E:377,16:NetInfo.getNicsVlanAndBondingForNetwork: Function 'nics' has no 'append' member
applied some str() conversions. For the nics append, there is a global function called 'nics'
which pylint says is the same as the local variable (list) 'nics'. I renamed the function to
be more descriptive: def nics() -> def enumerate_nics() and modified caller.
Change-Id: Iee990e661acb15504e180dd3005aaa048153326c
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/netinfo.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/3441/1
--
To view, visit http://gerrit.ovirt.org/3441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee990e661acb15504e180dd3005aaa048153326c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years
Change in vdsm[master]: pylint: vdsm/guestIF.py
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: pylint: vdsm/guestIF.py
......................................................................
pylint: vdsm/guestIF.py
************* Module guestIF
E: 94,21:GuestAgent._forward: Module 'logging' has no 'TRACE' member
E: 97,21:GuestAgent._handleMessage: Module 'logging' has no 'TRACE' member
E:226,25:GuestAgent._onChannelTimeout: Module 'logging' has no 'TRACE' member
s/logging.TRACE/logging.CRITICAL
Change-Id: Ic9421bde7939f0085f9df83625192b1a470cc108
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/guestIF.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/3440/1
--
To view, visit http://gerrit.ovirt.org/3440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9421bde7939f0085f9df83625192b1a470cc108
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years
Change in vdsm[master]: pylint: vdsm/configNetwork.py fixes
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: pylint: vdsm/configNetwork.py fixes
......................................................................
pylint: vdsm/configNetwork.py fixes
************* Module configNetwork
E: 68,7:ifdown: Instance of 'list' has no 'strip' member (but some types could not be inferred)
E: 70,7:ifdown: Instance of 'list' has no 'strip' member (but some types could not be inferred)
E: 71,49:ifdown: Instance of 'list' has no 'splitlines' member (but some types could not be inferred)
E: 80,7:ifup: Instance of 'list' has no 'strip' member (but some types could not be inferred)
E: 82,7:ifup: Instance of 'list' has no 'strip' member (but some types could not be inferred)
Convert subprocess output into string with str() wrapper for use of .strip()/.splitlines()
Change-Id: Ica90db7af78e347a4bcd05584e3a30b23645b6fa
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/configNetwork.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/3439/1
--
To view, visit http://gerrit.ovirt.org/3439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica90db7af78e347a4bcd05584e3a30b23645b6fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years
Change in vdsm[master]: pylint: vdsm:caps.py convert output to string
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: pylint: vdsm:caps.py convert output to string
......................................................................
pylint: vdsm:caps.py convert output to string
************* Module caps
E:187,35:osversion: Instance of 'list' has no 'splitlines' member (but some types could not be inferred)
Convert the out object to a string where .splitlines() is defined.
Change-Id: I581b336fa63ea41258d374419fb70970435cdca9
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/caps.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/3438/1
--
To view, visit http://gerrit.ovirt.org/3438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I581b336fa63ea41258d374419fb70970435cdca9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years
Change in vdsm[master]: Fix pylint error in BindingXMLPRC
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: Fix pylint error in BindingXMLPRC
......................................................................
Fix pylint error in BindingXMLPRC
************* Module BindingXMLRPC
E:848,27:wrapApiMethod.wrapper: Module 'logging' has no 'TRACE' member
Replace logging.TRACE with logging.CRITICAL which is a supported value.
Change-Id: I957bc2b6aff62ac0e450a8e712384acf0e7adbd8
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/3437/1
--
To view, visit http://gerrit.ovirt.org/3437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I957bc2b6aff62ac0e450a8e712384acf0e7adbd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
12 years
Change in vdsm[master]: Don't escape colors if not a tty
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Don't escape colors if not a tty
......................................................................
Don't escape colors if not a tty
Change-Id: I030ce56796a8b26547fa52f952c5b0dbeb091ee8
---
M tests/testrunner.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/3409/1
--
To view, visit http://gerrit.ovirt.org/3409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I030ce56796a8b26547fa52f952c5b0dbeb091ee8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years
Change in vdsm[master]: define two tests as slowtest
by ykaplan＠redhat.com
Yeela Kaplan has uploaded a new change for review.
Change subject: define two tests as slowtest
......................................................................
define two tests as slowtest
Change-Id: I26cba46b5292eafe9d007cc16946a67732b2c582
---
M tests/processPoolTests.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/3404/1
--
To view, visit http://gerrit.ovirt.org/3404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26cba46b5292eafe9d007cc16946a67732b2c582
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
12 years
Change in vdsm[master]: Add slowtests plugin
by smizrahi＠redhat.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Add slowtests plugin
......................................................................
Add slowtests plugin
Plugin slowtests
Skips tests that might be too slow to be run for quick iteration
builds
Options:
--without-slow-tests
Some tests might take a long time to run, use this to skip slow
tests automatically. [NOSE_DISABLE_SLOW_TESTS]
Ergo, you can set the aforementioned env variable to have make skip slow
tests. As what a "slow test" is debatable I just marked one test as
slow. The rest will have to be suggested in future patches and
go through the regular review process before deemed slow.
To mark a test a slow use the slowtest decorator from the
testValidation module.
Change-Id: I152f9fd479175bf11d9946d8269884fa95959c17
---
M tests/resourceManagerTests.py
M tests/testValidation.py
M tests/testrunner.py
3 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/3342/1
--
To view, visit http://gerrit.ovirt.org/3342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I152f9fd479175bf11d9946d8269884fa95959c17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years
