Change in vdsm[master]: Clean the RHEVM parser help in deployUtil.py.in
by shaohef＠linux.vnet.ibm.com
ShaoHe Feng has uploaded a new change for review.
Change subject: Clean the RHEVM parser help in deployUtil.py.in
......................................................................
Clean the RHEVM parser help in deployUtil.py.in
Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/3838/1
--
To view, visit http://gerrit.ovirt.org/3838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c3aa29a16fb9264f5eeb15bae9404cab70327aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
11 years
Change in vdsm[master]: Let LC_ALL=C when running tests
by zhshzhou＠linux.vnet.ibm.com
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Let LC_ALL=C when running tests
......................................................................
Let LC_ALL=C when running tests
The function validateDDBytes() in vdsm/storage/misc.py needs C locale.
When vdsm runs /bin/dd, the stderr output of /bin/dd is inspected by
validateDDBytes(). Then the last line of the output is splitted by space
and the 0th word is the total count of bytes transferred. In a locale
like zh_CN.utf8(Chinese), the stderr output message is different from
that in C locale. Although dd runs successfully, validateDDBytes() can
not take out the count of the bytes transferred, and an exception
will be raised.
When vdsmd is started by vdsmd.init, LC_ALL is set to C to provide a
compatible locale for vdsmd. However, when running tests, the locale is
not set to C. So "make check" will fail in a zh_CN.utf8 locale in all
tests related to dd, and this causes "autobuild.sh" and "make rpm" fail
as well. So, set LC_ALL=C will provide a standard locale for running the
tests.
Change-Id: I93176e8948aea11cb6adf11d8dc295e43bb1dfee
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M tests/run_tests.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/4243/1
--
To view, visit http://gerrit.ovirt.org/4243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93176e8948aea11cb6adf11d8dc295e43bb1dfee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
11 years
Change in vdsm[master]: Add unit tests to lsblk
by ewoud＠kohlvanwijngaarden.nl
Ewoud Kohl van Wijngaarden has uploaded a new change for review.
Change subject: Add unit tests to lsblk
......................................................................
Add unit tests to lsblk
Change-Id: I9129e90a4bcb78929810c6f069dfb5b839af01d3
---
A tests/vdsm/test_lsblk.py
1 file changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/2840/1
--
To view, visit http://gerrit.ovirt.org/2840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9129e90a4bcb78929810c6f069dfb5b839af01d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
11 years
Change in vdsm[master]: Set the correct gid for libvirt-spice
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Set the correct gid for libvirt-spice
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
How come this has been working until now?
--
To view, visit http://gerrit.ovirt.org/4250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2146f6882e001f4537564748ac401e3f4eab760c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
11 years
Change in vdsm[master]: Revert "Avoid to activate parent volume on cloning"
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Revert "Avoid to activate parent volume on cloning"
......................................................................
Revert "Avoid to activate parent volume on cloning"
This reverts commit 8f5edaea39141cc6174dffce33108596a4643d1e.
Many volumes created with a previous VDSM version have a mismatch
in the size advertised by the metadata and the virtual size defined
in the the qcow2 header. At the moment the only solution is reverting
to the hold behavior and propagate the mismatch (BZ#811880).
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0
---
M vdsm/storage/volume.py
1 file changed, 13 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/4118/1
--
To view, visit http://gerrit.ovirt.org/4118
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years
Change in vdsm[master]: Set the correct gid for libvirt-spice
by Federico Simoncelli
Federico Simoncelli has posted comments on this change.
Change subject: Set the correct gid for libvirt-spice
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1191: except OSError, e:
This pattern is pretty common (in a slightly less correct form using os.path.exists). It should be unified someday.
--
To view, visit http://gerrit.ovirt.org/4250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2146f6882e001f4537564748ac401e3f4eab760c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
11 years
Change in vdsm[master]: Add unit tests to lsblk
by ewoud＠kohlvanwijngaarden.nl
Ewoud Kohl van Wijngaarden has uploaded a new change for review.
Change subject: Add unit tests to lsblk
......................................................................
Add unit tests to lsblk
Change-Id: I0e3c0b8fcfe396a4d15687a2ff55750cfebd3b9d
Signed-off-by: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
---
M tests/Makefile.am
A tests/lsblkTests.py
2 files changed, 44 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/4249/1
--
To view, visit http://gerrit.ovirt.org/4249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e3c0b8fcfe396a4d15687a2ff55750cfebd3b9d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
11 years
Change in vdsm[master]: BZ#815825: deployUtil Do not overwrite cacert.pem
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: BZ#815825: deployUtil Do not overwrite cacert.pem
......................................................................
BZ#815825: deployUtil Do not overwrite cacert.pem
Instead of remove the current cacert.pem, let's backup it.
In case of the host doesn't get approved during the registration process
by Engine administrator, the next reboot vdsmcert.pem won't validate
cacert.pem issuer and will make libvirt daemon fail to start.
Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/3883/1
--
To view, visit http://gerrit.ovirt.org/3883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8569b5379ec8af7ad2e6dcafb2eef1fe47ab890
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
11 years
[RFC] vdsm/libvirtvm.py: spice channels: send correct names
by Alon Levy
Old code used to remove the first char unconditionally. This requires a
hack in the vdsm user (i.e. ovirt engine) to keep sending the leading
's', even though upstream spice has stopped using the first char to
signify secure channel, and passes instead a specific message for that
purpose. Change the logic to only remove 's' from the specific legacy
channel names. This will not break old clients that only know about the
six channels, [main, inputs, display, cursor, playback, record].
Signed-off-by: Alon Levy <alevy(a)redhat.com>
---
vdsm/libvirtvm.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index 5a4d1bc..df06393 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -778,6 +778,12 @@ class _DomXML:
<target type='virtio' name='com.redhat.spice.0'/>
</channel>
"""
+ legacy_s_prefixed_channels = ['smain', 'sinputs', 'sdisplay', 'scursor',
+ 'splayback', 'srecord']
+ def plainChannelName(channel):
+ if channel in legacy_s_prefixed_channels:
+ return channel[1:]
+ return channel
graphics = self.doc.createElement('graphics')
if self.conf['display'] == 'vnc':
graphics.setAttribute('type', 'vnc')
@@ -791,7 +797,7 @@ class _DomXML:
if self.conf.get('spiceSecureChannels'):
for channel in self.conf['spiceSecureChannels'].split(','):
m = self.doc.createElement('channel')
- m.setAttribute('name', channel[1:])
+ m.setAttribute('name', plainChannelName(channel))
m.setAttribute('mode', 'secure')
graphics.appendChild(m)
--
1.7.10.1
11 years
Change in vdsm[master]: FIXUP BZ#788640 - Check move image conditions from SD data. ...
by ewarszaw＠redhat.com
Eduardo has uploaded a new change for review.
Change subject: FIXUP BZ#788640 - Check move image conditions from SD data. Fixing bad len condition
......................................................................
FIXUP BZ#788640 - Check move image conditions from SD data.
Fixing bad len condition
Change-Id: I92be5dd0cdd5972bb8506d5c90771743caeefe0f
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/4204/1
--
To view, visit http://gerrit.ovirt.org/4204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92be5dd0cdd5972bb8506d5c90771743caeefe0f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
11 years
