Alon Bar-Lev has uploaded a new change for review.
Change subject: cleanup: do not use external program ipcalc for ip validation
......................................................................
cleanup: do not use external program ipcalc for ip validation
IPv4 addresses are simple to parse and validate. No need to execute
external process for the task.
Especially if process is not supported by all platforms, and it has no
added value.
$ ipcalc -c -4 0.0.0.0 && echo ok
ok
$ ipcalc -c -4 255.255.255.255 && echo ok
ok
$ ipcalc -c -m -4 1.1.1.1 && echo ok
ok
Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 16 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/6929/1
--
To view, visit http://gerrit.ovirt.org/6929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7d5a6515591147cfc86c9279f69da44f94a9872
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) 'init' is an internal state and is never exposed
......................................................................
(Schema) 'init' is an internal state and is never exposed
Change-Id: I6a947b497d34bd4ddd5ca69cf5e7d80c9a0e181b
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/6965/1
--
To view, visit http://gerrit.ovirt.org/6965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a947b497d34bd4ddd5ca69cf5e7d80c9a0e181b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove HexStr alias
......................................................................
(Schema) Remove HexStr alias
Most languages have their own way of representing hexadecimal literals.
This will make sure we don't have to define how we parse hex values and
making users implement formatters.
Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/6840/1
--
To view, visit http://gerrit.ovirt.org/6840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22bdbe48915a33994550383977f2ffd0a81f36c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: (Schema) Remove varius bool versions, final API will just use boolean values
......................................................................
(Schema) Remove varius bool versions, final API will just use boolean values
Change-Id: I7571de658ee2520d458c5a2d4616729a4cea66fe
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 16 insertions(+), 55 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/6839/1
--
To view, visit http://gerrit.ovirt.org/6839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7571de658ee2520d458c5a2d4616729a4cea66fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Shu Ming has uploaded a new change for review.
Change subject: Fix the parameter descriptions in create() method of storage domain class
......................................................................
Fix the parameter descriptions in create() method of storage domain class
Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab
Signed-off-by: Shu Ming <shuming(a)linux.vnet.ibm.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/localFsSD.py
M vdsm/storage/nfsSD.py
3 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/6636/1
--
To view, visit http://gerrit.ovirt.org/6636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ideb1d85c8fc84adf6d3982499a5a04841373e5ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com>