vdsm-patches August 2012

vdsm-patches@lists.fedorahosted.org

61 participants
390 discussions

Change in vdsm[master]: Avoid template deactivation and lock.
by ewarszaw＠redhat.com 28 Apr '14

28 Apr '14

Eduardo has uploaded a new change for review. Change subject: Avoid template deactivation and lock. ...................................................................... Avoid template deactivation and lock. Change-Id: Ieedf863ac967f34405f038201bac324c52fbbe89 --- M vdsm/storage/blockVolume.py M vdsm/storage/volume.py 2 files changed, 39 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/863/1 -- To view, visit http://gerrit.ovirt.org/863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieedf863ac967f34405f038201bac324c52fbbe89 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

6 9

Change in vdsm[master]: [WIP] Add the validateImage command to the SPM
by Federico Simoncelli 28 Apr '14

28 Apr '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the validateImage command to the SPM ...................................................................... [WIP] Add the validateImage command to the SPM Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8 --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sp.py M vdsm/storage/volume.py 6 files changed, 60 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/3491/1 -- To view, visit http://gerrit.ovirt.org/3491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

6 8

Change in vdsm[master]: [WIP] Add new repository management code
by smizrahi＠redhat.com 08 Apr '14

08 Apr '14

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] Add new repository management code ...................................................................... [WIP] Add new repository management code Change-Id: Ib09c89cf982b475f45d26b2428fe05e2f4565dab Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- M tests/Makefile.am A tests/imageMainuplatorTests.py A tests/repositoryEngineTests.py A vdsm/storage/imageRepository/engines/__init__.py A vdsm/storage/imageRepository/engines/localfs/__init__.py A vdsm/storage/imageRepository/imageManipulator.py 6 files changed, 1,339 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/6247/1 -- To view, visit http://gerrit.ovirt.org/6247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib09c89cf982b475f45d26b2428fe05e2f4565dab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

3 9

Change in vdsm[master]: Add create operation to qemu-img
by smizrahi＠redhat.com 08 Apr '14

08 Apr '14

Saggi Mizrahi has uploaded a new change for review. Change subject: Add create operation to qemu-img ...................................................................... Add create operation to qemu-img Change-Id: I078afcb0899792805584fc56832747d36908f18b Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- M vdsm/qemuImg.py 1 file changed, 29 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/6245/1 -- To view, visit http://gerrit.ovirt.org/6245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I078afcb0899792805584fc56832747d36908f18b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

8 18

Change in vdsm[master]: [WIP] Continue moving VM code to it's own module
by smizrahi＠redhat.com 08 Apr '14

08 Apr '14

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] Continue moving VM code to it's own module ...................................................................... [WIP] Continue moving VM code to it's own module Change-Id: I374dae67449f65c7c55ed028bd301be8b6a01eb5 Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- M vdsm/API.py 1 file changed, 16 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/7514/1 diff --git a/vdsm/API.py b/vdsm/API.py index aab69cd..e6a1048 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -136,15 +136,18 @@ for methName in GUEST_AGENT_METHODS: self.setattr(attrName, partial(guestTrampoline, methName)) + def _getVmObject(self): + return self._cif.vmContainer.get(self._UUID) + def _runThinMethod(self, methodName, *args, **kwargs): - v = self._cif.vmContainer.get(self._UUID) + v = self._getVmObject() if not v: return errCode['noVM'] return getattr(v, methodName)(*args, **kwargs) def _runGuestAgentMethod(self, methodName, *args, **kwargs): - v = self._cif.vmContainer.get(self._UUID) + v = self._getVmObject() if v is None: return errCode['noVM'] @@ -163,7 +166,7 @@ """ vmParams['vmId'] = self._UUID try: - if self._cif.vmContainer.get(self._UUID) is not None: + if self._getVmObject() is not None: self.log.warning('vm %s already exists' % vmParams['vmId']) return errCode['exist'] @@ -286,7 +289,7 @@ """ Obtain statistics of the specified VM """ - v = self._cif.vmContainer.get(self._UUID) + v = self._getVmObject() if not v: return errCode['noVM'] stats = v.getStats().copy() @@ -364,7 +367,7 @@ """ params['vmId'] = self._UUID self.log.debug(params) - v = self._cif.vmContainer.get(self._UUID) + v = self._getVmObject() if v is None: return errCode['noVM'] @@ -395,7 +398,7 @@ self.log.debug('Migration create - Failed') return response - v = self._cif.vmContainer.get(self._UUID) + v = self._getVmObject() if not v.waitForMigrationDestinationPrepare(): return errCode['createErr'] @@ -921,12 +924,14 @@ return d else: return {'vmId': d['vmId'], 'status': d['status']} - # To improve complexity, convert 'vms' to set(vms) - vmSet = set(vmList) + + if vmList: + vms = (self._cif.vmContainer.get(vm) for vm in vmList) + else: + vms = self._cif.vmContainer.getVMs() + return {'status': doneCode, - 'vmList': [reportedStatus(v, fullStatus) - for v in self._cif.vmContainer.getVMs() - if not vmSet or v.id in vmSet]} + 'vmList': [reportedStatus(vm, fullStatus) for vm in vms]} # Networking-related functions def setupNetworks(self, networks={}, bondings={}, options={}): -- To view, visit http://gerrit.ovirt.org/7514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I374dae67449f65c7c55ed028bd301be8b6a01eb5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

3 3

Change in vdsm[master]: [WIP] Added getStorageDevices verb.
by barumuga＠redhat.com 17 Mar '14

17 Mar '14

Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/3725 to review the following change. Change subject: [WIP] Added getStorageDevices verb. ...................................................................... [WIP] Added getStorageDevices verb. This verb is used to get list of storage devices in the node. Return value is a dictionary, its keys are device names and values are properties of those devices as dictionary. {DEVNAME: {'container': CONTAINER_DEVNAME, 'contentType': CONTENT_TYPE_STRING, 'endSize': SIZE_MB, 'flagList': STRING_LIST, 'fsSize': SIZE_MB, 'fsSizeFree': SIZE_MB, 'fsType': STRING, 'fsUuid': UUID, 'members': DEVNAME_LIST, 'model': STRING, 'mountPoint': STRING, 'name': DEVNAME, 'origin': LV_DEVNAME, 'parent': PARENT_DEVNAME, 'partitions': DEVNAME_LIST, 'size': SIZE_MB, 'sizeFree': SIZE_MB, 'startSize': SIZE_MB, 'status': STATUS_STRING, 'tableType': DISK_TABLE_TYPE, 'type': TYPE_STRING, 'uuid': UUID, 'vendor': STRING},...} here, property dictionary contains container: If DEVNAME is used by another device eg. LVM PV, MD etc, name of that device is set contentType: This is determined by various other properties. Possible value is one of 'SWAP', 'OS', 'DATA' and 'NA' endSize: If DEVNAME is a partition, its end boundry is set. The value is in MB flagList: If DEVNAME is a partition, its flags(eg. boot,bios_grub etc) are set as a list of strings fsSize: If DEVNAME has a file system, its size is set. The value is in MB fsSizeFree: If DEVNAME is mounted, its free size is set. The value is in MB fsType: If DEVNAME is formatted, its file system type is set fsUuid': If DEVNAME has file system, its UUID is set members: If DEVNAME is a MD, LVM VG etc, its member device names are set as list of strings model: Model of DEVNAME is set as string mountPoint: If DEVNAME is mounted, its mount point is set name: DEVNAME is set here for completion origin: If DEVNAME is a snapshot of LV, that LV name is set parent: If DEVNAME is a partition, its disk name is set partitions: If DEVNAME is a disk, its partition names are set as list of strings size: Size of DEVNAME is set. The value is in MB sizeFree: If DEVNAME is VG, its size of free extents is set. If its a partitioned disk, its unallocated size is set. The value is in MB startSize: If DEVNAME is a partition, its start boundry is set. The value is in MB status: This is determined by various other properites of the DEVNAME. Possible value is one of 'UNINITIALIZED', 'NA', 'UNUSABLE', 'FORMAT_UNSUPPORTED', 'MOUNTED', 'FORMATTED' and 'PARTED' tableType': If DEVNAME is a disk, its table(label) type is set as a string type: This is determined value. Possible value is one of 'MD', 'LVM_VG', 'LVM_LV_SNAPSHOT', 'LVM_LV' and 'BLOCK' uuid: UUID of DEVNAME vendor: Vendor of DEVNAME is set as string Change-Id: I2cb217321a7a8dfcd1b507c7cba2888f08612207 Signed-off-by: Bala.FA <barumuga(a)redhat.com> --- M vdsm.spec.in M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/Makefile.am A vdsm/storage_device_utils.py M vdsm_cli/vdsClient.py 6 files changed, 505 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/3725/1 -- To view, visit http://gerrit.ovirt.org/3725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2cb217321a7a8dfcd1b507c7cba2888f08612207 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>

6 11

Change in vdsm[master]: confNet: ifcfg's VLAN should be set only on vlan cfg
by Dan Kenigsberg 20 Feb '14

20 Feb '14

Dan Kenigsberg has uploaded a new change for review. Change subject: confNet: ifcfg's VLAN should be set only on vlan cfg ...................................................................... confNet: ifcfg's VLAN should be set only on vlan cfg If a misguided script calls addNetwork with explicit VLAN option, it sohuld not be blindly copied to the top-most device. We set VLAN=yes on the ifcfg script for the vlan device, and that's that. Change-Id: Ia2c9d6c86e73104424ca8ac901bf09e4b98a47ab Bug-Id: BZ#847733 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/7411/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 3f99a66..2ef0a8a 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -384,7 +384,7 @@ if mtu: cfg = cfg + 'MTU=%d\n' % mtu cfg += 'NM_CONTROLLED=no\n' - BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'bondingOptions', + BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'VLAN', 'bondingOptions', 'force', 'blockingdhcp', 'connectivityCheck', 'connectivityTimeout', 'implicitBonding'] -- To view, visit http://gerrit.ovirt.org/7411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2c9d6c86e73104424ca8ac901bf09e4b98a47ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

6 14

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool
by lvroyce＠linux.vnet.ibm.com 18 Feb '14

18 Feb '14

Royce Lv has uploaded a new change for review. Change subject: avoid redundant domain produce() in createStoragePool ...................................................................... avoid redundant domain produce() in createStoragePool Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 4 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/7347/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 2227c03..b2c20c0 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -765,19 +765,6 @@ if msdType in sd.BLOCK_DOMAIN_TYPES and msdVersion in blockSD.VERS_METADATA_LV and len(domList) > sp.MAX_DOMAINS: raise se.TooManyDomainsInStoragePoolError() - for sdUUID in domList: - try: - dom = sdCache.produce(sdUUID=sdUUID) - # TODO: consider removing validate() from here, as the domains - # are going to be accessed much later, and may loose validity - # until then. - dom.validate() - except: - raise se.StorageDomainAccessError(sdUUID) - #If you remove this condition, remove it from StoragePool.attachSD() too. - if dom.isData() and (dom.getVersion() != msdVersion): - raise se.MixedSDVersionError(dom.sdUUID, dom.getVersion(), msd.sdUUID, msdVersion) - vars.task.getExclusiveLock(STORAGE, spUUID) for dom in sorted(domList): vars.task.getExclusiveLock(STORAGE, dom) diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index ee45151..a5b65c7 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -549,6 +549,7 @@ domain.validate() if sdUUID == msdUUID: msd = domain + msdVersion = msd.getVersion() except se.StorageException: self.log.error("Unexpected error", exc_info=True) raise se.StorageDomainAccessError(sdUUID) @@ -560,6 +561,9 @@ # Non ISO domains have only 1 pool if len(spUUIDs) > 0: raise se.StorageDomainAlreadyAttached(spUUIDs[0], sdUUID) + + if domain.isData() and (domain.getVersion() != msdVersion): + raise se.MixedSDVersionError(domain.sdUUID, domain.getVersion(), msd.sdUUID, msdVersion) fileUtils.createdir(self.poolPath) self._acquireTemporaryClusterLock(msdUUID, safeLease) -- To view, visit http://gerrit.ovirt.org/7347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

7 12

Change in vdsm[master]: force reload udev rules to avoid LUN device permission error
by lvroyce＠linux.vnet.ibm.com 14 Jan '14

14 Jan '14

Royce Lv has uploaded a new change for review. Change subject: force reload udev rules to avoid LUN device permission error ...................................................................... force reload udev rules to avoid LUN device permission error udev rules creat symlink for LUN device making it usable for qemu but the rules are not instantly loaded by udev result in LUN device symlink not created before vm run force reload to make the rules take effect instantly Change-Id: I718d62e67b0a228f2510233c5dd9d1d94c4a736c Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M vdsm/storage/hsm.py M vdsm/supervdsmServer.py 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/6780/1 -- To view, visit http://gerrit.ovirt.org/6780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I718d62e67b0a228f2510233c5dd9d1d94c4a736c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

8 21

Change in vdsm[master]: Encapsulate vdsm-unregister into vdsm-tool function
by lilei＠linux.vnet.ibm.com 14 Jan '14

14 Jan '14

Lei Li has uploaded a new change for review. Change subject: Encapsulate vdsm-unregister into vdsm-tool function ...................................................................... Encapsulate vdsm-unregister into vdsm-tool function Change-Id: I7348baeabbdcbb0c2da64170b6957430feaa1954 Signed-off-by: Lei Li <lilei(a)linux.vnet.ibm.com> --- M vdsm-tool/Makefile.am A vdsm-tool/register.py M vdsm.spec.in 3 files changed, 43 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/4527/1 -- To view, visit http://gerrit.ovirt.org/4527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7348baeabbdcbb0c2da64170b6957430feaa1954 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>

6 9

← Newer
1
2
3
4
5
6
7
8
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches August 2012