vdsm-patches August 2012

vdsm-patches@lists.fedorahosted.org

61 participants
390 discussions

Change in vdsm[master]: move the implement of storage related api to hsm
by Xu He Jie 26 Dec '12

26 Dec '12

Xu He Jie has uploaded a new change for review. Change subject: move the implement of storage related api to hsm ...................................................................... move the implement of storage related api to hsm Change-Id: Iff7969ac4aa17d52741a5b46c00efd62fc0f9dc6 Signed-off-by: Xu He Jie <xuhj(a)linux.vnet.ibm.com> --- M vdsm/API.py M vdsm/storage/hsm.py 2 files changed, 469 insertions(+), 178 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/5526/1 -- To view, visit http://gerrit.ovirt.org/5526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iff7969ac4aa17d52741a5b46c00efd62fc0f9dc6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com>

2 3

Change in vdsm[master]: move VM api implement to vmm module
by Xu He Jie 26 Dec '12

26 Dec '12

Xu He Jie has uploaded a new change for review. Change subject: move VM api implement to vmm module ...................................................................... move VM api implement to vmm module Create a vmm module to manage vm stuff. clientIF will instance VMM and VMM will regist it's API implement to API layer. After all API implement move to submodule, we don't need passing clientIF to anywhere and any global object. * create vmm module to manager vm * move VM api implement to vmm module Change-Id: Ib27a0e9300b55f25fa81d66d1055688122bb33db Signed-off-by: Xu He Jie <xuhj(a)linux.vnet.ibm.com> --- M vdsm.spec.in M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/Makefile.am M vdsm/clientIF.py A vdsm/vmm.py 6 files changed, 854 insertions(+), 598 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/5525/1 -- To view, visit http://gerrit.ovirt.org/5525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib27a0e9300b55f25fa81d66d1055688122bb33db Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com>

2 3

Change in vdsm[master]: add api registeration mechanism
by Xu He Jie 26 Dec '12

26 Dec '12

Xu He Jie has uploaded a new change for review. Change subject: add api registeration mechanism ...................................................................... add api registeration mechanism add registAPI method, then other modules can implement the api and regist their implement to API.py. *add api registeration mechanism *add Base class for add ABCMeta as metaclass *add class decorator for add abstractmethod for every public method. this can limit people to implement the api as interface. *add PartialProxy it similar as functools.partial, but this can access class member Change-Id: I8eabbec2526041e548591b62252d754b1f5934b5 Signed-off-by: Xu He Jie <xuhj(a)linux.vnet.ibm.com> --- A tests/apiTests.py M vdsm/API.py 2 files changed, 119 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/5524/1 -- To view, visit http://gerrit.ovirt.org/5524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8eabbec2526041e548591b62252d754b1f5934b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie <xuhj(a)linux.vnet.ibm.com>

3 4

Change in vdsm[master]: Related to BZ#843387 - Payload should set volPath or raise.
by ewarszaw＠redhat.com 24 Dec '12

24 Dec '12

Eduardo has uploaded a new change for review. Change subject: Related to BZ#843387 - Payload should set volPath or raise. ...................................................................... Related to BZ#843387 - Payload should set volPath or raise. Change-Id: I0d5b36a88752ad2191226191c9502c1717033bbc Signed-off-by: Eduardo <ewarszaw(a)redhat.com> --- M vdsm/clientIF.py 1 file changed, 10 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/6803/1 -- To view, visit http://gerrit.ovirt.org/6803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d5b36a88752ad2191226191c9502c1717033bbc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

10 26

Change in vdsm[master]: add general test to be compatible for xmlrpc and rest
by lvroyce＠linux.vnet.ibm.com 16 Dec '12

16 Dec '12

Royce Lv has uploaded a new change for review. Change subject: add general test to be compatible for xmlrpc and rest ...................................................................... add general test to be compatible for xmlrpc and rest this allow xmlrpc and rest to share common functional testcases and different binding to handle their own interface use def file to make test case dynamically changable Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M configure.ac M tests/functional/Makefile.am A tests/functional/SampleDef/Makefile.am A tests/functional/SampleDef/testBindingUp.def A tests/functional/defLoader.py A tests/functional/generalTest.py M vdsm.spec.in 7 files changed, 121 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/5308/1 -- To view, visit http://gerrit.ovirt.org/5308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00449f9c22800e2b00109990a7e535da986c5d48 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

3 7

Change in vdsm[master]: Specify the ACPI flag when shutting down VMs
by Federico Simoncelli 05 Dec '12

05 Dec '12

Federico Simoncelli has uploaded a new change for review. Change subject: Specify the ACPI flag when shutting down VMs ...................................................................... Specify the ACPI flag when shutting down VMs In commit e460308 has been introduced the qemu guest agent support. When such agent channel is present the default shutdown method uses the guest agent (which might be missing). For consistency and to maintain the old behavior we should specify to use ACPI to shutdown the guest. Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/6996/1 -- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 26

Change in vdsm[master]: Fix return value of shutdown() on failure
by wudxw＠linux.vnet.ibm.com 04 Dec '12

04 Dec '12

Mark Wu has uploaded a new change for review. Change subject: Fix return value of shutdown() on failure ...................................................................... Fix return value of shutdown() on failure Change-Id: Ice01a8db664c8c1a3ca32c15de4865f362e7210e Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com> --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/5434/1 -- To view, visit http://gerrit.ovirt.org/5434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ice01a8db664c8c1a3ca32c15de4865f362e7210e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>

8 17

Change in vdsm[master]: use default libvirt event handler impl
by lvroyce＠linux.vnet.ibm.com 04 Dec '12

04 Dec '12

Royce Lv has uploaded a new change for review. Change subject: use default libvirt event handler impl ...................................................................... use default libvirt event handler impl use default libvirt event handler implementation and event loop add setKeepAlive to avoid some buggy condition in libvirt connection Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7 Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M vdsm/libvirtconnection.py M vdsm/libvirtev.py 2 files changed, 23 insertions(+), 486 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/5015/1 -- To view, visit http://gerrit.ovirt.org/5015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

6 27

Change in vdsm[master]: bz#849886 allow multilib in bootstrap when download package
by lvroyce＠linux.vnet.ibm.com 03 Dec '12

03 Dec '12

Royce Lv has uploaded a new change for review. Change subject: bz#849886 allow multilib in bootstrap when download package ...................................................................... bz#849886 allow multilib in bootstrap when download package Change-Id: Id0574afc94c038f7b53b890bae875cf66d9b58f1 Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M vds_bootstrap/vds_bootstrap.py M vdsm_reg/deployUtil.py.in 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/7383/1 diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py index 8211c81..59230f2 100755 --- a/vds_bootstrap/vds_bootstrap.py +++ b/vds_bootstrap/vds_bootstrap.py @@ -443,9 +443,10 @@ def _installPackage(self, pack, type, update=0): nReturn = 0 + option = "--setopt=protected_multilib=false" logging.debug('Installing %s %d',pack, update ) if type == "REQ" or type == "DEVEL": - self.res, self.message = deployUtil.installAndVerify(type, pack, "install") + self.res, self.message = deployUtil.installAndVerify(type, pack, "install", option) res = "OK" if not self.res: res = "FAIL" @@ -456,7 +457,7 @@ if update == 1: yumcmd = "update" - self.res, self.message = deployUtil.installAndVerify(type, pack, yumcmd) + self.res, self.message = deployUtil.installAndVerify(type, pack, yumcmd, option) res = "OK" if not self.res: res = "FAIL" @@ -468,7 +469,7 @@ yumcmd = "update" self.res, self.message = deployUtil.installAndVerify(type, pack, - yumcmd) + yumcmd, option) res = "OK" if not self.res: res = "FAIL" diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in index e22bfb5..af37547 100644 --- a/vdsm_reg/deployUtil.py.in +++ b/vdsm_reg/deployUtil.py.in @@ -1015,7 +1015,7 @@ """ execFunc = [EX_YUM, "-y"] if args is not None: - execFunc += args + execFunc.append(args) if action == "install": execFunc.append(action) @@ -1033,7 +1033,7 @@ a package, and then verify it. """ fReturn = True - out, err, ret = yumInstallDeleteUpdate(pckgName, action, args=None) + out, err, ret = yumInstallDeleteUpdate(pckgName, action, args) msg = None if not ret: fReturn, msg = getPackageInfo(pckgType, pckgName, 'install') -- To view, visit http://gerrit.ovirt.org/7383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id0574afc94c038f7b53b890bae875cf66d9b58f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

2 2

Change in vdsm[master]: added glusterVolumeProfileInfo verb
by tjeyasin＠redhat.com 03 Dec '12

03 Dec '12

Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/7436 to review the following change. Change subject: added glusterVolumeProfileInfo verb ...................................................................... added glusterVolumeProfileInfo verb Following is the output structure { 'statusCode' : CODE, 'volumeName' : VOLUME-NAME, 'brickCount' : BRICK-COUNT, 'bricks' : { BRICK-NAME: { 'cumulativeStats': { 'blockStat': [ { 'size': SIZE, 'read': READ-COUNT, 'write': WRITE-COUNT }, ...], 'fopStat': [ { 'name': FOP-NAME, 'hits': HITS, 'latencyAvg': AVERAGE-LATENCY, 'latencyMin': MINIMUM-LATENCY, 'latencyMax': MAXIMUM-LATENCY }, ...], 'duration': DURATION, 'totalRead': TOTAL-READ, 'totalWrite': TOTAL-WRITE }, 'intervalStats': { 'blockStat': [ { 'size': SIZE, 'read': READ-COUNT, 'write': WRITE-COUNT }, ...], 'fopStat': [ { 'name': FOP-NAME, 'hits': HITS, 'latencyAvg': AVERAGE-LATENCY, 'latencyMin': MINIMUM-LATENCY, 'latencyMax': MAXIMUM-LATENCY }, ...], 'duration': DURATION, 'totalRead': TOTAL-READ, 'totalWrite': TOTAL-WRITE }}, ...}} Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm_cli/vdsClientGluster.py 4 files changed, 81 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/7436/1 diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py index dc3ec0b..9073791 100644 --- a/vdsm/gluster/api.py +++ b/vdsm/gluster/api.py @@ -229,6 +229,11 @@ def volumeProfileStop(self, volumeName, options=None): self.svdsmProxy.glusterVolumeProfileStop(volumeName) + @exportAsVerb + def volumeProfileInfo(self, volumeName, options=None): + status = self.svdsmProxy.glusterVolumeProfileInfo(volumeName) + return {'profileInfo': status} + def getGlusterMethods(gluster): l = [] diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py index 2618aa1..059bff4 100644 --- a/vdsm/gluster/cli.py +++ b/vdsm/gluster/cli.py @@ -155,6 +155,54 @@ return volumeInfoDict +def _parseGlusterVolumeProfileInfo(tree): + fopCumulative = [] + blkCumulative = [] + fopInterval = [] + blkInterval = [] + bricks = {} + for brick in tree.findall('volProfile/brick'): + for block in brick.findall('cumulativeStats/blockStats/block'): + blkCumulative.append({'size': block.find('size').text, + 'read': block.find('reads').text, + 'write': block.find('writes').text}) + for fop in brick.findall('cumulativeStats/fopStats/fop'): + fopCumulative.append({'name': fop.find('name').text, + 'hits': fop.find('hits').text, + 'latencyAvg': fop.find('avgLatency').text, + 'latencyMin': fop.find('minLatency').text, + 'latencyMax': fop.find('maxLatency').text}) + for block in brick.findall('intervalStats/blockStats/block'): + blkInterval.append({'size': block.find('size').text, + 'read': block.find('reads').text, + 'write': block.find('writes').text}) + for fop in brick.findall('intervalStats/fopStats/fop'): + fopInterval.append({'name': fop.find('name').text, + 'hits': fop.find('hits').text, + 'latencyAvg': fop.find('avgLatency').text, + 'latencyMin': fop.find('minLatency').text, + 'latencyMax': fop.find('maxLatency').text}) + bricks[brick.find('brickName').text] = { + 'cumulativeStats': { + 'blockStats': blkCumulative, + 'fopStats': fopCumulative, + 'duration': brick.find('cumulativeStats/duration').text, + 'totalRead': brick.find('cumulativeStats/totalRead').text, + 'totalWrite': brick.find('cumulativeStats/totalWrite').text}, + 'intervalStats': { + 'blockStats': blkInterval, + 'fopStats': fopInterval, + 'duration': brick.find('intervalStats/duration').text, + 'totalRead': brick.find('intervalStats/totalRead').text, + 'totalWrite': brick.find('intervalStats/totalWrite').text}} + status = { + 'volumeName': tree.find("volProfile/volname").text, + 'brickCount': tree.find("volProfile/brickCount").text, + 'statusCode': tree.find("opRet").text, + 'bricks': bricks} + return status + + @exportToSuperVdsm def volumeInfo(volumeName=None): """ @@ -577,3 +625,16 @@ if err: raise ge.GlusterVolumeProfileStopFailedException(err[0], err[1]) return True + + +@exportToSuperVdsm +def volumeProfileInfo(volumeName): + command = _getGlusterVolCmd() + ["profile", volumeName, "info"] + err, res = _execGluster(command, xml=True) + if err: + raise ge.GlusterVolumeProfileInfoFailedException(err[0], err[1]) + xmltree, out = res + try: + return _parseGlusterVolumeProfileInfo(xmltree) + except: + raise ge.GlusterXmlErrorException(err=out) diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index f5dfb73..5dea24d 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -328,6 +328,11 @@ message = "Volume profile stop failed" +class GlusterVolumeProfileInfoFailedException(GlusterVolumeException): + code = 4159 + message = "Volume profile info failed" + + # Host class GlusterHostException(GlusterException): code = 4400 diff --git a/vdsm_cli/vdsClientGluster.py b/vdsm_cli/vdsClientGluster.py index 0a253fe..c93a59f 100644 --- a/vdsm_cli/vdsClientGluster.py +++ b/vdsm_cli/vdsClientGluster.py @@ -207,6 +207,11 @@ status = self.s.glusterVolumeProfileStop(args[0]) return status['status']['code'], status['status']['message'] + def do_glusterVolumeProfileInfo(self, args): + status = self.s.glusterVolumeProfileInfo(args[0]) + pp.pprint(status) + return status['status']['code'], status['status']['message'] + def getGlusterCmdDict(serv): return { @@ -373,4 +378,9 @@ ('<volume_name>\n\t<volume_name> is existing volume name', 'stop gluster volume profile' )), + 'glusterVolumeProfileInfo': + (serv.do_glusterVolumeProfileInfo, + ('<volume_name>\n\t<volume_name> is existing volume name', + 'get gluster volume profile info' + )), } -- To view, visit http://gerrit.ovirt.org/7436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

4 30

← Newer
1
...
10
11
12
13
14
15
16
...
39
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches August 2012