vdsm-patches August 2012

vdsm-patches@lists.fedorahosted.org

61 participants
390 discussions

Change in vdsm[master]: [WIP] Remove the domain weakref cache and parallelize _findD...
by Federico Simoncelli 08 Oct '12

08 Oct '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Remove the domain weakref cache and parallelize _findDomain ...................................................................... [WIP] Remove the domain weakref cache and parallelize _findDomain Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=851146 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I8a04babcfbb5620e9e703fe94a1ae681ac300bfb --- M vdsm/storage/sdc.py 1 file changed, 45 insertions(+), 59 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/7511/1 diff --git a/vdsm/storage/sdc.py b/vdsm/storage/sdc.py index 2e8a6ff..e12a6f5 100644 --- a/vdsm/storage/sdc.py +++ b/vdsm/storage/sdc.py @@ -24,7 +24,6 @@ """ import logging import threading -import weakref from vdsm.config import config import multipath @@ -37,15 +36,17 @@ class DomainProxy(object): - """Keeps domain references valid even when underlying domain object changes - (due to format conversion for example""" + """ + Keeps domain references valid even when underlying domain object changes + (due to format conversion for example). + """ + def __init__(self, cache, sdUUID): self._sdUUID = sdUUID self._cache = cache def __getattr__(self, attrName): - dom = self.getRealDomain() - return getattr(dom, attrName) + return getattr(self.getRealDomain(), attrName) def getRealDomain(self): return self._cache._realProduce(self._sdUUID) @@ -54,75 +55,59 @@ class StorageDomainCache: """ Storage Domain List keeps track of all the storage domains accessible by - the current system. """ + the current system. + """ log = logging.getLogger('Storage.StorageDomainCache') def __init__(self, storage_repo): - self._syncroot = threading.RLock() - self.__proxyCache = {} + self._syncroot = threading.Condition() self.__domainCache = {} + self.__inProgress = set() self.storage_repo = storage_repo - self.storageStale = True def invalidateStorage(self): - self.storageStale = True lvm.invalidateCache() @misc.samplingmethod def refreshStorage(self): multipath.rescan() lvm.invalidateCache() - self.storageStale = False - - def _getDomainFromCache(self, sdUUID): - if self.storageStale == True: - return None - try: - return self.__proxyCache[sdUUID]() - except KeyError: - return None - - def _cleanStaleWeakrefs(self): - for sdUUID, ref in self.__proxyCache.items(): - if ref() is None: - del self.__proxyCache[sdUUID] def produce(self, sdUUID): - dom = self._getDomainFromCache(sdUUID) - if dom: - return dom - - with self._syncroot: - dom = self._getDomainFromCache(sdUUID) - if dom: - return dom - - if self.storageStale: - self.refreshStorage() - - self._cleanStaleWeakrefs() - - dom = DomainProxy(self, sdUUID) - # This is needed to preserve the semantic where if the domain was - # absent from the cache and the domain cannot be found the - # operation would fail - dom.getRealDomain() - self.__proxyCache[sdUUID] = weakref.ref(dom) - return dom + domain = DomainProxy(self, sdUUID) + # This is needed to preserve the semantic where if the domain + # was absent from the cache and the domain cannot be found the + # operation would fail. + domain.getRealDomain() + return domain def _realProduce(self, sdUUID): with self._syncroot: - try: - return self.__domainCache[sdUUID] - except KeyError: - pass + while True: + domain = self.__domainCache.get(sdUUID) - # _findDomain will raise StorageDomainDoesNotExist if sdUUID is not - # found in storage. - dom = self._findDomain(sdUUID) - self.__domainCache[sdUUID] = dom - return dom + if domain is not None: + return domain + + if sdUUID not in self.__inProgress: + self.__inProgress.add(sdUUID) + break + + self._syncroot.wait() + + try: + domain = self._findDomain(sdUUID) + + with self._syncroot: + self.__domainCache[sdUUID] = domain + return domain + + finally: + with self._syncroot: + self.__inProgress.remove(sdUUID) + self._syncroot.notifyAll() + def _findDomain(self, sdUUID): import blockSD @@ -157,12 +142,13 @@ return uuids def refresh(self): - self.invalidateStorage() - self.__domainCache.clear() - - def manuallyAddDomain(self, dom): with self._syncroot: - self.__domainCache[dom.sdUUID] = dom + self.invalidateStorage() + self.__domainCache.clear() + + def manuallyAddDomain(self, domain): + with self._syncroot: + self.__domainCache[domain.sdUUID] = domain def manuallyRemoveDomain(self, sdUUID): with self._syncroot: -- To view, visit http://gerrit.ovirt.org/7511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a04babcfbb5620e9e703fe94a1ae681ac300bfb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

5 18

Change in vdsm[master]: Correcting cpuCores stat on multi node systems.
by apahim＠redhat.com 06 Oct '12

06 Oct '12

Amador Pahim has uploaded a new change for review. Change subject: Correcting cpuCores stat on multi node systems. ...................................................................... Correcting cpuCores stat on multi node systems. cpuCores shows the wrong number of cores on multi node systems. Multi node systems has the same combination of "physical id" and "core id" to different physical cores. Vdsm is considering more than one occurrence of same "physical id"/"core id" as the same core. This is useful in order to not account the Hyper Threading instances, but it is not working to the multi-nodes systems. This patch corrects issue changing the source of cpuCores to (sockets number * physical cores per socket). BZ#833425 - vdsm cpuCores shows the wrong number of cores on multi node systems Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M vdsm/caps.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/5481/1 -- To view, visit http://gerrit.ovirt.org/5481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com>

9 62

Change in vdsm[master]: engine.py: fix nodeCleanup() order call
by Douglas Schilling Landgraf 02 Oct '12

02 Oct '12

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: engine.py: fix nodeCleanup() order call ...................................................................... engine.py: fix nodeCleanup() order call Call deployUtil.nodeCleanup() only if oVirt Engine is reachable. Even if oVirt Engine is not reachable it will backup cacert.pem and remove it. However, since we cannot reach the Engine won't be possible to download the new cacert.pem and TUI will break next time someone try to register oVirt Engine. Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M vdsm_reg/engine.py.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/6859/1 -- To view, visit http://gerrit.ovirt.org/6859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>

6 17

Change in vdsm[master]: [WIP] Add ballooning support
by wudxw＠linux.vnet.ibm.com 02 Oct '12

02 Oct '12

Mark Wu has uploaded a new change for review. Change subject: [WIP] Add ballooning support ...................................................................... [WIP] Add ballooning support Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9 Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com> --- M vdsm/API.py M vdsm/define.py M vdsm/libvirtvm.py M vdsm/vm.py 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/3669/1 -- To view, visit http://gerrit.ovirt.org/3669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>

5 35

Change in vdsm[master]: Added glusterVolumeProfileStop verb
by tjeyasin＠redhat.com 02 Oct '12

02 Oct '12

Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/7435 to review the following change. Change subject: Added glusterVolumeProfileStop verb ...................................................................... Added glusterVolumeProfileStop verb Change-Id: Ie25c7da7208eb4bf68f67d945fb7c63b44886040 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm_cli/vdsClientGluster.py 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/7435/1 diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py index 135f4bb..dc3ec0b 100644 --- a/vdsm/gluster/api.py +++ b/vdsm/gluster/api.py @@ -225,6 +225,10 @@ def volumeProfileStart(self, volumeName, options=None): self.svdsmProxy.glusterVolumeProfileStart(volumeName) + @exportAsVerb + def volumeProfileStop(self, volumeName, options=None): + self.svdsmProxy.glusterVolumeProfileStop(volumeName) + def getGlusterMethods(gluster): l = [] diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py index 9d05568..2618aa1 100644 --- a/vdsm/gluster/cli.py +++ b/vdsm/gluster/cli.py @@ -568,3 +568,12 @@ if err: raise ge.GlusterVolumeProfileStartFailedException(err[0], err[1]) return True + + +@exportToSuperVdsm +def volumeProfileStop(volumeName): + command = _getGlusterVolCmd() + ["profile", volumeName, "stop"] + err, res = _execGluster(command, xml=True) + if err: + raise ge.GlusterVolumeProfileStopFailedException(err[0], err[1]) + return True diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index 29078a9..f5dfb73 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -323,6 +323,11 @@ message = "Volume profile start failed" +class GlusterVolumeProfileStopFailedException(GlusterVolumeException): + code = 4158 + message = "Volume profile stop failed" + + # Host class GlusterHostException(GlusterException): code = 4400 diff --git a/vdsm_cli/vdsClientGluster.py b/vdsm_cli/vdsClientGluster.py index 1f5d52a..0a253fe 100644 --- a/vdsm_cli/vdsClientGluster.py +++ b/vdsm_cli/vdsClientGluster.py @@ -203,6 +203,10 @@ status = self.s.glusterVolumeProfileStart(args[0]) return status['status']['code'], status['status']['message'] + def do_glusterVolumeProfileStop(self, args): + status = self.s.glusterVolumeProfileStop(args[0]) + return status['status']['code'], status['status']['message'] + def getGlusterCmdDict(serv): return { @@ -364,4 +368,9 @@ ('<volume_name>\n\t<volume_name> is existing volume name', 'start gluster volume profile' )), + 'glusterVolumeProfileStop': + (serv.do_glusterVolumeProfileStop, + ('<volume_name>\n\t<volume_name> is existing volume name', + 'stop gluster volume profile' + )), } -- To view, visit http://gerrit.ovirt.org/7435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie25c7da7208eb4bf68f67d945fb7c63b44886040 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

4 5

Change in vdsm[master]: Added glusterVolumeProfileStart verb
by tjeyasin＠redhat.com 02 Oct '12

02 Oct '12

Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/7285 to review the following change. Change subject: Added glusterVolumeProfileStart verb ...................................................................... Added glusterVolumeProfileStart verb Change-Id: I279977bb4dc3631162ce22668612103896646afe Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm_cli/vdsClientGluster.py 4 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/7285/1 diff --git a/vdsm/gluster/api.py b/vdsm/gluster/api.py index 576ddf1..47e5675 100644 --- a/vdsm/gluster/api.py +++ b/vdsm/gluster/api.py @@ -221,6 +221,10 @@ """ return {'hosts': self.svdsmProxy.glusterPeerStatus()} + @exportAsVerb + def volumeProfileStart(self, volumeName): + self.svdsmProxy.glusterVolumeProfileStart(volumeName) + def getGlusterMethods(gluster): l = [] diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py index dd79865..5956bbc 100644 --- a/vdsm/gluster/cli.py +++ b/vdsm/gluster/cli.py @@ -543,3 +543,13 @@ else: return _parsePeerStatus(out, _getGlusterHostName(), _getGlusterUuid(), HostStatus.CONNECTED) + + +@exportToSuperVdsm +def volumeProfileStart(volumeName): + command = _getGlusterVolCmd() + ["profile", volumeName, "start"] + rc, out, err = _execGluster(command) + if rc: + raise ge.GlusterVolumeProfileStartFailedException(rc, out, err) + else: + return True diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index 8d48c48..d2ebc1e 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -347,3 +347,8 @@ class GlusterHostListFailedException(GlusterHostException): code = 4407 message = "Host list failed" + + +class GlusterVolumeProfileStartFailedException(GlusterVolumeException): + code = 4408 + message = "Volume profile start failed" diff --git a/vdsm_cli/vdsClientGluster.py b/vdsm_cli/vdsClientGluster.py index e72c424..1f5d52a 100644 --- a/vdsm_cli/vdsClientGluster.py +++ b/vdsm_cli/vdsClientGluster.py @@ -199,6 +199,10 @@ pp.pprint(status) return status['status']['code'], status['status']['message'] + def do_glusterVolumeProfileStart(self, args): + status = self.s.glusterVolumeProfileStart(args[0]) + return status['status']['code'], status['status']['message'] + def getGlusterCmdDict(serv): return { @@ -355,4 +359,9 @@ ('', 'list host info' )), + 'glusterVolumeProfileStart': + (serv.do_glusterVolumeProfileStart, + ('<volume_name>\n\t<volume_name> is existing volume name', + 'start gluster volume profile' + )), } -- To view, visit http://gerrit.ovirt.org/7285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I279977bb4dc3631162ce22668612103896646afe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

4 9

Change in vdsm[master]: [WIP] Added glusterVolumeStatus verb
by barumuga＠redhat.com 02 Oct '12

02 Oct '12

Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/6374 to review the following change. Change subject: [WIP] Added glusterVolumeStatus verb ...................................................................... [WIP] Added glusterVolumeStatus verb Change-Id: I8769c2da299a598ed7500c4780a3329972f4a8ac Signed-off-by: Bala.FA <barumuga(a)redhat.com> --- M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm/gluster/exception.py M vdsm_cli/vdsClientGluster.py 4 files changed, 105 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/6374/1 -- To view, visit http://gerrit.ovirt.org/6374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8769c2da299a598ed7500c4780a3329972f4a8ac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>

6 18

Change in vdsm[master]: [WIP] Add Gobject based libvdsm
by smizrahi＠redhat.com 30 Sep '12

30 Sep '12

Saggi Mizrahi has uploaded a new change for review. Change subject: [WIP] Add Gobject based libvdsm ...................................................................... [WIP] Add Gobject based libvdsm TODO: * Integrate with vdsm * integrate with build system * more generators * self passing in methods To test run `python test_serve.py` and then run `make test` Change-Id: I5e12eb0d1c4aa7de059a0baaa79aeea9cdfbe6dc Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- A libvdsm/Makefile A libvdsm/generate.py A libvdsm/generated.vala.x A libvdsm/libvdsm-base.vala A libvdsm/schema.json A libvdsm/test.py A libvdsm/test_serv.py 7 files changed, 927 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/6659/1 -- To view, visit http://gerrit.ovirt.org/6659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e12eb0d1c4aa7de059a0baaa79aeea9cdfbe6dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

1 1

Change in vdsm[master]: [WIP] drop dead functions
by Dan Kenigsberg 26 Sep '12

26 Sep '12

Dan Kenigsberg has uploaded a new change for review. Change subject: [WIP] drop dead functions ...................................................................... [WIP] drop dead functions The previous patch dropped the only user of these functions. Let us not leave dead code behind. Change-Id: Ib9e75d6612227474775b1dea8eade1684b168915 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm_reg/deployUtil.py.in 1 file changed, 0 insertions(+), 49 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/4882/1 -- To view, visit http://gerrit.ovirt.org/4882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9e75d6612227474775b1dea8eade1684b168915 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 1

Change in vdsm[master]: [WIP] report another unique identity
by Dan Kenigsberg 26 Sep '12

26 Sep '12

Dan Kenigsberg has uploaded a new change for review. Change subject: [WIP] report another unique identity ...................................................................... [WIP] report another unique identity ovirt-engine identifies each hypervisor node according to the uuid reported by getVdsCapabilities. That uuid is combined of the bios-stored host uuid + mac address of the first host nic. The contraction was required since plenty of hosts out there are sold with a non-unique uuid stored in their bios. However, that was a terribly wrong solution, as nics come and go, bond together or simply change their mac address. None of these changes should cause a change of the identity of the node. We cannot just ditch the old solution, since existing installations must keep reporting their old uuid. This patch suggests that on upgrade, vdsm would persist the funny uuid+mac reported by the old vdsm version. On fresh installation, a fresh uuid is generated and persisted. Known issues: - We must not persist the node uuid when creating ovirt-node image. ovirt-node should persist its legacy/sane uuid during boot, based on its being a fresh installation, or an upgrade. - Code untested, probably broken. Change-Id: I35462b23b0b61c2d555500a631eeea65f838f5ab Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm.spec.in M vdsm/caps.py M vdsm/libvirtvm.py M vdsm/utils.py M vdsm_reg/vdsm-reg-setup.in 5 files changed, 22 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/4881/1 -- To view, visit http://gerrit.ovirt.org/4881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I35462b23b0b61c2d555500a631eeea65f838f5ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

4 7

← Newer
1
...
14
15
16
17
18
19
20
...
39
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches August 2012