Change in vdsm[master]: add and use hypervisor autodetection in bootstrap.
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add and use hypervisor autodetection in bootstrap.
......................................................................
Patch Set 3:
Francesco, fell free to add yourself to AUTHORS as well.
Cheers
Douglas
--
To view, visit http://gerrit.ovirt.org/7657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in vdsm[master]: add and use hypervisor autodetection in bootstrap.
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add and use hypervisor autodetection in bootstrap.
......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
Tested with KVM.
--
To view, visit http://gerrit.ovirt.org/7657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in vdsm[master]: Modify getOSVersion to use python 'platform' module
by Pradipta Kumar Banerjee
Pradipta Banerjee has uploaded a new change for review.
Change subject: Modify getOSVersion to use python 'platform' module
......................................................................
Modify getOSVersion to use python 'platform' module
Modify getOSVersion function to use the python 'platform'
module instead of custom file parsing logic
Change-Id: Ia58284ce75dc6d09f0302181ea35ed3817dd861d
Signed-off-by: Pradipta Kr. Banerjee <bpradip(a)in.ibm.com>
---
M vdsm_reg/deployUtil.py.in
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/7930/1
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in
index 55433eb..e181a4b 100644
--- a/vdsm_reg/deployUtil.py.in
+++ b/vdsm_reg/deployUtil.py.in
@@ -38,7 +38,7 @@
import glob
import imp
from optparse import OptionParser
-from itertools import dropwhile, islice
+import platform
try:
from ovirtnode import ovirtfunctions
@@ -445,14 +445,13 @@
Return "Unknown OS" on any failure.
"""
- s = ''
+ osVer = ''
try:
- s = file('/etc/redhat-release', 'r').read()
-
- return islice(dropwhile(lambda x: x != 'release', s.split()),
- 1, 2).next()
+ osVer = platform.linux_distribution()
+ logging.debug("OS Release Ver = %s", osVer[1])
+ return osVer[1]
except:
- logging.error('failed to parse os release from `%s`.', s, exc_info=True)
+ logging.error('failed to get OS release')
return "Unknown OS"
def getKernelVR():
--
To view, visit http://gerrit.ovirt.org/7930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia58284ce75dc6d09f0302181ea35ed3817dd861d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip(a)in.ibm.com>
11 years, 8 months
Change in vdsm[master]: Add the autotools support in the spec file
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Add the autotools support in the spec file
......................................................................
Add the autotools support in the spec file
This change makes easier for rpm-based distributions to backport patches
that touch the autotools files.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=847535
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: I23703d299b639d55714b71567bc04c154fc21fc0
---
M vdsm.spec.in
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/7925/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index bb6730e..ba14141 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -13,6 +13,11 @@
# Required paths
%global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
+# Default to skipping autoreconf. Distros can change just this one line
+# (or provide a command-line override) if they backport any patches that
+# touch configure.ac or Makefile.am.
+%{!?enable_autotools:%define enable_autotools 0}
+
Name: %{vdsm_name}
Version: @PACKAGE_VERSION@
Release: @PACKAGE_RELEASE@%{?dist}%{?extra_release}
@@ -35,6 +40,14 @@
BuildRequires: libvirt-python
BuildRequires: sanlock-python >= 2.3
BuildRequires: genisoimage
+
+# Autotools BuildRequires
+%if 0%{?enable_autotools}
+BuildRequires: autoconf
+BuildRequires: automake
+BuildRequires: gettext-devel
+BuildRequires: libtool
+%endif
%if !0%{?rhel}
BuildRequires: systemd-units
@@ -335,6 +348,9 @@
%setup -q
%build
+%if 0%{?enable_autotools}
+autoreconf -if
+%endif
%configure %{?with_hooks:--enable-hooks}
make
# Setting software_version and software_revision in dsaversion.py
--
To view, visit http://gerrit.ovirt.org/7925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23703d299b639d55714b71567bc04c154fc21fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years, 8 months
Change in vdsm[master]: Fix the rpm package discovery process in vdsm caps
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: Fix the rpm package discovery process in vdsm caps
......................................................................
Fix the rpm package discovery process in vdsm caps
If the rpm package isn't found it shouldn't be added to the packages
dictionary.
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: If86356cb13680494d916b0fa6dbb9171356cfe03
---
M vdsm/caps.py
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/7953/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index b592544..d722488 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -313,12 +313,18 @@
try:
ts = rpm.TransactionSet()
+
for pkg in KEY_PACKAGES:
- for er in ts.dbMatch('name', pkg):
- v = er['version']
- r = er['release']
- t = er['buildtime']
- pkgs[pkg] = dict(version=v, release=r, buildtime=t)
+ try:
+ mi = ts.dbMatch('name', pkg).next()
+ except StopIteration:
+ logging.debug("rpm package %s not found", pkg)
+ else:
+ pkgs[pkg] = {
+ 'version': mi['version'],
+ 'release': mi['release'],
+ 'buildtime': mi['buildtime'],
+ }
except:
logging.error('', exc_info=True)
--
To view, visit http://gerrit.ovirt.org/7953
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If86356cb13680494d916b0fa6dbb9171356cfe03
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
11 years, 8 months
Change in vdsm[master]: Reelated to BZ#846323 - Adding deprecated decorator.
by ewarszaw＠redhat.com
Eduardo has uploaded a new change for review.
Change subject: Reelated to BZ#846323 - Adding deprecated decorator.
......................................................................
Reelated to BZ#846323 - Adding deprecated decorator.
Change-Id: I9e30eb912f78cc2dcd846ff0b0273a0a8016cac7
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/7308/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 2227c03..b04f083 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1698,6 +1698,7 @@
return dict(uuid=lvm.getVG(vgname).uuid)
+ @deprecated
@public
def removeVG(self, vgUUID, options = None):
"""
--
To view, visit http://gerrit.ovirt.org/7308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e30eb912f78cc2dcd846ff0b0273a0a8016cac7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
11 years, 8 months
Change in vdsm[master]: BZ#846323 - Search PV's belonging to the VG in removeVG.
by ewarszaw＠redhat.com
Eduardo has uploaded a new change for review.
Change subject: BZ#846323 - Search PV's belonging to the VG in removeVG.
......................................................................
BZ#846323 - Search PV's belonging to the VG in removeVG.
Only one getAllPvs() call remains!
Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68
Signed-off-by: Eduardo <ewarszaw(a)redhat.com>
---
M vdsm/storage/lvm.py
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/7066/1
--
To view, visit http://gerrit.ovirt.org/7066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica565f74774fd1dcce7c18361aef5e1464c78b68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
11 years, 8 months
Change in vdsm[master]: engine.py: fail if Password doesn't match
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: engine.py: fail if Password doesn't match
......................................................................
engine.py: fail if Password doesn't match
Currently, if users in the Node TUI add the password to include the
node through Engine and passwords doesn't match, no failure
message will show and it will continue.
This patch will show to users a failure message if the passwords
doesn't match.
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=854457
Test:
* Install Node
* Select oVirt Engine Tab
* Add passwords that doesn't match and click 'Apply'
Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm_reg/engine.py.in
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/7917/1
diff --git a/vdsm_reg/engine.py.in b/vdsm_reg/engine.py.in
index 74fe07a..b104635 100644
--- a/vdsm_reg/engine.py.in
+++ b/vdsm_reg/engine.py.in
@@ -42,6 +42,8 @@
VDSM_REG_CONFIG = "/etc/vdsm-reg/vdsm-reg.conf"
VDC_HOST_PORT = 443
TIMEOUT_FIND_HOST_SEC = 5
+PASSWORD_MATCH = 0
+PASSWORD_DOESNT_MATCH = 1
fWriteConfig = 0
def set_defaults():
@@ -186,6 +188,7 @@
self.root_password_2.setCallback(self.password_check_callback)
pw_elements.setField(self.root_password_2, 1, 2)
self.pw_msg = Textbox(60, 6, "", wrap=1)
+ self.pw_resp = PASSWORD_MATCH
elements.setField(pw_elements, 0, 6, anchorLeft=1)
elements.setField(self.pw_msg, 0, 7, padding = (0,0,0,0))
@@ -212,9 +215,17 @@
def password_check_callback(self):
resp, msg = password_check(self.root_password_1.value(), self.root_password_2.value())
self.pw_msg.setText(msg)
+ self.pw_resp = resp
return
def action(self):
+ # Show error if the password informed by user doesn't match
+ if self.pw_resp == PASSWORD_DOESNT_MATCH and len(self.root_password_1.value()) > 0 or \
+ self.pw_resp == PASSWORD_DOESNT_MATCH and len(self.root_password_2.value()) > 0:
+ msg = "Password Do Not Match!"
+ ButtonChoiceWindow(self.ncs.screen, "@ENGINENAME@", msg, buttons = ['Ok'])
+ return
+
# To manage the engine_server_port value, use enginePort var to avoid
# TUI putting the port value in the screen when you are just changing
# the value and not asking to draw/print it.
--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
11 years, 8 months
Change in vdsm[master]: vdsm-reg-setup: get hostname with gethostname()
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm-reg-setup: get hostname with gethostname()
......................................................................
vdsm-reg-setup: get hostname with gethostname()
Currently, if Node users use TUI to replace the hostname, it trigger the
inclusion of the new hostname in /etc/hosts for 127.0.0.1 entry.
Adding the new hostname as alias for 127.0.0.1 will make socket.getfqdn()
locate the first alias available in /etc/hosts, in that case localhost.localdomain.
This patch will fix the report replacing the socket.getfqdn() to socket.gethostname().
Test
=====
* Install oVirt Node 2.5.1-1.0
* Set Network (default it will be localhost.localdomain)
* Select Network again, and change Hostname (supernode.linux.com)
* Register the Node into Engine
- At this moment, Engine will show localhost.localdomain instead of supernode.linux.com
The manual workaround is remove the new hostname from /etc/hosts in 127.0.0.1 entry.
Change-Id: I38ec4c570d7f250d64e62e01b91cd2828780c45b
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm_reg/vdsm-reg-setup.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/7939/1
diff --git a/vdsm_reg/vdsm-reg-setup.in b/vdsm_reg/vdsm-reg-setup.in
index 0f3e896..492e38d 100644
--- a/vdsm_reg/vdsm-reg-setup.in
+++ b/vdsm_reg/vdsm-reg-setup.in
@@ -48,7 +48,7 @@
self.vdsmDir = config.get('vars', 'vdsm_dir')
if self.vdcURL != "None":
self.ovirtURL = deployUtil.getMGTIP(self.vdsmDir, self.vdcName)
- self.ovirtName = socket.getfqdn()
+ self.ovirtName = socket.gethostname()
self.ovirtUID = deployUtil.getHostID()
else:
self.ovirtURL = "None"
--
To view, visit http://gerrit.ovirt.org/7939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38ec4c570d7f250d64e62e01b91cd2828780c45b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
11 years, 8 months
Change in vdsm[master]: Chown /var/log/vdsm during startup to prevent vdsmd crash
by Ryan Harper
Ryan Harper has uploaded a new change for review.
Change subject: Chown /var/log/vdsm during startup to prevent vdsmd crash
......................................................................
Chown /var/log/vdsm during startup to prevent vdsmd crash
Bug-Id: https://bugzilla.redhat.com/729348
vdsmd startup routine will handle re-creating /var/log/vdsm
but doesn't chown it with vdsm.kvm which prevents vdsmd from
operating.
Fix this by chowning the parent dir during startup.
Change-Id: I916326a70053792f145273bc62b330ff248d9a79
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/vdsmd.init.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/7940/1
diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in
index 603a585..e271970 100755
--- a/vdsm/vdsmd.init.in
+++ b/vdsm/vdsmd.init.in
@@ -76,6 +76,7 @@
mk_dom_backup() {
/bin/mkdir -p ${DOM_METADATA_BACKUP_DIR} > /dev/null 2>&1
+ /bin/chown vdsm.kvm `dirname ${DOM_METADATA_BACKUP_DIR}` > /dev/null 2>&1
/bin/chown vdsm.kvm ${DOM_METADATA_BACKUP_DIR} > /dev/null 2>&1
}
--
To view, visit http://gerrit.ovirt.org/7940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I916326a70053792f145273bc62b330ff248d9a79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
11 years, 8 months