January 2013 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} ...................................................................... Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/573/ (1/2) -- To view, visit http://gerrit.ovirt.org/10674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 3 months

1
0
0 / 0

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

by zhshzhou＠linux.vnet.ibm.com

Zhou Zheng Sheng has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} ...................................................................... Patch Set 1: Verified Pass autobuild.sh. gitpydiff finds no changes on all the files except constants.py.in and blockVolume.py . The changes are about modifying the string literals. They are acceptable because the original string literals are wrong, the modified ones are right. Detailed report: For vdsm/constants.py.in: 1 difference(s) first file: vdsm/constants.py.in second file: /tmp/pydiff/vdsm/constants.py.in ((159, '\n\ndefaults {\n polling_interval 5\n getuid_callout "@SCSI_ID_PATH@ --whitelisted --replace-whitespace --device=/dev/%n"\n no_path_retry fail\n user_friendly_names no\n flush_on_last_del yes\n fast_io_fail_tmo 5\n dev_loss_tmo 30\n max_fds 4096\n}\n\ndevices {\ndevice {\n vendor "HITACHI"\n product "DF.*"\n getuid_callout "@SCSI_ID_PATH@ --whitelisted --replace-whitespace --device=/dev/%n"\n}\ndevice {\n vendor "COMPELNT"\n product "Compellent Vol"\n no_path_retry fail\n}\n}'), (159, '\n\ndefaults {\n polling_interval 5\n getuid_callout "@SCSI_ID_PATH@ --whitelisted --replace-whitespace --device=/dev/%n"\n no_path_retry fail\n user_friendly_names no\n flush_on_last_del yes\n fast_io_fail_tmo 5\n dev_loss_tmo 30\n max_fds 4096\n}\n\ndevices {\ndevice {\n vendor "HITACHI"\n product "DF.*"\n getuid_callout "@SCSI_ID_PATH@ --whitelisted --replace-whitespace --device=/dev/%n"\n}\ndevice {\n vendor "COMPELNT"\n product "Compellent Vol"\n no_path_retry fail\n}\n}')) For vdsm/storage/blockVolume.py: 1 difference(s) first file: vdsm/storage/blockVolume.py second file: /tmp/pydiff/vdsm/storage/blockVolume.py ((553, 'missing offset tag on volume%s/%s'), (556, 'missing offset tag on volume %s/%s')) -- To view, visit http://gerrit.ovirt.org/10674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 3 months

1
0
0 / 0

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} ...................................................................... Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/572/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/607/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/10674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 3 months

1
0
0 / 0

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} ...................................................................... Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/572/ (1/2) -- To view, visit http://gerrit.ovirt.org/10674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 3 months

1
0
0 / 0

Change in vdsm[master]: PEP 8: fix ignored errors E12{6,7,8}

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: PEP 8: fix ignored errors E12{6,7,8} ...................................................................... Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/607/ (2/2) -- To view, visit http://gerrit.ovirt.org/10674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 3 months

1
0
0 / 0

Change in vdsm[master]: Increase timeout in remoteFileHandlerTests:PoolHandlerTests....

by smizrahi＠redhat.com

Saggi Mizrahi has uploaded a new change for review. Change subject: Increase timeout in remoteFileHandlerTests:PoolHandlerTests.testStop ...................................................................... Increase timeout in remoteFileHandlerTests:PoolHandlerTests.testStop On congested hosts (like the oVirt Jenkins host) the test might fail even though nothing is broken it is just taking longer then expected. Change-Id: I9334cf00c37b352adad52a0587f9675cda5bd0dd Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- M tests/remoteFileHandlerTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/10637/1 diff --git a/tests/remoteFileHandlerTests.py b/tests/remoteFileHandlerTests.py index b114abf..544ec28 100644 --- a/tests/remoteFileHandlerTests.py +++ b/tests/remoteFileHandlerTests.py @@ -63,7 +63,7 @@ procPath = os.path.join("/proc", str(p.process.pid)) # Make sure handler is running - self.assertTrue(p.proxy.callCrabRPCFunction(1, "os.path.exists", + self.assertTrue(p.proxy.callCrabRPCFunction(4, "os.path.exists", procPath)) p.stop() test = lambda: self.assertFalse(os.path.exists(procPath)) -- To view, visit http://gerrit.ovirt.org/10637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9334cf00c37b352adad52a0587f9675cda5bd0dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

11 years, 3 months

4
6
0 / 0

Change in vdsm[master]: vdsm.spec: increase selinux-policy for rhel distro

by Douglas Schilling Landgraf

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: vdsm.spec: increase selinux-policy for rhel distro ...................................................................... vdsm.spec: increase selinux-policy for rhel distro sanlock_use_fusefs was introduced in selinux-policy-3.7.19-155.5 Change-Id: I712f6975f9705d91c7eef8fad047bbaa6dada2e9 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/10622/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index daba91b..dc0c76b 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -110,7 +110,7 @@ Requires: sanlock >= 2.3-4, sanlock-python Requires: initscripts >= 9.03.31-2.el6_3.1 Requires: mom >= 0.3.0 -Requires: selinux-policy-targeted >= 3.7.19-80 +Requires: selinux-policy-targeted >= 3.7.19-155 Requires: lvm2 >= 2.02.95-10.el6_3.2 Requires: logrotate < 3.8.0 %endif -- To view, visit http://gerrit.ovirt.org/10622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I712f6975f9705d91c7eef8fad047bbaa6dada2e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>

11 years, 3 months

3
9
0 / 0

Change in vdsm[master]: tests: Test schema validity

by agl＠us.ibm.com

Adam Litke has uploaded a new change for review. Change subject: tests: Test schema validity ...................................................................... tests: Test schema validity Add a simple test case to check schema validity. For now, we just call the schema parser and make sure it doesn't raise any exceptions. Change-Id: If7680aaf8eb41546e3a8d38e405c7f9ed8bdd192 Signed-off-by: Adam Litke <agl(a)us.ibm.com> --- A tests/schemaTests.py 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/10050/1 diff --git a/tests/schemaTests.py b/tests/schemaTests.py new file mode 100644 index 0000000..3e33d54 --- /dev/null +++ b/tests/schemaTests.py @@ -0,0 +1,47 @@ +# Copyright 2012 IBM Corporation. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +from testrunner import VdsmTestCase as TestCaseBase +import os.path +import vdsmapi +from vdsm import constants + + +def findSchema(): + """ + Find the API schema file whether we are running tests from the source dir + or from the tests install location + """ + scriptdir = os.path.dirname(__file__) + localpath = os.path.join(scriptdir, '../vdsm_api/vdsmapi-schema.json') + installedpath = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json') + for f in localpath, installedpath: + if os.access(f, os.R_OK): + return f + raise Exception("Unable to find schema in %s or %s", + localpath, installedpath) + + +class SchemaTest(TestCaseBase): + def setUp(self): + self.schema = findSchema() + + def testSchemaParse(self): + with open(self.schema) as f: + vdsmapi.parse_schema(f) -- To view, visit http://gerrit.ovirt.org/10050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If7680aaf8eb41546e3a8d38e405c7f9ed8bdd192 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>

11 years, 3 months

6
15
0 / 0

Change in vdsm[master]: vdsm.spec: python-ordereddict only for rhel < 7

by Douglas Schilling Landgraf

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: vdsm.spec: python-ordereddict only for rhel < 7 ...................................................................... vdsm.spec: python-ordereddict only for rhel < 7 rhel7 contains python 2.7 which already includes ordereddict module, no need extra python package. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=891542 Change-Id: I784d82a7fb5a1c6a13f015747f077020b91c19cb Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M vdsm.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/10649/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index daba91b..a8bd147 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -47,7 +47,7 @@ %ifarch x86_64 BuildRequires: python-dmidecode %endif -%if 0%{?rhel} +%if 0%{?rhel} < 7 BuildRequires: python-ordereddict %endif @@ -186,7 +186,7 @@ BuildArch: noarch Requires: %{name}-python = %{version}-%{release} -%if 0%{?rhel} +%if 0%{?rhel} < 7 Requires: python-ordereddict %endif -- To view, visit http://gerrit.ovirt.org/10649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I784d82a7fb5a1c6a13f015747f077020b91c19cb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>

11 years, 3 months

4
7
0 / 0

Change in vdsm[master]: Update gitignore

by smizrahi＠redhat.com

Saggi Mizrahi has uploaded a new change for review. Change subject: Update gitignore ...................................................................... Update gitignore Change-Id: I37d3cb03f937c376955847ea18d85c60bb589fe8 Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com> --- M .gitignore 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/9985/1 diff --git a/.gitignore b/.gitignore index 49a78ef..e28df4f 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ *.pyc *.swp *.tmp +*.stamp *~ .project .pydevproject @@ -9,10 +10,30 @@ INSTALL Makefile Makefile.in +libtool aclocal.m4 +m4/libtool.m4 +m4/ltoptions.m4 +m4/ltsugar.m4 +m4/ltversion.m4 +m4/lt~obsolete.m4 autom4te.cache/ +vdsm_api/.libs/ +vdsm_api/*.c +vdsm_api/*.lo +vdsm_api/generated.vala +vdsm_api/*.la +vdsm_api/libvdsm.vapi +vdsm_api/vdsm-0.1.gir +vdsm_api/vdsm-0.1.typelib +vdsm_api/vdsm.h +vdsm_api/c_test +vdsm/doc/build +build-aux/config.guess +build-aux/config.sub build-aux/depcomp build-aux/install-sh +build-aux/ltmain.sh build-aux/missing build-aux/py-compile config.log -- To view, visit http://gerrit.ovirt.org/9985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37d3cb03f937c376955847ea18d85c60bb589fe8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>

11 years, 4 months

3
5
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches January 2013