October 2013 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

by ahadas＠redhat.com

Arik Hadas has uploaded a new change for review. Change subject: reduce the time VM is paused in snapshot with RAM creation ...................................................................... reduce the time VM is paused in snapshot with RAM creation By using libvirt's VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag we minimize the time the VM is switched to paused state while creating live snapshot with RAM. Without this flag the VM is switched to pause state for the whole process of dumping the memory, and with this flag the VM is switched to pause state only for a short time. Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/19296/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 92d274e..6dece1f 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -3668,6 +3668,8 @@ memoryVol = memoryParams['dst'] memoryVolPath = self.cif.prepareVolumePath(memoryVol) snap.appendChild(_memorySnapshot(memoryVolPath)) + + snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_LIVE else: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY -- To view, visit http://gerrit.ovirt.org/19296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>

9 years, 11 months

6
12
0 / 0

Change in vdsm[master]: More precise catch in block volume create.

by ewarszaw＠redhat.com

Eduardo has uploaded a new change for review. Change subject: More precise catch in block volume create. ...................................................................... More precise catch in block volume create. Narrow the exception when failed to deactivate a new created volume. Change-Id: I5ac32eb0d58404c3e066dc73488ae0101560a919 Signed-off-by: Eduardo <ewarszaw(a)redhat.com> --- M vdsm/storage/blockVolume.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/18883/1 diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index effd3a5..d0476ba 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -204,7 +204,7 @@ try: lvm.deactivateLVs(dom.sdUUID, volUUID) - except Exception: + except se.CannotDeactivateLogicalVolume: cls.log.warn("Cannot deactivate new created volume %s/%s", dom.sdUUID, volUUID, exc_info=True) -- To view, visit http://gerrit.ovirt.org/18883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ac32eb0d58404c3e066dc73488ae0101560a919 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

9 years, 12 months

6
6
0 / 0

Change in vdsm[master]: configNetwork Missing space in error string

by asegurap＠redhat.com

Antoni Segura Puimedon has uploaded a new change for review. Change subject: configNetwork Missing space in error string ...................................................................... configNetwork Missing space in error string Change-Id: I347a789b1e332bcf3a278f9428aa2702d9cd6fe6 Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/20010/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 35f2bd9..3b571f4 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -103,7 +103,7 @@ stp=opts.get('stp'), forwardDelay=int(opts.get('forward_delay', 0))) if topNetDev is None: - raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'Network defined without' + raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'Network defined without ' 'devices.') topNetDev.ip = IpConfig(inet=IPv4(ipaddr, netmask, gateway, defaultRoute), bootproto=bootproto, -- To view, visit http://gerrit.ovirt.org/20010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I347a789b1e332bcf3a278f9428aa2702d9cd6fe6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>

9 years, 12 months

3
4
0 / 0

Change in vdsm[master]: netconf: Sort bond's slave when objectivizing

by wudxw＠linux.vnet.ibm.com

Mark Wu has uploaded a new change for review. Change subject: netconf: Sort bond's slave when objectivizing ...................................................................... netconf: Sort bond's slave when objectivizing To make iproute2 configurator pass testBondHwAddress, we need keep the bond's slaves sorted. Otherwise bond's hwaddr will vary with the order of enslaving. This work is done by initscript for ifcfg configurator. Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com> --- M vdsm/netmodels.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/19591/1 diff --git a/vdsm/netmodels.py b/vdsm/netmodels.py index 50a5ba3..8cb2d3d 100644 --- a/vdsm/netmodels.py +++ b/vdsm/netmodels.py @@ -234,8 +234,8 @@ def objectivize(cls, name, configurator, options, nics, mtu, _netinfo, destroyOnMasterRemoval=None): if name and nics: # New bonding or edit bonding. - slaves = cls._objectivizeSlaves(name, configurator, nics, mtu, - _netinfo) + slaves = cls._objectivizeSlaves(name, configurator, sorted(nics), + mtu, _netinfo) if name in _netinfo.bondings: if _netinfo.ifaceUsers(name): mtu = max(mtu, netinfo.getMtu(name)) -- To view, visit http://gerrit.ovirt.org/19591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5db20ca598414ff29a368d99156b04b7f61961ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>

9 years, 12 months

4
15
0 / 0

Change in vdsm[master]: Reimplement hsm.getVolumesList().

by ewarszaw＠redhat.com

Eduardo has uploaded a new change for review. Change subject: Reimplement hsm.getVolumesList(). ...................................................................... Reimplement hsm.getVolumesList(). It is not pool dependant anymore. Related to BZ#960952. Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Signed-off-by: Eduardo <ewarszaw(a)redhat.com> --- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/15766/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 7b9ed70..33338a0 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3205,7 +3205,7 @@ :param spUUID: The UUID of the storage pool that manages the storage domain you want to query. - :type spUUID: UUID + :type spUUID: Use BLANK_UUID or anything if not connected to SP. :param sdUUID: The UUID of the storage domain you want to query. :type sdUUID: UUID :param imgUUID: The UUID of the an image you want to filter the @@ -3215,18 +3215,12 @@ """ vars.task.getSharedLock(STORAGE, sdUUID) dom = sdCache.produce(sdUUID=sdUUID) + vols = dom.getAllVolumes() if imgUUID == volume.BLANK_UUID: - images = dom.getAllImages() + volUUIDs = vols.keys() else: - images = [imgUUID] - - uuidlist = [] - repoPath = os.path.join(self.storage_repository, spUUID) - for img in images: - uuidlist += (dom.getVolumeClass(). - getImageVolumes(repoPath, sdUUID, img)) - self.log.info("List of volumes is %s", uuidlist) - return dict(uuidlist=uuidlist) + volUUIDs = [k for k, v in vols.itervalues() if imgUUID in v.images] + return dict(uuidlist=volUUIDs) @public def getImagesList(self, sdUUID, options=None): -- To view, visit http://gerrit.ovirt.org/15766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

9 years, 12 months

5
14
0 / 0

Change in vdsm[master]: hsm: [wip] protect deleteImage with the spm lock

by Federico Simoncelli

Federico Simoncelli has uploaded a new change for review. Change subject: hsm: [wip] protect deleteImage with the spm lock ...................................................................... hsm: [wip] protect deleteImage with the spm lock Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/19795/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 4f5a8a7..c4350d6 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1506,7 +1506,7 @@ force parameter is deprecated and not evaluated. """ # vars.task.setDefaultException(se.ChangeMeError("%s" % args)) - self.getPool(spUUID) # Validates that the pool is connected. WHY? + pool = self.getPool(spUUID) # Validates pool connection. WHY? dom = sdCache.produce(sdUUID=sdUUID) vars.task.getExclusiveLock(STORAGE, imgUUID) @@ -1541,7 +1541,7 @@ if fakeTUUID: tParams = dom.produceVolume(imgUUID, fakeTUUID).\ getVolumeParams() - dom.deleteImage(sdUUID, imgUUID, volsByImg) + pool.deleteImage(dom, imgUUID, volsByImg) # This is a hack to keep the interface consistent # We currently have race conditions in delete image, to quickly fix # this we delete images in the "synchronous" state. This only works diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 8bab500..7242006 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -2020,6 +2020,12 @@ sdCache.produce(sdUUID).produceVolume(imgUUID, volUUID).delete( postZero=postZero, force=force) + def deleteImage(self, domain, imgUUID, volsByImg): + """ + TODO: describe method + """ + domain.deleteImage(domain.sdUUID, imgUUID, volsByImg) + def setMaxHostID(self, spUUID, maxID): """ Set maximum host ID -- To view, visit http://gerrit.ovirt.org/19795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac5b4b0f71de6a12de34513d4fafb295b701306c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

9 years, 12 months

5
15
0 / 0

Change in vdsm[master]: image: Calculation of chain to remove is inaccurate

by ykaplan＠redhat.com

Yeela Kaplan has uploaded a new change for review. Change subject: image: Calculation of chain to remove is inaccurate ...................................................................... image: Calculation of chain to remove is inaccurate The if condition will always return false, therefore list 'rmChain' will always be composed of only one volume. Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9 Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com> --- M vdsm/storage/image.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/19852/1 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index da3e42d..2b9b448 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -1022,7 +1022,7 @@ # Prepare chain for future erase rmChain = [vol.volUUID for - vol in chain if srcVol.volUUID != srcVolParams['volUUID']] + vol in chain if vol.volUUID != srcVolParams['volUUID']] rmChain.append(tmpUUID) return rmChain -- To view, visit http://gerrit.ovirt.org/19852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>

9 years, 12 months

6
10
0 / 0

Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing

by Dan Kenigsberg

Dan Kenigsberg has uploaded a new change for review. Change subject: caps: coarse-grain libvirt.rpm may be missing ...................................................................... caps: coarse-grain libvirt.rpm may be missing As of http://gerrit.ovirt.org/15761 we no longer require the legacy libvirt.rpm to be installed on Fedora, so getCaps should not look for it. Without this patch we get an annoying (_getKeyPackages) rpm package libvirt not found log message, and do not report libvirt's version. Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/caps.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/19295/1 diff --git a/vdsm/caps.py b/vdsm/caps.py index 3a7a6a2..ceea429 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -331,6 +331,9 @@ 'mom': 'mom', } + if getos() in (OSName.OVIRT, OSName.FEDORA): + KEY_PACKAGES['libvirt-daemon-kvm'] + if _glusterEnabled: KEY_PACKAGES.update(GLUSTER_RPM_PACKAGES) -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

9 years, 12 months

5
15
0 / 0

Change in vdsm[master]: Merge configuration tools to configurator.py and add configu...

by ybronhei＠redhat.com

Yaniv Bronhaim has uploaded a new change for review. Change subject: Merge configuration tools to configurator.py and add configure-all verb ...................................................................... Merge configuration tools to configurator.py and add configure-all verb Change-Id: Id173b3257ba1d493d0ea44185fbb57bb5872cb2e Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M init/sysvinit/vdsmd.init.in R lib/vdsm/tool/configurator.py D lib/vdsm/tool/sanlock.py 3 files changed, 53 insertions(+), 68 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/19915/1 diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in index 13ac769..13bfa11 100755 --- a/init/sysvinit/vdsmd.init.in +++ b/init/sysvinit/vdsmd.init.in @@ -106,16 +106,11 @@ return 1 } -reconfigure_libvirt() { +reconfigure() { local force [ "${1}" = "force" ] && force="--force" - "$VDSM_TOOL" libvirt-configure ${force} && + "$VDSM_TOOL" configure-all ${force} && "$VDSM_TOOL" libvirt-configure-services-restart -} - -reconfigure_sanlock() { - "$VDSM_TOOL" sanlock-check-service && - "$VDSM_TOOL" service-restart sanlock } start() { @@ -207,8 +202,7 @@ reconfigure) # Jump over 'reconfigure' shift 1 - reconfigure_libvirt "$@" - reconfigure_sanlock + reconfigure "$@" RETVAL=$? ;; *) diff --git a/lib/vdsm/tool/libvirt_configure.py b/lib/vdsm/tool/configurator.py similarity index 62% rename from lib/vdsm/tool/libvirt_configure.py rename to lib/vdsm/tool/configurator.py index 26987ed..3f1cc62 100644 --- a/lib/vdsm/tool/libvirt_configure.py +++ b/lib/vdsm/tool/configurator.py @@ -19,11 +19,19 @@ import os import sys +import grp from vdsm import utils import vdsm.tool from vdsm.tool import service -from vdsm.constants import P_VDSM_EXEC +from vdsm.constants import P_VDSM_EXEC, DISKIMAGE_GROUP + + +SANLOCK_PID = "/var/run/sanlock/sanlock.pid" + +PROC_STATUS_PATH = "/proc/%s/status" +PROC_STATUS_GROUPS = "Groups:\t" +PROC_STATUS_GROUPS_LEN = len(PROC_STATUS_GROUPS) def exec_libvirt_configure(action, *args): @@ -82,3 +90,44 @@ Check if libvirt is already configured for vdsm """ return exec_libvirt_configure("check_if_configured", *args) + + +(a)vdsm.tool.expose("sanlock-check-service") +def sanlock_check_service(*args): + """ + Check if sanlock service requires a restart to reload the relevant + supplementary groups. + """ + + try: + sanlock_pid = open(SANLOCK_PID, "r").readline().strip() + sanlock_status = open(PROC_STATUS_PATH % sanlock_pid, "r") + except IOError as e: + if e.errno == os.errno.ENOENT: + return 0 # service is not running, returning + raise + + for status_line in sanlock_status: + if status_line.startswith(PROC_STATUS_GROUPS): + groups = [int(x) for x in + status_line[PROC_STATUS_GROUPS_LEN:].strip().split(" ")] + break + else: + raise RuntimeError("Unable to find sanlock service groups") + + diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2] + return 0 if diskimage_gid in groups else 1 + + +(a)vdsm.tool.expose("reconfigure-all") +def configure_all(*args): + """ + configure related services for vdsm + """ + if '--force' in args: + service.service_stop("supervdsmd") + service.service_stop("libvirtd") + + configure_libvirt(*args) + if sanlock_check_service(*args): + service.service_restart("sanlock") diff --git a/lib/vdsm/tool/sanlock.py b/lib/vdsm/tool/sanlock.py deleted file mode 100644 index 650a5cf..0000000 --- a/lib/vdsm/tool/sanlock.py +++ /dev/null @@ -1,58 +0,0 @@ -# Copyright 2013 Red Hat, Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA -# -# Refer to the README and COPYING files for full details of the license -# - -import os -import grp - -from vdsm import constants -from vdsm.tool import expose - - -SANLOCK_PID = "/var/run/sanlock/sanlock.pid" - -PROC_STATUS_PATH = "/proc/%s/status" -PROC_STATUS_GROUPS = "Groups:\t" -PROC_STATUS_GROUPS_LEN = len(PROC_STATUS_GROUPS) - - -@expose("sanlock-check-service") -def sanlock_check_service(*args): - """ - Check if sanlock service requires a restart to reload the relevant - supplementary groups. - """ - - try: - sanlock_pid = open(SANLOCK_PID, "r").readline().strip() - sanlock_status = open(PROC_STATUS_PATH % sanlock_pid, "r") - except IOError as e: - if e.errno == os.errno.ENOENT: - return 0 # service is not running, returning - raise - - for status_line in sanlock_status: - if status_line.startswith(PROC_STATUS_GROUPS): - groups = [int(x) for x in - status_line[PROC_STATUS_GROUPS_LEN:].strip().split(" ")] - break - else: - raise RuntimeError("Unable to find sanlock service groups") - - diskimage_gid = grp.getgrnam(constants.DISKIMAGE_GROUP)[2] - return 0 if diskimage_gid in groups else 1 -- To view, visit http://gerrit.ovirt.org/19915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id173b3257ba1d493d0ea44185fbb57bb5872cb2e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>

9 years, 12 months

2
2
0 / 0

Change in vdsm[master]: fileVolume: improve size checks in _extendSizeRaw

by Federico Simoncelli

Federico Simoncelli has uploaded a new change for review. Change subject: fileVolume: improve size checks in _extendSizeRaw ...................................................................... fileVolume: improve size checks in _extendSizeRaw Change-Id: I87695d67bd912f084e99314cff4ce42fd9d4cd2c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M vdsm/storage/fileVolume.py 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/19508/1 diff --git a/vdsm/storage/fileVolume.py b/vdsm/storage/fileVolume.py index 4525b0e..33d97d9 100644 --- a/vdsm/storage/fileVolume.py +++ b/vdsm/storage/fileVolume.py @@ -578,7 +578,12 @@ # No real sanity checks here, they should be included in the calling # function/method. We just validate the sizes to be consistent since # they're computed and used in the pre-allocated case. - if (newSizeBytes <= curSizeBytes): + if newSizeBytes == curSizeBytes: + return # Nothing to do + elif curSizeBytes <= 0: + raise se.StorageException( + "Volume size is impossible: %s" % curSizeBytes) + elif newSizeBytes < curSizeBytes: raise se.VolumeResizeValueError(newSize) if self.getVolType() == volume.PREALLOCATED_VOL: -- To view, visit http://gerrit.ovirt.org/19508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87695d67bd912f084e99314cff4ce42fd9d4cd2c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

9 years, 12 months

4
7
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2013