November 2013 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: vdsm: move balloon logic out of buildConfDevices

by mpoledni＠redhat.com

Martin Polednik has uploaded a new change for review. Change subject: vdsm: move balloon logic out of buildConfDevices ...................................................................... vdsm: move balloon logic out of buildConfDevices Encapsulates empty balloon creation logic outside of buildConfDevices to improve code readability Change-Id: I6d77c1bbd7bdf760c8dda35d0ce6b70af51326bd Signed-off-by: Martin Polednik <mpoledni(a)redhat.com> --- M vdsm/vm.py 1 file changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/19321/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 92d274e..618dd8f 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -1928,15 +1928,24 @@ # Preserve old behavior. Since libvirt add a memory balloon device # to all guests, we need to specifically request not to add it. - if len(devices[BALLOON_DEVICES]) == 0: - devices[BALLOON_DEVICES].append({ - 'type': BALLOON_DEVICES, - 'device': 'memballoon', - 'specParams': { - 'model': 'none'}}) + self._normalizeBalloonDevice(devices[BALLOON_DEVICES]) return devices + def _normalizeBalloonDevice(self, balloonDevices): + EMPTY_BALLOON = {'type': BALLOON_DEVICES, + 'device': 'memballoon', + 'specParams': { + 'model': 'none'}} + + # Avoid overriding the saved balloon target value on recovery. + if 'recover' not in self.conf: + for dev in balloonDevices: + dev['target'] = int(self.conf.get('memSize')) * 1024 + + if len(balloonDevices) == 0: + balloonDevices.append(EMPTY_BALLOON) + def getConfController(self): """ Normalize controller device. -- To view, visit http://gerrit.ovirt.org/19321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d77c1bbd7bdf760c8dda35d0ce6b70af51326bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>

9 years, 11 months

7
15
0 / 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 7: (1 comment) .................................................... File lib/vdsm/utils.py Line 130: logging.warning("Directory: %s already removed", directoryToRemove) Line 131: else: Line 132: logging.error("Removing directory: %s failed", directoryToRemove, Line 133: exc_info=True) Line 134: raise If you raise, why not let the caller handle this and log its own error? I would write this as: try: shutil.rmtree(path) except OSError as e: if e.errno != errno.ENOENT: raise Line 135: Line 136: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler Line 137: Line 138: -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 6: (1 comment) .................................................... File lib/vdsm/utils.py Line 129: if e.errno == errno.ENOENT: Line 130: logging.warning("Directory: %s already removed", directoryToRemove) Line 131: else: Line 132: logging.error("Removing directory: %s failed", directoryToRemove, Line 133: exc_info=True) It also apply, but it is out of the scope of this patch. Line 134: Line 135: Line 136: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler Line 137: -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4408/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5212/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5288/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 6: (1 comment) .................................................... File lib/vdsm/utils.py Line 129: if e.errno == errno.ENOENT: Line 130: logging.warning("Directory: %s already removed", directoryToRemove) Line 131: else: Line 132: logging.error("Removing directory: %s failed", directoryToRemove, Line 133: exc_info=True) Also if we assume that the directory was removed, why log a warning about it? This just fill the logs with bogus warnings. A debug message would be better here. Line 134: Line 135: Line 136: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler Line 137: -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

by Nir Soffer

Nir Soffer has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 6: (1 comment) .................................................... File lib/vdsm/utils.py Line 129: if e.errno == errno.ENOENT: Line 130: logging.warning("Directory: %s already removed", directoryToRemove) Line 131: else: Line 132: logging.error("Removing directory: %s failed", directoryToRemove, Line 133: exc_info=True) Is it common that we want to ignore errors when removing directories? I think it will be safer to ignore only the ENOENT error by default, and let the caller handle other errors. Line 134: Line 135: Line 136: IPXMLRPCRequestHandler = SimpleXMLRPCRequestHandler Line 137: -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: xmlrpc: Parsing error logging enhancement - vdsClient

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient ...................................................................... Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4404/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5284/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format ...................................................................... Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4403/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5207/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/762/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5283/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format ...................................................................... Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4402/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5206/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/761/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5282/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 11 months

1
0
0 / 0

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed ...................................................................... Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4401/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5205/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5281/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I138c3eab77ea6d35d6a997049940923026e06d96 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

9 years, 11 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches November 2013