Change in vdsm[ovirt-3.3]: vm: Fix exception when shutdown() called on vm in 'Down' state
by gpadgett＠redhat.com
Hello Sandro Bonazzola, Federico Simoncelli, Doron Fediuck, Dan Kenigsberg, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22218
to review the following change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
......................................................................
vm: Fix exception when shutdown() called on vm in 'Down' state
Attempting to call the shutdown() method on a VM which is in 'Down'
state resulted in an exception if called through xmlrpclib. Instead,
adopt the convention used by similar APIs such as migrate() and return
errCode['noVM'].
Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698
Bug-Url: https://bugzilla.redhat.com/1027297
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21937
Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Reviewed-by: Doron Fediuck <dfediuck(a)redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com>
Reviewed-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/22218/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index b9ab60b..59541e7 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2483,7 +2483,7 @@
try:
now = time.time()
if self.lastStatus == 'Down':
- return
+ return errCode['noVM']
if self.guestAgent and self.guestAgent.isResponsive():
self._guestEventTime = now
self._guestEvent = 'Powering down'
--
To view, visit http://gerrit.ovirt.org/22218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b75d0b869354d503e5f187e33370b5837b3c698
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: storage.misc: use the new util.isOvirtNode()
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: storage.misc: use the new util.isOvirtNode()
......................................................................
storage.misc: use the new util.isOvirtNode()
Change-Id: I6da5c94b5a8c11eace4813530570380c651e6d88
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/storage/misc.py
1 file changed, 5 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/20809/1
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index fc13a9c..7b8d8ea 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -62,7 +62,6 @@
DATASYNCFLAG = "fdatasync"
STR_UUID_SIZE = 36
UUID_HYPHENS = [8, 13, 18, 23]
-OVIRT_NODE = False
MEGA = 1 << 20
UNLIMITED_THREADS = -1
@@ -508,7 +507,7 @@
for key in keys:
oldName = os.path.join(directory, fd[key]['old'])
newName = os.path.join(directory, fd[key]['new'])
- if OVIRT_NODE and persist and not cp:
+ if utils.isOvirtNode() and persist and not cp:
try:
execCmd([constants.EXT_UNPERSIST, oldName], logErr=False,
sudo=True)
@@ -519,7 +518,8 @@
try:
if cp:
execCmd([constants.EXT_CP, oldName, newName], sudo=True)
- if OVIRT_NODE and persist and not os.path.exists(newName):
+ if (utils.isOvirtNode() and persist and
+ not os.path.exists(newName)):
execCmd([constants.EXT_PERSIST, newName], logErr=False,
sudo=True)
@@ -527,7 +527,7 @@
os.rename(oldName, newName)
except:
pass
- if OVIRT_NODE and persist and not cp:
+ if utils.isOvirtNode() and persist and not cp:
try:
execCmd([constants.EXT_PERSIST, newName], logErr=False,
sudo=True)
@@ -536,7 +536,7 @@
def persistFile(name):
- if OVIRT_NODE:
+ if utils.isOvirtNode():
execCmd([constants.EXT_PERSIST, name], sudo=True)
@@ -1109,13 +1109,6 @@
return True
except (UnicodeDecodeError, UnicodeEncodeError):
return False
-
-# Upon import determine if we are running on ovirt
-try:
- OVIRT_NODE = os.path.exists('/etc/rhev-hypervisor-release') or \
- not len(glob.glob('/etc/ovirt-node-*-release')) == 0
-except:
- pass
def walk(top, topdown=True, onerror=None, followlinks=False, blacklist=[]):
--
To view, visit http://gerrit.ovirt.org/20809
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6da5c94b5a8c11eace4813530570380c651e6d88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: rpm_spec: Add ethtool as a requirement
by asegurap＠redhat.com
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: rpm_spec: Add ethtool as a requirement
......................................................................
rpm_spec: Add ethtool as a requirement
The new ipwrapper link type detection depends on the ethtool binary
that is commonly installed by default but not on minimal
installations. This patch ensures that it is not missing.
Change-Id: Idc8c806decad74b3e90d485eb8e9a57eeac41ebf
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/22177/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 385a29b..1a8ce72 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -91,6 +91,7 @@
BuildRequires: systemd-units
%endif
+Requires: ethtool
Requires: which
Requires: sudo >= 1.7.3
Requires: logrotate
--
To view, visit http://gerrit.ovirt.org/22177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc8c806decad74b3e90d485eb8e9a57eeac41ebf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: lvm.env: move to /usr/share/vdsm/storage
......................................................................
lvm.env: move to /usr/share/vdsm/storage
lvm.env is a tiny helper script, intended to make it a bit easier to
debug Vdsm-controlled lvm state. It is being created whenever the lvm
module is loaded, which generates an annoying warning message in unit
test.
This patch makes lvm.env ship statically with vdsm. It can be used by
. /usr/share/vdsm/storage/lvm.env
Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
M vdsm.spec.in
M vdsm/storage/Makefile.am
A vdsm/storage/lvm.env.in
M vdsm/storage/lvm.py
5 files changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/21872/1
diff --git a/.gitignore b/.gitignore
index 7ec1993..3042c43 100644
--- a/.gitignore
+++ b/.gitignore
@@ -53,6 +53,7 @@
vdsm/mom.conf
vdsm/sos/vdsm.py
vdsm/storage/protect/safelease
+vdsm/storage/lvm.env
vdsm/storage/vdsm-lvm.rules
vdsm/sudoers.vdsm
vdsm/svdsm.logger.conf
diff --git a/vdsm.spec.in b/vdsm.spec.in
index f248b74..a059ad6 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -912,6 +912,7 @@
%{_datadir}/%{vdsm_name}/storage/iscsi.py*
%{_datadir}/%{vdsm_name}/storage/localFsSD.py*
%{_datadir}/%{vdsm_name}/storage/lvm.py*
+%{_datadir}/%{vdsm_name}/storage/lvm.env
%{_datadir}/%{vdsm_name}/storage/misc.py*
%{_datadir}/%{vdsm_name}/storage/mount.py*
%{_datadir}/%{vdsm_name}/storage/multipath.py*
diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am
index 2d3e9a6..6d0d769 100644
--- a/vdsm/storage/Makefile.am
+++ b/vdsm/storage/Makefile.am
@@ -20,6 +20,8 @@
SUBDIRS = protect imageRepository
+include $(top_srcdir)/build-aux/Makefile.subs
+
vdsmstoragedir = $(vdsmdir)/storage
dist_vdsmstorage_PYTHON = \
__init__.py \
@@ -71,5 +73,13 @@
dist_vdsmexec_SCRIPTS = \
curl-img-wrap
+nodist_vdsmstorage_DATA = \
+ lvm.env \
+ $(NULL)
+
+EXTRA_DIST = \
+ lvm.env.in \
+ $(NULL)
+
check-local:
PYTHONPATH="$(top_srcdir)/lib:$$PYTHONPATH" PYTHONDONTWRITEBYTECODE=1 $(PYTHON) $(srcdir)/storage_exception.py
diff --git a/vdsm/storage/lvm.env.in b/vdsm/storage/lvm.env.in
new file mode 100644
index 0000000..25f73cb
--- /dev/null
+++ b/vdsm/storage/lvm.env.in
@@ -0,0 +1,4 @@
+#
+# source this into your shell to gain vdsm's view of lvm.
+#
+export LVM_SYSTEM_DIR=@VDSMRUNDIR@/lvm
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 559f169..2b892d7 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -161,19 +161,6 @@
log.warning("Cannot create %s file %s", VDSM_LVM_CONF, str(e))
-def _setupLVMEnv():
- lvmenvfname = os.path.join(VAR_RUN_VDSM, "lvm.env")
- with file(lvmenvfname, "w") as lvmenv:
- lvmenv.write("export LVM_SYSTEM_DIR=%s\n" % VDSM_LVM_SYSTEM_DIR)
-
-
-def _setupLVM():
- try:
- _setupLVMEnv()
- except IOError as e:
- log.warning("Cannot create env file %s", e)
-
-
#
# Make sure that "args" is suitable for consumption in interfaces
# that expect an iterabale argument. The string is treated a single
@@ -294,7 +281,6 @@
def __init__(self):
self._filterStale = True
self._extraCfg = None
- _setupLVM()
self._filterLock = threading.Lock()
self._oplock = misc.OperationMutex()
self._stalepv = True
--
To view, visit http://gerrit.ovirt.org/21872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: domainMonitor: Rename confusing lastCheck variable
......................................................................
domainMonitor: Rename confusing lastCheck variable
In repoStats we use the "lastCheck" value as the time since domain
status was checked. In DomainMonitorStatus we use "lastCheck" value as
the time were domain was checked. This patch eliminates the confusion
by using "time" for the time where status was checked.
Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/domainMonitor.py
M vdsm/storage/hsm.py
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/21879/1
diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py
index 5b0d4ac..e08c045 100644
--- a/vdsm/storage/domainMonitor.py
+++ b/vdsm/storage/domainMonitor.py
@@ -33,7 +33,7 @@
class DomainMonitorStatus(object):
__slots__ = (
- "error", "lastCheck", "valid", "readDelay", "masterMounted",
+ "error", "time", "valid", "readDelay", "masterMounted",
"masterValid", "diskUtilization", "vgMdUtilization",
"vgMdHasEnoughFreeSpace", "vgMdFreeBelowThreashold", "hasHostId",
"isoPrefix", "version",
@@ -44,7 +44,7 @@
def clear(self):
self.error = None
- self.lastCheck = NOT_CHECKED_YET
+ self.time = NOT_CHECKED_YET
self.valid = True
self.readDelay = 0
self.diskUtilization = (None, None)
@@ -237,7 +237,7 @@
"information", self.sdUUID, exc_info=True)
self.nextStatus.error = e
- self.nextStatus.lastCheck = time()
+ self.nextStatus.time = time()
self.nextStatus.valid = (self.nextStatus.error is None)
if self._statusDidChange():
@@ -264,5 +264,5 @@
self.status.update(self.nextStatus)
def _statusDidChange(self):
- return (self.status.lastCheck == NOT_CHECKED_YET or
+ return (self.status.time == NOT_CHECKED_YET or
self.status.valid != self.nextStatus.valid)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 1fff3c3..8287da4 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3627,10 +3627,10 @@
disktotal, diskfree = domStatus.diskUtilization
vgmdtotal, vgmdfree = domStatus.vgMdUtilization
- lastcheck = '%.1f' % (statsGenTime - domStatus.lastCheck)
+ lastcheck = '%.1f' % (statsGenTime - domStatus.time)
repoStats[sdUUID] = {
- 'finish': domStatus.lastCheck,
+ 'finish': domStatus.time,
'result': {
'code': code,
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Removing hack for stopping libvirt-guests as conflict service
......................................................................
Removing hack for stopping libvirt-guests as conflict service
Due to recent fix in libvirt, libvirt-guests daemon now returns right
error code when checking its status. Thanks to that we can treat
libvirt-guests as all other daemons.
Change-Id: I61b274587e811edfbe63a02d762764700acd3eec
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M init/sysvinit/vdsmd.init.in
M vdsm.spec.in
2 files changed, 10 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/21205/1
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index ea1ea85..6ef5718 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -48,25 +48,16 @@
local conflicting_services="$1"
for srv in ${conflicting_services}; do
- if [ "$srv" == "libvirt-guests" ]; then
- # `service libvirt-guests stop` tries to access libvirtd and
- # requires sasl authentication. Instead, removing the lockfile
- # signifies to libvirt-guests that it has stopped.
- # TODO: This condition needs to be removed when BZ 1011981 fix will
- # be available.
- "@RM_PATH@" -f /var/lock/subsys/libvirt-guests >/dev/null 2>&1
- else
- if initctl status "${srv}" >/dev/null 2>&1; then
- # When srv is Upstart service, status srv always returns 0
- initctl stop "${srv}" || : # stop fails when already down
- initctl status "${srv}" | grep -q stop/waiting
- elif [ -x "/etc/init.d/${srv}" ]; then
- if service "${srv}" status >/dev/null 2>&1; then
- service "${srv}" stop
- fi
- else
- true
+ if initctl status "${srv}" >/dev/null 2>&1; then
+ # When srv is Upstart service, status srv always returns 0
+ initctl stop "${srv}" || : # stop fails when already down
+ initctl status "${srv}" | grep -q stop/waiting
+ elif [ -x "/etc/init.d/${srv}" ]; then
+ if service "${srv}" status >/dev/null 2>&1; then
+ service "${srv}" stop
fi
+ else
+ true
fi
ret_val=$?
if [ "${ret_val}" -ne 0 ]; then
diff --git a/vdsm.spec.in b/vdsm.spec.in
index cdb5af7..22e36b8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -121,7 +121,7 @@
Requires: libvirt-daemon-driver-qemu
%else
%if 0%{?rhel}
-Requires: libvirt >= 0.10.2-18.el6_4.10
+Requires: libvirt >= 0.10.2-18.el6_4.15
%else
Requires: libvirt >= 1.0.2-1
%endif
--
To view, visit http://gerrit.ovirt.org/21205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: use defined options from configure
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: use defined options from configure
......................................................................
use defined options from configure
Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17
Signed-off-by: Alexey Shabalin <a.shabalin(a)gmail.com>
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18694
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M init/vdsmd_init_common.sh.in
M lib/vdsm/tool/libvirt_configure.sh.in
2 files changed, 17 insertions(+), 17 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alexey Shabalin <a.shabalin(a)gmail.com>
Gerrit-Reviewer: Alexey Shabalin <a.shabalin(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in vdsm[master]: use defined options from configure
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: use defined options from configure
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alexey Shabalin <a.shabalin(a)gmail.com>
Gerrit-Reviewer: Alexey Shabalin <a.shabalin(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 9 months
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: domainMonitor: Separate change detection from lastCheck value
......................................................................
domainMonitor: Separate change detection from lastCheck value
Since commit b4b8a7666b68, lastCheck value is initialized to special
NOT_CHECKED_YET value, and use to for detecting the first monitor status
change. This change caused repoStats to return high lastCheck value
until the first monitor check is done. Previously, lastCheck value was
initialized to monitor thread creation time, and repoStat was returning
"valid" lastCheck value during the first check.
This patch restore the previous behavior and use a new "checked" flag
for detecting monitor status changes.
Change-Id: I8e0df2ee0333354146b5d9429fd83a4f914ff751
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/domainMonitor.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/21878/1
diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py
index 5b0d4ac..e03fc28 100644
--- a/vdsm/storage/domainMonitor.py
+++ b/vdsm/storage/domainMonitor.py
@@ -28,12 +28,10 @@
from vdsm.config import config
from sdc import sdCache
-NOT_CHECKED_YET = -1
-
class DomainMonitorStatus(object):
__slots__ = (
- "error", "lastCheck", "valid", "readDelay", "masterMounted",
+ "error", "checked", "lastCheck", "valid", "readDelay", "masterMounted",
"masterValid", "diskUtilization", "vgMdUtilization",
"vgMdHasEnoughFreeSpace", "vgMdFreeBelowThreashold", "hasHostId",
"isoPrefix", "version",
@@ -44,7 +42,8 @@
def clear(self):
self.error = None
- self.lastCheck = NOT_CHECKED_YET
+ self.checked = False
+ self.lastCheck = time.time()
self.valid = True
self.readDelay = 0
self.diskUtilization = (None, None)
@@ -237,6 +236,7 @@
"information", self.sdUUID, exc_info=True)
self.nextStatus.error = e
+ self.nextStatus.checked = True
self.nextStatus.lastCheck = time()
self.nextStatus.valid = (self.nextStatus.error is None)
@@ -264,5 +264,5 @@
self.status.update(self.nextStatus)
def _statusDidChange(self):
- return (self.status.lastCheck == NOT_CHECKED_YET or
+ return (not self.status.checked or
self.status.valid != self.nextStatus.valid)
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e0df2ee0333354146b5d9429fd83a4f914ff751
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
9 years, 9 months
Change in vdsm[master]: use defined options from configure
by ybronhei＠redhat.com
Yaniv Bronhaim has posted comments on this change.
Change subject: use defined options from configure
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/18694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alexey Shabalin <a.shabalin(a)gmail.com>
Gerrit-Reviewer: Alexey Shabalin <a.shabalin(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 9 months