vdsm-patches August 2013

vdsm-patches@lists.fedorahosted.org

39 participants
459 discussions

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...
by gvallare＠redhat.com 04 Aug '13

04 Aug '13

Giuseppe Vallarelli has uploaded a new change for review. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. ...................................................................... refactoring: fix imports stmts, replaced glob with iglob for uniformity. Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Signed-off-by: Giuseppe Vallarelli <gvallare(a)redhat.com> --- M lib/vdsm/netinfo.py 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/16838/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index 114dcb8..8d14db4 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -18,23 +18,23 @@ # Refer to the README and COPYING files for full details of the license # -import os import errno -import glob +from fnmatch import fnmatch from glob import iglob -import ethtool -import shlex +from itertools import chain import logging +import os +import shlex import socket import struct -from fnmatch import fnmatch from xml.dom import minidom -from itertools import chain + +import ethtool from config import config +import constants from ipwrapper import Route from ipwrapper import routeShowAllDefaultGateways -import constants import libvirtconnection NET_CONF_DIR = '/etc/sysconfig/network-scripts/' @@ -137,11 +137,11 @@ def vlans(): - return [b.split('/')[-1] for b in glob.glob('/sys/class/net/*.*')] + return [b.split('/')[-1] for b in iglob('/sys/class/net/*.*')] def bridges(): - return [b.split('/')[-2] for b in glob.glob('/sys/class/net/*/bridge') + return [b.split('/')[-2] for b in iglob('/sys/class/net/*/bridge') if b.split('/')[-2] != DUMMY_BRIDGE] -- To view, visit http://gerrit.ovirt.org/16838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <gvallare(a)redhat.com>

6 21

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
by gvallare＠redhat.com 04 Aug '13

04 Aug '13

Giuseppe Vallarelli has uploaded a new change for review. Change subject: QoS host networks: caps now reports QoS for networks. ...................................................................... QoS host networks: caps now reports QoS for networks. In the context of applying QoS to host networks it's important to report the current networks' QoS. Example follows below: 'awesome': {'addr': '', 'bridged': True, 'cfg': {'DELAY': '0', 'DEVICE': 'franta', 'NM_CONTROLLED': 'no', 'ONBOOT': 'yes', 'TYPE': 'Bridge'}, 'gateway': '0.0.0.0', 'iface': 'awesome', 'ipv6addrs': ['fe80::210:18ff:fee1:6d2e/64'], 'ipv6gateway': '::', 'mtu': '1500', 'netmask': '', 'ports': ['p1p4'], 'qosInbound': {'average': '1024', 'burst': '2048', 'peak': ''}, 'qosOutbound': {'average': '2400', 'burst': '', 'peak': ''}, 'stp': 'off'} In case a QoS is not defined in for incoming/inbound or outgoing/outbond traffic an empty string is placed instead to mark as undefined. Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Signed-off-by: Giuseppe Vallarelli <gvallare(a)redhat.com> --- M lib/vdsm/netinfo.py M tests/netinfoTests.py 2 files changed, 74 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/17218/1 diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py index f451db4..4b5129a 100644 --- a/lib/vdsm/netinfo.py +++ b/lib/vdsm/netinfo.py @@ -18,6 +18,7 @@ # Refer to the README and COPYING files for full details of the license # +from collections import namedtuple import os import errno import glob @@ -52,6 +53,8 @@ DEFAULT_MTU = '1500' REQUIRED_BONDINGS = frozenset(('bond0', 'bond1', 'bond2', 'bond3', 'bond4')) + +Qos = namedtuple('Qos', 'inbound outbound') def _match_name(name, patterns): @@ -402,10 +405,56 @@ return paddr -def _getNetInfo(iface, bridged, routes, ipv6routes): +def _parseBandwidthQos(networkXml): + """ + Retrieves QoS definition if available for the network. + :param networkXml: libvirt xml definition of a network. + :return: + """ + + def createQosDict(elem): + qos_dict = {'average': elem.getAttribute('average'), + 'burst': elem.getAttribute('burst'), + 'peak': elem.getAttribute('peak')} + return qos_dict + + qos = Qos(None, None) + + doc = minidom.parseString(networkXml) + bandwidthElem = doc.getElementsByTagName('bandwidth') + if bandwidthElem: + inboundElem = bandwidthElem[0].getElementsByTagName('inbound') + outboundElem = bandwidthElem[0].getElementsByTagName('outbound') + if inboundElem: + inbound = createQosDict(inboundElem[0]) + else: + inbound = None + if outboundElem: + outbound = createQosDict(outboundElem[0]) + else: + outbound = None + qos = Qos(inbound, outbound) + + return qos + + +def _getBandwidthQos(network): + qos = Qos(None, None) + + if network in networks(): + cn = libvirtconnection.get() + networkXml = cn.networkLookupByName(LIBVIRT_NET_PREFIX + + network).XMLDesc(0) + qos = _parseBandwidthQos(networkXml) + + return qos + + +def _getNetInfo(network, iface, bridged, routes, ipv6routes): '''Returns a dictionary of properties about the network's interface status. Raises a KeyError if the iface does not exist.''' data = {} + try: if bridged: data.update({'ports': ports(iface), 'stp': bridge_stp_state(iface), @@ -416,13 +465,16 @@ # comment when the version is no longer supported. data['interface'] = iface + qos = _getBandwidthQos(network) ipv4addr, ipv4netmask, ipv6addrs = getIpInfo(iface) data.update({'iface': iface, 'bridged': bridged, 'addr': ipv4addr, 'netmask': ipv4netmask, 'gateway': routes.get(iface, '0.0.0.0'), 'ipv6addrs': ipv6addrs, 'ipv6gateway': ipv6routes.get(iface, '::'), - 'mtu': str(getMtu(iface))}) + 'mtu': str(getMtu(iface)), + 'qosInbound': qos.inbound if qos.inbound else '', + 'qosOutbound': qos.outbound if qos.outbound else ''}) except (IOError, OSError) as e: if e.errno == errno.ENOENT: logging.info('Obtaining info for net %s.', iface, exc_info=True) @@ -478,7 +530,7 @@ for net, netAttr in networks().iteritems(): try: - d['networks'][net] = _getNetInfo(netAttr.get('iface', net), + d['networks'][net] = _getNetInfo(net, netAttr.get('iface', net), netAttr['bridged'], routes, ipv6routes) except KeyError: diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py index 7cf65c3..878a8a9 100644 --- a/tests/netinfoTests.py +++ b/tests/netinfoTests.py @@ -168,3 +168,22 @@ set(['em', 'me', 'fake', 'fake0'])) finally: rmtree(temp_dir) + + def testGetBandwidthQos(self): + notEmptyDoc = ("""<bandwidth> + <inbound average='4500' burst='5400' /> + <outbound average='4500' burst='5400' peak='101' /> + </bandwidth>""") + expectedQosNotEmpty = netinfo.Qos(inbound={'average': '4500', + 'burst': '5400', + 'peak': ''}, + outbound={'average': '4500', + 'burst': '5400', + 'peak': '101'}) + + emptyDoc = "<whatever></whatever>" + + self.assertEqual(expectedQosNotEmpty, + netinfo._parseBandwidthQos(notEmptyDoc)) + self.assertEqual(netinfo.Qos(None, None), + netinfo._parseBandwidthQos(emptyDoc)) -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <gvallare(a)redhat.com>

6 32

Change in vdsm[master]: multipath: Use reload option on multipath rescan
by ykaplan＠redhat.com 04 Aug '13

04 Aug '13

Yeela Kaplan has uploaded a new change for review. Change subject: multipath: Use reload option on multipath rescan ...................................................................... multipath: Use reload option on multipath rescan Change-Id: I39f0789c8f296fe0e38739128ade45bca8833cb1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=964768 Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com> --- M vdsm/storage/multipath.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/17263/1 diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py index 3dcf41f..7f647e5 100644 --- a/vdsm/storage/multipath.py +++ b/vdsm/storage/multipath.py @@ -108,7 +108,8 @@ supervdsm.getProxy().forceScsiScan() # Now let multipath daemon pick up new devices - misc.execCmd([constants.EXT_MULTIPATH], sudo=True) + cmd = [constants.EXT_MULTIPATH, "-r"] + misc.execCmd(cmd, sudo=True) def isEnabled(): -- To view, visit http://gerrit.ovirt.org/17263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39f0789c8f296fe0e38739128ade45bca8833cb1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>

6 5

Change in vdsm[master]: tests: addNetwork/setupNetworks behaviour with invalid vlan ...
by gvallare＠redhat.com 02 Aug '13

02 Aug '13

Giuseppe Vallarelli has uploaded a new change for review. Change subject: tests: addNetwork/setupNetworks behaviour with invalid vlan names. ...................................................................... tests: addNetwork/setupNetworks behaviour with invalid vlan names. Added a couple of functional tests: * testAddNetworkBadVlan * testSetupNetworksAddBadVlan covering current behaviour of invalid vlan names provided. Change-Id: Ibd324a74fcf9c2f73887abf96a74638099f1df7c Signed-off-by: Giuseppe Vallarelli <gvallare(a)redhat.com> --- M tests/functional/networkTests.py 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/17373/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index fc2b440..e7d49c4 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -28,6 +28,7 @@ NETWORK_NAME = 'test-network' VLAN_ID = '27' BONDING_NAME = 'bond0' +INVALID_VLANS = 'a', '4096' def setupModule(): @@ -227,6 +228,34 @@ @RequireDummyMod @ValidateRunningAsRoot + def testAddNetworkBadVlan(self): + with dummyIf(1) as nics: + status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, + vlan=INVALID_VLANS[0], + nics=nics) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, + vlan=INVALID_VLANS[1], + nics=nics) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + @RequireDummyMod + @ValidateRunningAsRoot + def testSetupNetworksAddBadVlan(self): + with dummyIf(1) as nics: + attrs = {'vlan': INVALID_VLANS[0], 'nic': nics[0]} + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + attrs['vlan'] = INVALID_VLANS[1] + status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME: attrs}, + {}, {}) + self.assertEquals(status, neterrors.ERR_BAD_VLAN, msg) + + @RequireDummyMod + @ValidateRunningAsRoot def testQosNetwork(self): with dummyIf(1) as nics: qos = {'qosInbound': {'average': '1024', 'burst': '2048', -- To view, visit http://gerrit.ovirt.org/17373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd324a74fcf9c2f73887abf96a74638099f1df7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <gvallare(a)redhat.com>

3 4

Change in vdsm[master]: jsonrpc: make TCPReactor IPv6 capable
by mhuntxu＠gmail.com 02 Aug '13

02 Aug '13

Hunt Xu has uploaded a new change for review. Change subject: jsonrpc: make TCPReactor IPv6 capable ...................................................................... jsonrpc: make TCPReactor IPv6 capable Change-Id: I108c3f804476ace8b9b1f0c5cca3f9b196d1163b Signed-off-by: huntxu <mhuntxu(a)gmail.com> --- M vdsm_api/jsonrpc/client.py M vdsm_api/jsonrpc/tcpReactor.py 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/11740/1 diff --git a/vdsm_api/jsonrpc/client.py b/vdsm_api/jsonrpc/client.py index 0975f64..e641f0f 100644 --- a/vdsm_api/jsonrpc/client.py +++ b/vdsm_api/jsonrpc/client.py @@ -6,6 +6,8 @@ JsonRpcError, \ tcpReactor +from vdsm import utils + proton = None try: @@ -49,7 +51,10 @@ class TCPReactorClient(object): def __init__(self, address): - self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) + family = socket.AF_INET + if utils.isIPv6Address(address): + family = socket.AF_INET6 + self.sock = socket.socket(family, socket.SOCK_STREAM) self.address = address def connect(self): diff --git a/vdsm_api/jsonrpc/tcpReactor.py b/vdsm_api/jsonrpc/tcpReactor.py index a9cf40c..9789627 100644 --- a/vdsm_api/jsonrpc/tcpReactor.py +++ b/vdsm_api/jsonrpc/tcpReactor.py @@ -100,7 +100,10 @@ log = logging.getLogger("jsonrpc.TCPReactor") def __init__(self, address, messageHandler): - self._sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) + family = socket.AF_INET + if utils.isIPv6Address(address): + family = socket.AF_INET6 + self._sock = socket.socket(family, socket.SOCK_STREAM) self._addr = address self._messageHandler = messageHandler self._inputEvent = utils.PollEvent() -- To view, visit http://gerrit.ovirt.org/11740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I108c3f804476ace8b9b1f0c5cca3f9b196d1163b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhuntxu(a)gmail.com>

5 15

Change in vdsm[ovirt-3.3]: spec: vdsm-hook-sriov on el6 should not require non-existing...
by Dan Kenigsberg 01 Aug '13

01 Aug '13

Hello Antoni Segura Puimedon, Dead Horse, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/17591 to review the following change. Change subject: spec: vdsm-hook-sriov on el6 should not require non-existing rpm ...................................................................... spec: vdsm-hook-sriov on el6 should not require non-existing rpm As reported by a dead horse, el6 does not carry libvirt-daemon-driver-nodedev so the said hook should not require this subrpm. Since it the rpm hook is meaningful only when vdsm is installed, and el6's vdsm requires al libvirt, we need no special requirement there. Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/17554 Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com> Reviewed-by: Dead Horse <deadhorseconsulting(a)gmail.com> Tested-by: Dead Horse <deadhorseconsulting(a)gmail.com> --- M vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/17591/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index d95bb2a..87bc231 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -483,7 +483,9 @@ %package hook-sriov Summary: sr-iov support for VDSM +%if 0%{?rhel} >= 7 || 0%{?fedora} >= 18 Requires: libvirt-daemon-driver-nodedev +%endif BuildArch: noarch %description hook-sriov -- To view, visit http://gerrit.ovirt.org/17591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dead Horse <deadhorseconsulting(a)gmail.com>

2 3

Change in vdsm[master]: spec: vdsm-hook-sriov on el6 should require libvirt
by Dan Kenigsberg 01 Aug '13

01 Aug '13

Dan Kenigsberg has uploaded a new change for review. Change subject: spec: vdsm-hook-sriov on el6 should require libvirt ...................................................................... spec: vdsm-hook-sriov on el6 should require libvirt As reported by a dead horse, el6 does not carry libvirt-daemon-driver-nodedev so the said hook should not require this subrpm. Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/17554/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index d95bb2a..1305eec 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -483,7 +483,11 @@ %package hook-sriov Summary: sr-iov support for VDSM +%if 0%{?rhel} >= 7 || 0%{?fedora} >= 18 Requires: libvirt-daemon-driver-nodedev +%else +Requires: libvirt +%endif BuildArch: noarch %description hook-sriov -- To view, visit http://gerrit.ovirt.org/17554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25bfec65fd017a048102d6321335c747a17b5dd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

3 7

Change in vdsm[master]: VDSM now writes its version number in VDSM-generated ifcfg f...
by amuller＠redhat.com 01 Aug '13

01 Aug '13

Assaf Muller has uploaded a new change for review. Change subject: VDSM now writes its version number in VDSM-generated ifcfg files ...................................................................... VDSM now writes its version number in VDSM-generated ifcfg files Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7313 Signed-off-by: Assaf Muller <amuller(a)redhat.com> --- M vdsm/netconf/ifcfg.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/17566/1 diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py index d48cd82..bf0e738 100644 --- a/vdsm/netconf/ifcfg.py +++ b/vdsm/netconf/ifcfg.py @@ -28,6 +28,7 @@ import shutil import threading +import dsaversion from netconf import Configurator from neterrors import ConfigNetworkError from netmodels import Nic, Bridge @@ -446,9 +447,11 @@ gateway=None, bootproto=None, mtu=None, onboot='yes', **kwargs): """ Create ifcfg-* file with proper fields per device """ + cfg = """# Generated by VDSM version %s\n""" % \ + dsaversion.raw_version_revision - cfg = """DEVICE=%s\nONBOOT=%s\n""" % (pipes.quote(name), - pipes.quote(onboot)) + cfg += """DEVICE=%s\nONBOOT=%s\n""" % (pipes.quote(name), + pipes.quote(onboot)) cfg += conf if ipaddr: cfg = cfg + 'IPADDR=%s\nNETMASK=%s\n' % (pipes.quote(ipaddr), -- To view, visit http://gerrit.ovirt.org/17566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7313 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>

3 4

Change in vdsm[master]: Add support for direct setting of cpu_shares when creating a...
by Martin Sivak 01 Aug '13

01 Aug '13

Martin Sivák has uploaded a new change for review. Change subject: Add support for direct setting of cpu_shares when creating a VM ...................................................................... Add support for direct setting of cpu_shares when creating a VM This adds new API field to the Vm structures. The new field 'cpuShares' will override the old 'nice' when used. Change-Id: I7ef73cf0579a0efd5a31c32638efcc6cdf2447d7 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 2 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/17528/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 2fa5a45..c1cc51f 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -2804,8 +2804,15 @@ nice = int(self.conf.get('nice', '0')) nice = max(min(nice, 19), 0) + + # if cpu_shares weren't configured we derive the value from the + # niceness, cpu_shares has not unit, it is only meaningful when + # compared to other VMs (and can't be negative) + cpu_shares = int(self.conf.get('cpuShares', str((20 - nice) * 51))) + cpu_shares = max(cpu_shares, 0) + try: - self._dom.setSchedulerParameters({'cpu_shares': (20 - nice) * 51}) + self._dom.setSchedulerParameters({'cpu_shares': cpu_shares}) except: self.log.warning('failed to set Vm niceness', exc_info=True) diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 71878e4..fdb4c66 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2632,6 +2632,8 @@ # # @clientIp: The IP address of the client connected to the display # +# @cpuShares: The host scheduling priority (relative to other VMs) +# # @cpuType: #optional The type of CPU being emulated # special values 'hostPassthrough' and 'hostModel' # are reserved for host-passthrough and host-mode cpu @@ -2694,8 +2696,8 @@ # Since: 4.10.0 ## {'type': 'VmDefinition', - 'data': {'acpiEnable': 'bool', 'clientIp': 'str', '*cpuType': 'str', - '*custom': 'StringMap', '*devices': ['VmDevice'], + 'data': {'acpiEnable': 'bool', 'clientIp': 'str', 'cpuShares': 'str', + '*cpuType': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], 'display': 'VmDisplayType', 'displayIp': 'str', 'displayPort': 'int', 'displaySecurePort': 'int', '*emulatedMachine': 'str', '*keyboardLayout': 'str', @@ -2713,6 +2715,8 @@ # Parameters for creating a new virtual machine # # @acpiEnable: Indicates if ACPI is enabled inside the VM +# +# @cpuShares: The host scheduling priority (relative to other VMs) # # @custom: #optional A dictionary of custom, free-form properties # @@ -2747,7 +2751,7 @@ ## {'type': 'VmParameters', 'data': {'acpiEnable': 'bool', - '*custom': 'StringMap', '*devices': ['VmDevice'], + 'cpuShares': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], 'display': 'VmDisplayType', 'kvmEnable': 'bool', 'memSize': 'uint', 'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint', -- To view, visit http://gerrit.ovirt.org/17528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ef73cf0579a0efd5a31c32638efcc6cdf2447d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>

4 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches August 2013