Change in vdsm[master]: Remove orphaned files
by dkuznets＠redhat.com
Dima Kuznetsov has uploaded a new change for review.
Change subject: Remove orphaned files
......................................................................
Remove orphaned files
This patch removes files than are neither mentioned in any code nor
shipped int the dist tar file.
Change-Id: Ibce1a6c8044fdeae49d6f563a90383a58bf9b170
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
D vdsm/substitute_constants.py
D vdsm/write-net-config
2 files changed, 0 insertions(+), 62 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/35724/1
diff --git a/vdsm/substitute_constants.py b/vdsm/substitute_constants.py
deleted file mode 100644
index 6cecb5c..0000000
--- a/vdsm/substitute_constants.py
+++ /dev/null
@@ -1,53 +0,0 @@
-#!/usr/bin/python
-#
-# Copyright 2011 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# Refer to the README and COPYING files for full details of the license
-#
-
-import sys
-import re
-
-from vdsm import constants
-
-
-def replacement(m):
- s = m.group()
- return getattr(constants, 'EXT_' + s[1:-1],
- getattr(constants, s[1:-1], s))
-
-if len(sys.argv) <= 1:
- print """usage: %s filename...
-
-substitute all @CONSTANT@s in filename.
-""" % sys.argv[0]
-
-for fname in sys.argv[1:]:
- if fname == '-':
- f = sys.stdin
- else:
- f = open(fname)
-
- s = f.read()
- r = re.sub('@[^@\n]*@', replacement, s)
-
- if fname == '-':
- f = sys.stdout
- else:
- f = open(fname, 'w')
-
- f.write(r)
diff --git a/vdsm/write-net-config b/vdsm/write-net-config
deleted file mode 100755
index b77d892..0000000
--- a/vdsm/write-net-config
+++ /dev/null
@@ -1,9 +0,0 @@
-#!/bin/bash
-#
-# little wrapper to let vdsm write to root-owned /etc/sysconfig/network-scripts
-# (and to there only)
-
-case "$1" in
- /etc/sysconfig/network-scripts/ifcfg-*) cat > "$1";;
- *) echo skipping $1 1>&2 ;;
-esac
--
To view, visit http://gerrit.ovirt.org/35724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibce1a6c8044fdeae49d6f563a90383a58bf9b170
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
9 years, 4 months
Change in vdsm[master]: debian: Add noipspoof files to dist
by dkuznets＠redhat.com
Dima Kuznetsov has uploaded a new change for review.
Change subject: debian: Add noipspoof files to dist
......................................................................
debian: Add noipspoof files to dist
Change-Id: I01101133628d47bfebc66ccd510984d7c0666571
Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com>
---
M debian/Makefile.am
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/35723/1
diff --git a/debian/Makefile.am b/debian/Makefile.am
index 770a4c4..8eb06d8 100644
--- a/debian/Makefile.am
+++ b/debian/Makefile.am
@@ -63,6 +63,8 @@
vdsm-hook-macspoof.install \
vdsm-hook-nestedvt.docs \
vdsm-hook-nestedvt.install \
+ vdsm-hook-noipspoof.docs \
+ vdsm-hook-noipspoof.install \
vdsm-hook-numa.docs \
vdsm-hook-numa.install \
vdsm-hook-openstacknet.docs \
--
To view, visit http://gerrit.ovirt.org/35723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01101133628d47bfebc66ccd510984d7c0666571
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>
9 years, 4 months
Change in vdsm[master]: supervdsm: adhere to core_dump_enable
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: supervdsm: adhere to core_dump_enable
......................................................................
supervdsm: adhere to core_dump_enable
Change-Id: Id877e77046dd636c625e5043e358537c07b5beee
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/supervdsmServer
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/35480/1
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 9a447d3..c57870c 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -27,6 +27,7 @@
import threading
import re
import getopt
+import resource
import signal
import logging
import logging.config
@@ -408,6 +409,8 @@
def main(sockfile, pidfile=None):
log = logging.getLogger("SuperVdsm.Server")
zombiereaper.registerSignalHandler()
+ if not config.getboolean('vars', 'core_dump_enable'):
+ resource.setrlimit(resource.RLIMIT_CORE, (0, 0))
def bind(func):
def wrapper(_SuperVdsm, *args, **kwargs):
--
To view, visit http://gerrit.ovirt.org/35480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id877e77046dd636c625e5043e358537c07b5beee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
9 years, 4 months
Change in vdsm[ovirt-3.5]: Fixed %post script error during upgrade
by ybronhei＠redhat.com
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fixed %post script error during upgrade
......................................................................
Fixed %post script error during upgrade
During post script we initiates vdsm-tool set-saslpasswd call. On
upgrade we have mixed code that may lead to an error while calling
vdsm-tool script, as in the related bug.
In this patch we move the call to set-saslpasswd to init scripts. In
pre-script phase we can be sure that the newer code is running.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168689
Change-Id: Ib7808f4f217ba3d6d30a60fab6233e36a29f0098
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M init/vdsmd_init_common.sh.in
M vdsm.spec.in
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/35744/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index e637b59..9389e28 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -216,6 +216,10 @@
[ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}"
fi
}
+
+task_set_sasl_password() {
+ "$VDSM_TOOL" set-saslpasswd
+}
#### pre-start tasks end ####
@@ -252,6 +256,7 @@
# after load_needed_modules (modprobe bonding).
# NetworkManager must not crash on nmcli conn delete.
run_tasks " \
+ set_sasl_password \
mkdirs \
configure_coredump \
configure_vdsm_logs \
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0a285c6..c1b1e1c 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -759,8 +759,6 @@
%post
%{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
-# set the vdsm "secret" password for libvirt
-%{_bindir}/vdsm-tool set-saslpasswd
# After vdsm install we should create the logs files.
# In the install session we create it but since we use
--
To view, visit http://gerrit.ovirt.org/35744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7808f4f217ba3d6d30a60fab6233e36a29f0098
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 4 months