Change in vdsm[master]: caps: Repair collect numa information
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Repair collect numa information
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/27090/5/vdsm/caps.py
File vdsm/caps.py:
Line 199: def _getMemoryStatsByNumaCell(cell):
Line 200: """
Line 201: Get the memory stats of a specified numa node, the unit is MiB.
Line 202:
Line 203: :param cell: the index of numa node.
unrelated textual change
Line 204: :type cell: int
Line 205: :return: dict like {'total': '49141', 'free': '46783'}
Line 206: """
Line 207: cellMemInfo = libvirtconnection.get().getMemoryStats(cell, 0)
--
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10 years
Change in vdsm[master]: caps: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Modify memory units of numa node
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf59a940395cc9d6134503826552fe16053a76f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: vm: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Modify memory units of numa node
......................................................................
Patch Set 2: Code-Review-1
tiny nit
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: vm: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Modify memory units of numa node
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27403/2/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 1030: # @cpus: The guest cpu ids in this guest numa node. Refer to
Line 1031: # http://libvirt.org/formatdomain.html#elementsCPU
Line 1032: # for the format details.
Line 1033: #
Line 1034: # @memory: The total memory of this guest numa node in MB.
MiB, to be exact.
Line 1035: #
Line 1036: # Since: 4.15.0
Line 1037: ##
Line 1038: {'type': 'GuestNumaNode',
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10 years
Change in vdsm[master]: [WIP] Pyroute2 network configurator
by asegurap＠redhat.com
Antoni Segura Puimedon has posted comments on this change.
Change subject: [WIP] Pyroute2 network configurator
......................................................................
Patch Set 1:
I see that here you moved the interface.commit() to with interface:
Please, do those changes in the previous patch and leave only the bonding change in this one.
--
To view, visit http://gerrit.ovirt.org/27080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0dcd31aa611fcb82ec56d1172e2e6f54ff8a54
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Robert Cernak <robocernak(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <celebdor(a)gmail.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Robert Cernak <robocernak(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: [WIP] Pyroute2 network configurator
by asegurap＠redhat.com
Antoni Segura Puimedon has posted comments on this change.
Change subject: [WIP] Pyroute2 network configurator
......................................................................
Patch Set 2:
It looks good, the problem I see is the lack of consistency between sometimes using interface.commit() and others using with interface.
Can you explain why sometimes you use one and sometimes the other?
--
To view, visit http://gerrit.ovirt.org/27063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73b56980dd774bc1b97b3309877426f1b1a5309b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Robert Cernak <robocernak(a)gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <celebdor(a)gmail.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Robert Cernak <robocernak(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
