vdsm-patches June 2014

vdsm-patches@lists.fedorahosted.org

41 participants
740 discussions

Change in vdsm[master]: json-rpc: Protocol detection
by Jenkins CI RO 06 Jun '14

06 Jun '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: Protocol detection ...................................................................... Patch Set 34: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9753/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8816/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/688/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9602/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_g… : SUCCESS -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: json-rpc: Protocol detection
by Nir Soffer 06 Jun '14

06 Jun '14

Nir Soffer has posted comments on this change. Change subject: json-rpc: Protocol detection ...................................................................... Patch Set 33: (1 comment) http://gerrit.ovirt.org/#/c/26300/33/vdsm/protocolDetector.py File vdsm/protocolDetector.py: Line 178: self.log.warning("Unable to read data") Line 179: self._remove_connection(client_socket) Line 180: client_socket.close() Line 181: return Line 182: > Good catch. You found a fix of asyncore bug that we found. There was an iss I think that we do need it here, as I could reproduce it once or twice by accessing vdsm from engine running on a remote machine. This is probably not a typical setup, but there is no reason that it will fail. Line 183: self._remove_connection(client_socket) Line 184: try: Line 185: handler = self.detect_protocol(data) Line 186: except _CannotDetectProtocol: -- To view, visit http://gerrit.ovirt.org/26300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id739a40e2b37dcc175137ec91cd5ec166ad24a75 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: vm: Collect vm numa node runtime pin information
by Jenkins CI RO 06 Jun '14

06 Jun '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information ...................................................................... Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9751/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8814/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9600/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/647/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: blockVolume: Fix NameError when validating volume parameters
by Nir Soffer 06 Jun '14

06 Jun '14

Nir Soffer has uploaded a new change for review. Change subject: blockVolume: Fix NameError when validating volume parameters ...................................................................... blockVolume: Fix NameError when validating volume parameters Commit 5cd8c83ba62 was liberally verified, leaving undefined name. Fixed now thanks to pyflakes and make check. Change-Id: Ib0e7333dafd6adfec37ae880f51aa0a98978641b Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M vdsm/storage/blockVolume.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/28426/1 diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index 319fd62..81331fa 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -125,7 +125,7 @@ # Sparse-Raw not supported for block volumes if preallocate == volume.SPARSE_VOL and volFormat == volume.RAW_FORMAT: - raise se.IncorrectFormat(type2name(volFormat)) + raise se.IncorrectFormat(volume.type2name(volFormat)) @classmethod def createVolumeMetadataRollback(cls, taskObj, sdUUID, offs): -- To view, visit http://gerrit.ovirt.org/28426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0e7333dafd6adfec37ae880f51aa0a98978641b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>

3 6

Change in vdsm[master]: tests: execCmd stress test is not broken now
by Nir Soffer 06 Jun '14

06 Jun '14

Nir Soffer has uploaded a new change for review. Change subject: tests: execCmd stress test is not broken now ...................................................................... tests: execCmd stress test is not broken now Since commit ce66d754, utils.execCmd stress tests should always succeed. Change-Id: I77627254e0d832e8f496f1399ff7150b94234014 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M tests/utilsTests.py 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/28425/1 diff --git a/tests/utilsTests.py b/tests/utilsTests.py index a9a676b..75adea8 100644 --- a/tests/utilsTests.py +++ b/tests/utilsTests.py @@ -28,7 +28,6 @@ from testrunner import VdsmTestCase as TestCaseBase from testrunner import permutations, expandPermutations from testValidation import checkSudo -from testValidation import brokentest from testValidation import stresstest from vdsm import utils from vdsm import constants @@ -511,7 +510,6 @@ def test_read_stdout_stderr(self): self.check(self.read_stdout_stderr) - @brokentest("Always fails when using AsyncProc in sync mode") @stresstest def test_write_stdin_read_stderr(self): self.data = 'x' * self.BLOCK_SIZE * self.BLOCK_COUNT -- To view, visit http://gerrit.ovirt.org/28425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77627254e0d832e8f496f1399ff7150b94234014 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>

3 5

Change in vdsm[master]: vm: Collect vm numa node runtime pin information
by fromani＠redhat.com 06 Jun '14

06 Jun '14

Francesco Romani has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information ...................................................................... Patch Set 3: (4 comments) Looks OK, adding a few comments to improve it even further. http://gerrit.ovirt.org/#/c/28134/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 171: ('vm_sample_balloon_window', '2', None), Line 172: Line 173: ('vm_sample_vcpu_pin_interval', '2', Line 174: 'How often should we sample each vcpu runtime pinning to ' Line 175: 'which physical cpu core.'), Still not sure we need to sample so frequently. Is cpu pinning supposed to change that fast? Line 176: Line 177: ('vm_sample_vcpu_pin_window', '2', None), Line 178: Line 179: ('trust_store_path', '@TRUSTSTORE@', http://gerrit.ovirt.org/#/c/28134/3/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 175: pidFile = "/var/run/libvirt/qemu/%s.pid" % vmName Line 176: return open(pidFile).read() Line 177: Line 178: def _getVcpuPid(self, vmName): Line 179: runFile = "/var/run/libvirt/qemu/%s.xml" % vmName I don't like hardcoded paths but I guess we don't really have alternatives here. Do we? (Yep I see this pattern it is used elsewhere in this very file, room for future work of course.) Line 180: runInfo = xml.dom.minidom.parse(runFile) Line 181: vCpus = runInfo.getElementsByTagName('vcpus')[0] Line 182: vCpuSet = vCpus.getElementsByTagName('vcpu') Line 183: vCpuPids = {} Line 192: vCpuMemMaps = {} Line 193: for vCpuIndex, vCpuPid in vCpuPids.iteritems(): Line 194: numaMapsFile = "/proc/%s/task/%s/numa_maps" % (vmPid, vCpuPid) Line 195: if os.path.exists(numaMapsFile): Line 196: with open(numaMapsFile, 'r') as f: TL;DR: this code is good enough already I'm not a fan of the if os.path exists(a_file): with open(a_file) I'd rather prefer to do try with open(a_file) except IOError # something... or, in pythonic words, I generally prefer EAFP instead of LBYL: http://python.net/~goodger/projects/pycon/2007/idiomatic/handout.html#eafp-… Line 197: mappingNodes = map( Line 198: int, re.findall('N(\d+)=\d+', f.read())) Line 199: vCpuMemMaps[vCpuIndex] = list(set(mappingNodes)) Line 200: return vCpuMemMaps http://gerrit.ovirt.org/#/c/28134/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 489: vCpuMemoryMapping[vCpu]) Line 490: vmNumaNodeRuntimeMap = dict([(k, list(set(v))) for k, v in Line 491: vmNumaNodeRuntimeMap.iteritems()]) Line 492: if vmNumaNodeRuntimeMap: Line 493: stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap Thanks for the improvements in this function. It is possible to go the extra (final) mile and split it in a few helper methods? For some reasons I find this code unexpectedly dense. Line 494: Line 495: def get(self): Line 496: stats = {} Line 497: -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: vm: Collect vm numa node runtime pin information
by Jenkins CI RO 06 Jun '14

06 Jun '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information ...................................................................... Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9599/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/646/ : There was an infra issue, please contact infra(a)ovirt.org -- To view, visit http://gerrit.ovirt.org/28134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eac3b633efa5f81157f021515425b0c9e15d8f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: gitignore: Ignore new generated man page
by Nir Soffer 05 Jun '14

05 Jun '14

Nir Soffer has uploaded a new change for review. Change subject: gitignore: Ignore new generated man page ...................................................................... gitignore: Ignore new generated man page Commit 3762a03added3 added vdsm-tool manual, but did not upadte .gitignore, which broke "make check". Change-Id: I065c41326f40b46aff6069d9664a50467e83afa3 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/28419/1 diff --git a/.gitignore b/.gitignore index 6c41d2b..ed7de91 100644 --- a/.gitignore +++ b/.gitignore @@ -70,6 +70,7 @@ vdsm/vdsm.rwtab vdsm/vdsmd.8 vdsm/gluster/hostname.py +vdsm-tool/vdsm-tool.1 vdsm_api/vdsm-api.html vdsm_hooks/openstacknet/sudoers vdsm_hooks/persist-vdsm-hooks -- To view, visit http://gerrit.ovirt.org/28419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I065c41326f40b46aff6069d9664a50467e83afa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>

4 7

Change in vdsm[master]: blockVolume: fix validateCreateVolumeParams exception
by Federico Simoncelli 05 Jun '14

05 Jun '14

Federico Simoncelli has uploaded a new change for review. Change subject: blockVolume: fix validateCreateVolumeParams exception ...................................................................... blockVolume: fix validateCreateVolumeParams exception Change-Id: I874cfbad8091396548463b98a13249a25baf9e9f Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M vdsm/storage/blockVolume.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/28226/1 diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py index fba64a4..aca13d7 100644 --- a/vdsm/storage/blockVolume.py +++ b/vdsm/storage/blockVolume.py @@ -125,7 +125,7 @@ # Sparse-Raw not supported for block volumes if preallocate == volume.SPARSE_VOL and volFormat == volume.RAW_FORMAT: - raise se.IncorrectFormat(srcVolUUID) + raise se.IncorrectType(type2name(preallocate)) # Snapshot should be COW volume if srcVolUUID != volume.BLANK_UUID and volFormat != volume.COW_FORMAT: -- To view, visit http://gerrit.ovirt.org/28226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I874cfbad8091396548463b98a13249a25baf9e9f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 10

Change in vdsm[master]: This commit adds a man page for the vdsm-tool command line u...
by Jenkins CI RO 05 Jun '14

05 Jun '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: This commit adds a man page for the vdsm-tool command line utility. ...................................................................... Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9740/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8807/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9593/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3e4ab7947a151a30ccc1c1a41e8df9d02d1d65 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrew Dahms <andrewjdahms(a)gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

← Newer
1
...
67
68
69
70
71
72
73
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2014