Change in vdsm[master]: vdsm: Shuting down protocol detector fails
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Shuting down protocol detector fails
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29556/3/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 164: os.write(self._write_fd, '1')
Line 165: except OSError as e:
Line 166: if e.errno == errno.EINTR:
Line 167: self.wakeup()
Line 168: elif e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK. errno.EPIPE):
sorry to repeat my unrelated question: when do we expect to see EAGAIN here?
Line 169: raise
Line 170:
Line 171: def _cleanup_wakeup_pipe(self):
Line 172: try:
--
To view, visit http://gerrit.ovirt.org/29556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82119a61835fe335f2aa5da29fb8d3f2b8ae33fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9 years, 11 months
Change in vdsm[master]: vdsm: Shuting down protocol detector fails
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Shuting down protocol detector fails
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29556/1/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 166: if e.errno == errno.EPIPE:
Line 167: pass
Line 168: if e.errno == errno.EINTR:
Line 169: self.wakeup()
Line 170: elif e.errno not in (errno.EAGAIN, errno.EWOULDBLOCK):
> EPIPE should be here with EGAIN - these are the errors we can handle.
I do not follow. EAGAIN is not possible, right?
So why do we swallow it? If it ever happens, it's a bug, and we'd better know about it.
Line 171: raise
Line 172:
Line 173: def _cleanup_wakeup_pipe(self):
Line 174: try:
--
To view, visit http://gerrit.ovirt.org/29556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82119a61835fe335f2aa5da29fb8d3f2b8ae33fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
9 years, 11 months
Change in vdsm[master]: vdsm: Missing hostId parameter on reconstructMaster verb
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
......................................................................
vdsm: Missing hostId parameter on reconstructMaster verb
Json schema was not consistent with API.py for StoragePool class and
reconstructMaster method. There was missing hostId parameter.
Please note that there is parameter ordering difference for coresponding
xmlrpc poolReconstructMaster method.
Change-Id: I0695a21601b8f0765bc24c3cf273f1ba161a40a9
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1115466
Reviewed-on: http://gerrit.ovirt.org/29510
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Nir Soffer: Looks good to me, but someone else must approve
Saggi Mizrahi: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0695a21601b8f0765bc24c3cf273f1ba161a40a9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in vdsm[master]: vdsm: extend image over jsonrpc
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: extend image over jsonrpc
......................................................................
vdsm: extend image over jsonrpc
Schema file was not consistend with API.py. All the verbs should use
the same constructor param names as it is defined in API.py.
Bug-Url: https://bugzilla.redhat.com/1113670
Change-Id: I437a23e04f97fb89eb4cd5646b73d9b1bddf240a
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Reviewed-on: http://gerrit.ovirt.org/29359
Reviewed-by: Oved Ourfali <oourfali(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
---
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 12 insertions(+), 7 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Saggi Mizrahi: Looks good to me, approved
Dan Kenigsberg: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I437a23e04f97fb89eb4cd5646b73d9b1bddf240a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in vdsm[master]: vdsm: verifyingTransport testing
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: verifyingTransport testing
......................................................................
vdsm: verifyingTransport testing
Changing unused command line test to unit test. SecureXMLRPCServer is
not used by vdsm code base and it was moved to verifyingTransportTests
to be used to make sure that Verifing* classes work.
Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Reviewed-on: http://gerrit.ovirt.org/28858
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
M debian/vdsm-python.install
M lib/vdsm/Makefile.am
D lib/vdsm/SecureXMLRPCServer.py
M lib/vdsm/sslutils.py
M lib/vdsm/vdscli.py
M tests/Makefile.am
M tests/jsonRpcHelper.py
M tests/makecert.sh
M tests/run_tests_local.sh.in
M tests/sslTests.py
A tests/sslhelper.py
M vdsm.spec.in
M vdsm/kaxmlrpclib.py
14 files changed, 253 insertions(+), 234 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Nir Soffer: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in vdsm[master]: vdsm: verifyingTransport testing
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
......................................................................
Patch Set 14: Code-Review+2
raising score.
Thanks a lot for making this test work again (thanks for authoring and reviewing)
--
To view, visit http://gerrit.ovirt.org/28858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 11 months
Change in vdsm[master]: virt: move XML processing in a module
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: virt: move XML processing in a module
......................................................................
Patch Set 3:
Improved naming.
Avoided just the simple 'xml.py' to avoid name clashing _inside_ the new module. 'vmxml.py' is somehow bearable but I'm very open to suggestions.
--
To view, visit http://gerrit.ovirt.org/26855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77dd048067b8abcb77f4b9bf55fbfd0535672996
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 11 months
Change in vdsm[master]: tests: Add symlink mount test
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add symlink mount test
......................................................................
Patch Set 6: Code-Review+1
Fine by me, but I'd love to give Enrico the opportunity to ack this, too.
--
To view, visit http://gerrit.ovirt.org/27514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3d6333921505846f345d015907e5f6174af4f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Enrico Tagliavini <enrico.tagliavini(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Enrico Tagliavini <enrico.tagliavini(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 11 months
