Change in vdsm[ovirt-3.5]: tool: Remove pointless __init__ methods
by mtayer＠redhat.com
Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32060
to review the following change.
Change subject: tool: Remove pointless __init__ methods
......................................................................
tool: Remove pointless __init__ methods
Some configurators had pointless __init__ methods. There is not need to
implement these if they are empty. Keeping them only cause developers to
copy and paste this useless code when they create new configurators.
Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31740
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurators/__init__.py
M lib/vdsm/tool/configurators/sanlock.py
2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/32060/1
diff --git a/lib/vdsm/tool/configurators/__init__.py b/lib/vdsm/tool/configurators/__init__.py
index 219d119..49071ff 100644
--- a/lib/vdsm/tool/configurators/__init__.py
+++ b/lib/vdsm/tool/configurators/__init__.py
@@ -44,9 +44,6 @@
class ModuleConfigure(object):
- def __init__(self):
- pass
-
def getName(self):
return None
diff --git a/lib/vdsm/tool/configurators/sanlock.py b/lib/vdsm/tool/configurators/sanlock.py
index 566c5e5..9225252 100644
--- a/lib/vdsm/tool/configurators/sanlock.py
+++ b/lib/vdsm/tool/configurators/sanlock.py
@@ -36,9 +36,6 @@
SANLOCK_GROUPS = (constants.QEMU_PROCESS_GROUP, constants.VDSM_GROUP)
- def __init__(self):
- super(Sanlock, self).__init__()
-
def getName(self):
return 'sanlock'
--
To view, visit http://gerrit.ovirt.org/32060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 7 months
Change in vdsm[master]: vdsm | netinfo : Return Mac of bond slaves in lower case
by gcheresh＠redhat.com
Genadi Chereshnya has uploaded a new change for review.
Change subject: vdsm | netinfo : Return Mac of bond slaves in lower case
......................................................................
vdsm | netinfo : Return Mac of bond slaves in lower case
getVdsCaps returns MAC of all interfaces in lower case and for bond slaves
it returned it in upper cases - fixing inconsistency
Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Bug-Url: https://bugzilla.redhat.com/1116810
Signed-off-by: Genadi Chereshnya <gcheresh(a)redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/31888/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index a3dc2ea..9080d46 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -438,8 +438,7 @@
if line.startswith('Slave Interface: '):
slave = line[len('Slave Interface: '):-1]
if line.startswith('Permanent HW addr: '):
- addr = line[len('Permanent HW addr: '):-1]
- paddr[slave] = addr.upper()
+ paddr[slave] = line[len('Permanent HW addr: '):-1]
return paddr
--
To view, visit http://gerrit.ovirt.org/31888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbd431b73fa1f381a897b6550e2b398009c0a7b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh(a)redhat.com>
9 years, 7 months
Change in vdsm[ovirt-3.5]: tool: Fix help message when is-configured fails
by mtayer＠redhat.com
Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32059
to review the following change.
Change subject: tool: Fix help message when is-configured fails
......................................................................
tool: Fix help message when is-configured fails
When is-configured fails for some modules, the help message suggested an
incorrect invocation:
vdsm-tool configure module-name
Instead of the correct:
vdsm-tool configure --module module-name
Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31783
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/32059/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 12cc0af..b799fde 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -111,7 +111,7 @@
One of the modules is not configured to work with VDSM.
To configure the module use the following:
-'vdsm-tool configure [module_name]'.
+'vdsm-tool configure [--module module-name]'.
If all modules are not configured try to use:
'vdsm-tool configure --force'
--
To view, visit http://gerrit.ovirt.org/32059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I417adfe55b3186418b61242b3ce63adcd5e9399e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 7 months
Change in vdsm[master]: Force flag not optional for detach storage domain
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Force flag not optional for detach storage domain
......................................................................
Force flag not optional for detach storage domain
Default value of force flag for detach sd not set but it should be
optional according to schema.
Bug-Url: https://bugzilla.redhat.com/1134290
Change-Id: Ia0b7b34464ec83bbf408df61c0193cd17e193e00
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Reviewed-on: http://gerrit.ovirt.org/32212
Reviewed-by: Allon Mureinik <amureini(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0b7b34464ec83bbf408df61c0193cd17e193e00
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in vdsm[master]: Force flag not optional for detach storage domain
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Force flag not optional for detach storage domain
......................................................................
Patch Set 1: Code-Review+2
Needs an urgent backport, I suppose?
--
To view, visit http://gerrit.ovirt.org/32212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b7b34464ec83bbf408df61c0193cd17e193e00
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 7 months
Change in vdsm[ovirt-3.5]: tool: Use space after comma when formatting lists
by mtayer＠redhat.com
Hello Nir Soffer, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32058
to review the following change.
Change subject: tool: Use space after comma when formatting lists
......................................................................
tool: Use space after comma when formatting lists
When formating list of modules in error message, we used to do:
foo,bar,baz
Now lists are formatted in more readable way:
foo, bar, baz
Change-Id: I88d742b72ba57ad1de481a589ca53e71c8202176
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31784
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/32058/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 268ae46..12cc0af 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -101,7 +101,7 @@
if m:
sys.stdout.write(
- "Modules %s are not configured\n " % ','.join(m),
+ "Modules %s are not configured\n " % ', '.join(m),
)
ret = False
@@ -135,7 +135,7 @@
if m:
sys.stdout.write(
- "Modules %s contains invalid configuration\n " % ','.join(m),
+ "Modules %s contains invalid configuration\n " % ', '.join(m),
)
ret = False
--
To view, visit http://gerrit.ovirt.org/32058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88d742b72ba57ad1de481a589ca53e71c8202176
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
9 years, 7 months
Change in vdsm[master]: Force flag not optional for detach storage domain
by Allon Mureinik
Allon Mureinik has posted comments on this change.
Change subject: Force flag not optional for detach storage domain
......................................................................
Patch Set 1: Code-Review+1
I'd fix the engine side to send it anyway too - explicit is better than implicit.
--
To view, visit http://gerrit.ovirt.org/32212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b7b34464ec83bbf408df61c0193cd17e193e00
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 7 months
Change in vdsm[ovirt-3.5]: tool: Fix another Python 2.6 compatibility issue
by mtayer＠redhat.com
Hello Nir Soffer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32057
to review the following change.
Change subject: tool: Fix another Python 2.6 compatibility issue
......................................................................
tool: Fix another Python 2.6 compatibility issue
Commit 096cc03d2f replaced the configurators tuple with a dict, using
dict comprehension syntax, which is not available on Python 2.6. Now we
use the good old dict() syntax instead.
We also silence a pep8-1.4.5 complaint.
Change-Id: Iee6e473d268317f7cdc42022a7a645e5eaee3a26
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132677
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31738
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-by: mooli tayer <mtayer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 5 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/32057/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index 6130d56..268ae46 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -34,13 +34,11 @@
def _getConfigurers():
- return {
- m.getName(): m for m in (
- certificates.Certificates(),
- libvirt.Libvirt(),
- sanlock.Sanlock(),
- )
- }
+ return dict((m.getName(), m) for m in (
+ certificates.Certificates(),
+ libvirt.Libvirt(),
+ sanlock.Sanlock(),
+ ))
@expose("configure")
--
To view, visit http://gerrit.ovirt.org/32057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6e473d268317f7cdc42022a7a645e5eaee3a26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
9 years, 7 months
