Change in vdsm[master]: net: ovs: draft of better rollback
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: net: ovs: draft of better rollback
......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/46805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89fda15bd1f3bfe2351f331e457ff83beafbce1f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 6 months
Change in vdsm[master]: vdsm: isolate fake_kvm into a hook
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: vdsm: isolate fake_kvm into a hook
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/46897
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 6 months
Change in vdsm[ovirt-3.6]: fakekvm: report correct POWER8 model
by Martin Polednik
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/46501
to review the following change.
Change subject: fakekvm: report correct POWER8 model
......................................................................
fakekvm: report correct POWER8 model
The power8 model should be in uppercase ('POWER8') to reflect current
libvirt and therefore be correctly recognized by engine.
Change-Id: Id4767a3dfaa7f482adff3627d8957d6767a7d561
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45249
Reviewed-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/caps.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/46501/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index c0cb2f6..fea309f 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -655,7 +655,7 @@
'model_Conroe,model_Penryn,model_Nehalem,model_Opteron_G1'
elif targetArch in Architecture.POWER:
caps['cpuModel'] = 'POWER 8 (fake)'
- caps['cpuFlags'] = 'powernv,model_power8'
+ caps['cpuFlags'] = 'powernv,model_POWER8'
else:
raise RuntimeError('Unsupported architecture: %s' % targetArch)
else:
--
To view, visit https://gerrit.ovirt.org/46501
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4767a3dfaa7f482adff3627d8957d6767a7d561
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
8 years, 6 months
Change in vdsm[master]: net: ovs: draft of better rollback
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: net: ovs: draft of better rollback
......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/46805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89fda15bd1f3bfe2351f331e457ff83beafbce1f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 6 months
Change in vdsm[master]: virt: devices: let Sound.__slots__ be tuple, not string
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: virt: devices: let Sound.__slots__ be tuple, not string
......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/46815
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc0ed46b171d3f5a61c80d62a48fc62f7ca6124
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <pdm(a)zamazal.org>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <pdm(a)zamazal.org>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 6 months
Change in vdsm[master]: virt: devices: let Sound.__slots__ be tuple, not string
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: let Sound.__slots__ be tuple, not string
......................................................................
virt: devices: let Sound.__slots__ be tuple, not string
This is just a trivial cosmetic change, to be consistent within the
code.
Change-Id: I0fc0ed46b171d3f5a61c80d62a48fc62f7ca6124
Signed-off-by: Milan Zamazal <pdm(a)zamazal.org>
Reviewed-on: https://gerrit.ovirt.org/46815
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Continuous-Integration: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/virt/vmdevices/core.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/46815
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fc0ed46b171d3f5a61c80d62a48fc62f7ca6124
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <pdm(a)zamazal.org>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <pdm(a)zamazal.org>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 6 months
Change in vdsm[master]: virt: devices: let Sound.__slots__ be tuple, not string
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: let Sound.__slots__ be tuple, not string
......................................................................
Patch Set 1: Continuous-Integration+1
What has happened to ci? Never mind for this patch.
--
To view, visit https://gerrit.ovirt.org/46815
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fc0ed46b171d3f5a61c80d62a48fc62f7ca6124
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <pdm(a)zamazal.org>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <pdm(a)zamazal.org>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
8 years, 6 months