Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() verbs
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs
......................................................................
Patch Set 5:
Manually rebase over parent patch.
--
To view, visit https://gerrit.ovirt.org/43058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() verbs
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs
......................................................................
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/43058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() verbs
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs
......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: migration: replace boolean with proper Events
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: migration: replace boolean with proper Events
......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/42887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02639749ab884c3542c4d29715756044d777f738
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: virt: Safe device type check for console device
by smelamud＠redhat.com
Hello Shmuel Melamud,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/42881
to review the following change.
Change subject: virt: Safe device type check for console device
......................................................................
virt: Safe device type check for console device
In Vm._getUnderlyingConsoleDeviceInfo() console device is searched
through the self.conf['devices'] list by checking 'device' field of each
element. Usage of dev['device'] expression for this is unsafe, because
for some devices (RNG device, for example) this key may be absent and
KeyError will be raised. Replaced this by dev.get('device') which is
safe.
Change-Id: I6a0c1adc6c3b2ab8d50b6e3ac712ce2dcf04cc6c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233825
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/42881/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4977d28..91cb1a0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -3908,7 +3908,7 @@
dev.alias = alias
for dev in self.conf['devices']:
- if dev['device'] == hwclass.CONSOLE and \
+ if dev.get('device') == hwclass.CONSOLE and \
not dev.get('alias'):
dev['alias'] = alias
--
To view, visit https://gerrit.ovirt.org/42881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a0c1adc6c3b2ab8d50b6e3ac712ce2dcf04cc6c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
7 years, 11 months
Change in vdsm[master]: tests: network: when using bonding, attach at least 2 slaves
by phoracek＠redhat.com
Petr Horáček has uploaded a new change for review.
Change subject: tests: network: when using bonding, attach at least 2 slaves
......................................................................
tests: network: when using bonding, attach at least 2 slaves
In some tests we attach just one slave to a bonding, it works
with native linux bonding, but does not allow us to use existing
for OVS bonding.
Change-Id: I1763bc3409aa7da91dcd2e3b21dd8540870138ef
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 34 insertions(+), 26 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/41840/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 5702580..352c7c6 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -585,7 +585,7 @@
@cleanupNet
@permutations([[True], [False]])
def testFailWithInvalidBondingName(self, bridged):
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
invalid_bond_names = ('bond', 'bonda', 'bond0a', 'jamesbond007')
for bond_name in invalid_bond_names:
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
@@ -690,7 +690,7 @@
VLAN_COUNT = 5
NET_VLANS = [(NETWORK_NAME + str(index), str(index))
for index in range(VLAN_COUNT)]
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
firstVlan, firstVlanId = NET_VLANS[0]
status, msg = self.vdsm_net.addNetwork(firstVlan, vlan=firstVlanId,
bond=BONDING_NAME,
@@ -719,7 +719,7 @@
@cleanupNet
@permutations([[True], [False]])
def testAddNetworkVlanBond(self, bridged):
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
vlan_id = '42'
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
vlan=vlan_id,
@@ -759,7 +759,7 @@
@permutations([[True], [False]])
def testDelNetworkWithMTU(self, bridged):
MTU = '1234'
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, vlan=VLAN_ID,
bond=BONDING_NAME,
nics=nics,
@@ -1334,7 +1334,7 @@
@cleanupNet
def testDelNetworkBondAccumulation(self):
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
for bigBond in ('bond555', 'bond666', 'bond777'):
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME, VLAN_ID,
bigBond, nics)
@@ -1352,15 +1352,15 @@
@cleanupNet
@permutations([[True], [False]])
def testSetupNetworksResizeBond(self, bridged):
- with dummyIf(3) as nics:
+ with dummyIf(4) as nics:
with self.vdsm_net.pinger():
- bondings = {BONDING_NAME: dict(nics=nics[:1],
+ bondings = {BONDING_NAME: dict(nics=nics[:2],
bridged=bridged)}
status, msg = self.vdsm_net.setupNetworks({}, bondings, {})
self.assertEquals(status, SUCCESS, msg)
- self.assertBondExists(BONDING_NAME, nics=nics[:1])
+ self.assertBondExists(BONDING_NAME, nics=nics[:2])
# Increase bond size
bondings[BONDING_NAME]['nics'] = nics
@@ -1372,14 +1372,14 @@
# Reduce bond size
REQMODE_BROADCAST = '3'
- bondings[BONDING_NAME]['nics'] = nics[:2]
+ bondings[BONDING_NAME]['nics'] = nics[:3]
bondings[BONDING_NAME]['options'] = ('mode=%s' %
REQMODE_BROADCAST)
status, msg = self.vdsm_net.setupNetworks({}, bondings, {})
self.assertEquals(status, SUCCESS, msg)
- self.assertBondExists(BONDING_NAME, nics[:2],
+ self.assertBondExists(BONDING_NAME, nics[:3],
bondings[BONDING_NAME]['options'])
bondings = {BONDING_NAME: dict(remove=True)}
@@ -2079,7 +2079,7 @@
@permutations([[True], [False]])
@cleanupNet
def testSetupNetworksEmergencyDevicesCleanupVlanOverwrite(self, bridged):
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
nic, = nics
network = {NETWORK_NAME: {'vlan': VLAN_ID, 'bridged': bridged,
'nic': nic}}
@@ -2104,7 +2104,7 @@
@permutations([[True], [False]])
@cleanupNet
def testSetupNetworksEmergencyDevicesCleanupBondOverwrite(self, bridged):
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
nic, = nics
network = {NETWORK_NAME: {'bridged': bridged,
'bonding': BONDING_NAME}}
@@ -2232,7 +2232,7 @@
@cleanupNet
def testSetupNetworksRemoveSlavelessBond(self):
- with dummyIf(1) as nics:
+ with dummyIf(2) as nics:
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME:
{'bonding': BONDING_NAME, 'bridged': False}},
@@ -2241,9 +2241,9 @@
self.assertNetworkExists(NETWORK_NAME)
self.assertBondExists(BONDING_NAME, nics)
- nic, = nics
with open(BONDING_SLAVES % BONDING_NAME, 'w') as f:
- f.write('-%s\n' % nic)
+ for nic in nics:
+ f.write('-%s\n' % nic)
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: {'remove': True}},
@@ -2281,19 +2281,20 @@
raise SkipTest(
"with ifcfg persistence, vdsm-restore-net-config "
"doesn't restore in-kernel state")
- with dummyIf(1) as (nic, ):
+ with dummyIf(2) as nics:
with open(BONDING_MASTERS, 'w') as bonds:
bonds.write('+%s\n' % BONDING_NAME)
try:
with open(BONDING_SLAVES % BONDING_NAME, 'w') as f:
- f.write('+%s\n' % nic)
+ for nic in nics:
+ f.write('+%s\n' % nic)
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME:
{'bonding': BONDING_NAME, 'bridged': False}},
- {BONDING_NAME: {'nics': [nic]}}, NOCHK)
+ {BONDING_NAME: {'nics': nics}}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkExists(NETWORK_NAME)
- self.assertBondExists(BONDING_NAME, [nic])
+ self.assertBondExists(BONDING_NAME, nics)
finally:
with open(BONDING_MASTERS, 'w') as bonds:
bonds.write('-%s\n' % BONDING_NAME)
@@ -2302,27 +2303,34 @@
self.vdsm_net.restoreNetConfig()
self.assertNetworkExists(NETWORK_NAME)
- self.assertBondExists(BONDING_NAME, [nic])
+ self.assertBondExists(BONDING_NAME, nics)
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: {'remove': True}},
{BONDING_NAME: {'remove': True}}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkDoesntExist(NETWORK_NAME)
- self.assertBondDoesntExist(BONDING_NAME, [nic])
+ self.assertBondDoesntExist(BONDING_NAME, nics)
self.vdsm_net.save_config()
@cleanupNet
@ValidateRunningAsRoot
def test_setupNetworks_on_external_vlaned_bond(self):
- with dummyIf(1) as (nic, ):
- with open(NET_CONF_PREF + nic, 'w') as f:
+ with dummyIf(2) as nics:
+ with open(NET_CONF_PREF + nics[0], 'w') as f:
f.write("""DEVICE=%s
MASTER=%s
SLAVE=yes
ONBOOT=yes
MTU=1500
-NM_CONTROLLED=no""" % (nic, BONDING_NAME))
+NM_CONTROLLED=no""" % (nics[0], BONDING_NAME))
+ with open(NET_CONF_PREF + nics[1], 'w') as f:
+ f.write("""DEVICE=%s
+MASTER=%s
+SLAVE=yes
+ONBOOT=yes
+MTU=1500
+NM_CONTROLLED=no""" % (nics[1], BONDING_NAME))
with open(NET_CONF_PREF + BONDING_NAME, 'w') as f:
f.write("""DEVICE=%s
BONDING_OPTS='mode=802.3ad miimon=150'
@@ -2354,7 +2362,7 @@
self.vdsm_net.restoreNetConfig()
self.assertNetworkExists(NETWORK_NAME)
- self.assertBondExists(BONDING_NAME, [nic])
+ self.assertBondExists(BONDING_NAME, nics)
self.assertVlanExists(BONDING_NAME + '.' + VLAN_ID)
status, msg = self.vdsm_net.setupNetworks(
@@ -2362,5 +2370,5 @@
{BONDING_NAME: {'remove': True}}, NOCHK)
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkDoesntExist(NETWORK_NAME)
- self.assertBondDoesntExist(BONDING_NAME, [nic])
+ self.assertBondDoesntExist(BONDING_NAME, nics)
self.vdsm_net.save_config()
--
To view, visit https://gerrit.ovirt.org/41840
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1763bc3409aa7da91dcd2e3b21dd8540870138ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
7 years, 11 months
Change in vdsm[master]: adding StorageDomain.removeVmData()
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: adding StorageDomain.removeVmData()
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43154
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53b19a43850341ee488b50fbb339fdf68c1a048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: adding StorageDomain.activateHsm()
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: adding StorageDomain.activateHsm()
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/43153
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68eccd300b8ba0cc45b2485f978eb3ae367c16e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: adding StorageDomain.updateVmData()
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: adding StorageDomain.updateVmData()
......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/42930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id79e7d6375e60216d1eb9a58e5a5c087db98625f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months
Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb
by automation＠ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: adding the StorageDomain.upgradeVersion verb
......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/42478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8fb87c6e04e48072ec90d07a0f4c7a61411a808
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 11 months