July 2015 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: virt: tolerate missing ovirt-vmconsole group

by fromani＠redhat.com

Francesco Romani has uploaded a new change for review. Change subject: virt: tolerate missing ovirt-vmconsole group ...................................................................... virt: tolerate missing ovirt-vmconsole group To support the virtio serial console feature, VDSM must bind the virtio channel to an unix domain socket, and fix its permissions and group in order to let ovirt-vmconsole-host connect to that socket. ovirt-vmconsole-host it is a soft dependency. VDSM should happily run without that package, but incorrectly assumed the ovirt-vmconsole group existed in the system This patch lift this requirement: VDSM still try to fix the group of the socket, but if the group doesn't exist, it happily goes ahead. Change-Id: I55b708953e5871053f0063bb82434c5c0dcb6103 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M vdsm/virt/vmdevices/core.py 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/42451/1 diff --git a/vdsm/virt/vmdevices/core.py b/vdsm/virt/vmdevices/core.py index a847ce0..4d56005 100644 --- a/vdsm/virt/vmdevices/core.py +++ b/vdsm/virt/vmdevices/core.py @@ -99,9 +99,14 @@ def prepare(self): if self._path: - supervdsm.getProxy().prepareVmChannel( - self._path, - constants.OVIRT_VMCONSOLE_GROUP) + try: + supervdsm.getProxy().prepareVmChannel( + self._path, + constants.OVIRT_VMCONSOLE_GROUP) + except KeyError: + self.log.warn('unknown group %s, permissions not updated', + constants.OVIRT_VMCONSOLE_GROUP) + def cleanup(self): if self._path: -- To view, visit https://gerrit.ovirt.org/42451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I55b708953e5871053f0063bb82434c5c0dcb6103 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

7 years, 11 months

5
27
0 / 0

Change in vdsm[master]: migration: replace boolean with proper Events

by automation＠ovirt.org

automation(a)ovirt.org has posted comments on this change. Change subject: migration: replace boolean with proper Events ...................................................................... Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02639749ab884c3542c4d29715756044d777f738 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() apis.

by Maor Lipchuk

Maor Lipchuk has posted comments on this change. Change subject: snapshot: Add VM.freeze() and VM.thaw() apis. ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: adding StorageDomain.removeVmData()

by automation＠ovirt.org

automation(a)ovirt.org has posted comments on this change. Change subject: adding StorageDomain.removeVmData() ...................................................................... Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic964ac5c9cb57df881b895356a203529ab2a171a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: register: Replace log location

by Douglas Schilling Landgraf

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: register: Replace log location ...................................................................... register: Replace log location The register tool is integrated to vdsm-tool but can be used without vdsm. This patch replaces the log location. Change-Id: I884c7c09dc16829752dc3801d1977e0097733939 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M lib/vdsm/tool/register.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/42831/1 diff --git a/lib/vdsm/tool/register.py b/lib/vdsm/tool/register.py index 3ac3fc6..9b59e5f 100644 --- a/lib/vdsm/tool/register.py +++ b/lib/vdsm/tool/register.py @@ -179,13 +179,13 @@ def _set_logger(self): """ The logging settings - Saving log in: /var/log/vdsm/register.log + Saving log in: /var/log/ovirt-register.log """ logger = logging.getLogger(__name__) logger.setLevel(logging.DEBUG) logger.propagate = False - fh = logging.FileHandler("/var/log/vdsm/register.log") + fh = logging.FileHandler("/var/log/ovirt-register.log") fh.setLevel(logging.DEBUG) debug_fmt = logging.Formatter("%(asctime)s %(message)s", "%m/%d/%Y %I:%M:%S %p") -- To view, visit https://gerrit.ovirt.org/42831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I884c7c09dc16829752dc3801d1977e0097733939 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>

7 years, 11 months

2
5
0 / 0

Change in vdsm[ovirt-3.5]: Balloon should not work when guest agent is not present

by Martin Sivak

Hello Adam Litke, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42968 to review the following change. Change subject: Balloon should not work when guest agent is not present ...................................................................... Balloon should not work when guest agent is not present StatAvg returns 0 when there is no data available. We need to use Stat here so we get None and properly fail the condition. Change-Id: Ic164043259a2936243e572c14705afa064f92171 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232669 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/42207 Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M vdsm/mom.d/02-balloon.policy 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/42968/1 diff --git a/vdsm/mom.d/02-balloon.policy b/vdsm/mom.d/02-balloon.policy index 570c751..b1af0d5 100644 --- a/vdsm/mom.d/02-balloon.policy +++ b/vdsm/mom.d/02-balloon.policy @@ -116,7 +116,7 @@ }) (with Guests guest - (if (valid guest.balloon_cur (guest.StatAvg "mem_unused")) + (if (valid guest.balloon_cur (guest.Stat "mem_unused")) (balloon_logic guest) (debug "Memory information is missing, ballooning for" guest "disabled"))) -- To view, visit https://gerrit.ovirt.org/42968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic164043259a2936243e572c14705afa064f92171 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>

7 years, 11 months

5
8
0 / 0

Change in vdsm[master]: snapshot: Add VM.freeze() and VM.thaw() apis.

by automation＠ovirt.org

automation(a)ovirt.org has posted comments on this change. Change subject: snapshot: Add VM.freeze() and VM.thaw() apis. ...................................................................... Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44c4237841e44548f48f626f4241d3f2e484930e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: adding StorageDomain.removeVmData()

by automation＠ovirt.org

automation(a)ovirt.org has posted comments on this change. Change subject: adding StorageDomain.removeVmData() ...................................................................... Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic964ac5c9cb57df881b895356a203529ab2a171a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: adding StorageDomain.activateHsm()

by automation＠ovirt.org

automation(a)ovirt.org has posted comments on this change. Change subject: adding StorageDomain.activateHsm() ...................................................................... Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic661b44b060ddfeeb2a2caedb2662c6102b950e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

Change in vdsm[master]: adding StorageDomain.updateVmData()

by automation＠ovirt.org

automation(a)ovirt.org has posted comments on this change. Change subject: adding StorageDomain.updateVmData() ...................................................................... Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id79e7d6375e60216d1eb9a58e5a5c087db98625f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

7 years, 11 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches July 2015