Change in vdsm[master]: v2v: handle exception on probing external VMs
by shavivi@redhat.com
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: handle exception on probing external VMs
......................................................................
v2v: handle exception on probing external VMs
XMLDesc of libvirt domain can throw error,
We don't want to fail all the process of fetching external VMs if we
fail to read one VM xml.
Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M vdsm/v2v.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/43259/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index b6763da..307c005 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -139,7 +139,11 @@
with closing(conn):
vms = []
for vm in conn.listAllDomains():
- root = ET.fromstring(vm.XMLDesc(0))
+ try:
+ root = ET.fromstring(vm.XMLDesc(0))
+ except libvirt.libvirtError as e:
+ logging.error('error reading domain xml, msg: %s', e.message)
+ continue
params = {}
_add_vm_info(vm, params)
try:
--
To view, visit https://gerrit.ovirt.org/43259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
7 years, 7 months
Change in vdsm[master]: tests: Isolate tcTests test properly
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: tests: Isolate tcTests test properly
......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/44144
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3861ccfb432541b63d7ba5814f7e3ae339ec8105
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 7 months
Change in vdsm[master]: stomp: fix typo 'non bolocking'->'non-blocking'
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: stomp: fix typo 'non bolocking'->'non-blocking'
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/44257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1804f84b805752c458b8b4c719a058e669b04b1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: hwbi <hwbi2008(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 7 months
Change in vdsm[master]: stomp: fix typo 'non bolocking'->'non-blocking'
by automation@ovirt.org
automation(a)ovirt.org has posted comments on this change.
Change subject: stomp: fix typo 'non bolocking'->'non-blocking'
......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/44257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1804f84b805752c458b8b4c719a058e669b04b1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: hwbi <hwbi2008(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7 years, 7 months